{"id":27319,"url":"https://patchwork.libcamera.org/api/1.1/patches/27319/?format=json","web_url":"https://patchwork.libcamera.org/patch/27319/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260708-libipa-algorithms-v5-11-0759d0359f52@ideasonboard.com>","date":"2026-07-08T15:50:53","name":"[v5,11/36] ipa: libipa: lsc_polynomial: Fix polynomial parsing error","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ea3fe6daf01db745db5a4b35986ba7698397b649","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27319/mbox/","series":[{"id":6048,"url":"https://patchwork.libcamera.org/api/1.1/series/6048/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6048","date":"2026-07-08T15:50:42","name":"ipa: libipa: Introduce libipa algorithms","version":5,"mbox":"https://patchwork.libcamera.org/series/6048/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27319/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27319/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5637FC3261\n\tfor ;\n\tWed, 8 Jul 2026 15:51:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4BCB660EA;\n\tWed, 8 Jul 2026 17:51:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 630BE660A5\n\tfor ;\n\tWed, 8 Jul 2026 17:51:15 +0200 (CEST)","from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93A3F1D27;\n\tWed, 8 Jul 2026 17:50:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gyQ7Kcl1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783525825;\n\tbh=rFLCmzTAiGZxfdqplp4EQ86F28eJB4eSKIzc7E7rlXE=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=gyQ7Kcl12DQqEYXYB5UgERb/Z2TwDFWmTUOz3KFL8UgrFKwNN7ZAUHovyQFvBdgn3\n\tcqwfna3s0/tqXMVclhmadnwsgFvoPONFJ+rXhwRA6AIRFtVhzDiCRlZQOcY0Q42Ld8\n\tsCBA7+NeVA/hRQ/UCoMGrZzw20UmjgyTldaagT9Q=","From":"Jacopo Mondi ","Date":"Wed, 08 Jul 2026 17:50:53 +0200","Subject":"[PATCH v5 11/36] ipa: libipa: lsc_polynomial: Fix polynomial\n\tparsing error","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260708-libipa-algorithms-v5-11-0759d0359f52@ideasonboard.com>","References":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>","In-Reply-To":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug ","Cc":"Jacopo Mondi ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1278;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=rFLCmzTAiGZxfdqplp4EQ86F28eJB4eSKIzc7E7rlXE=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqTnHj2cTRs9HXA/ikX2koXWd8sDF3uvSLiZCXy\n\t2OClU0f4COJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak5x4wAKCRByNAaPFqFW\n\tPOm5D/9wNVfbCcJWHsJRlvWEOqaEtXVyL22s9BYbzZGDmnisxmP5evQ5SsaaT9IWHU2HgSxxxXE\n\tEYPXjBHgrEkTtx2K1ckzbca3+V3PqOtzudAr4BJKOaUUD4jd92p/1jVRu7zroPDWyTYFScg/BAO\n\t6TE8ltBFQnla5rPjjomJSJIqYjVOHNxqYs0dX4K4eRKFUi28m2ZpOYaVgfmP7znQLoBGAUYgpM/\n\taHPeJlm0JTO3ISpnl0ZwU+MlH47ZRNB5AEFRRT/Agpi61D1H2GLoEIFu+2OqbCm/DScNGdILm0i\n\twxK7NJiOs02MaQMMpxtMnIdBmJ9xa3MtlJ9hyvJtFtPUA4S4MIPQeDfhGqyVkVZa8xzgjIALzr2\n\tUUxaR9e6DWi327IY2/IPjkFHUrmvSkI+4Fpw39dwEJgaNQi/wekTcOssf9tLyT2h0bZxcg5wq2I\n\trP2wwfPbbmn9nEFBJFTDFF8OTT7yH16+J0qcWOJ9k2sPMZFSfL4Vyq5PY8U+Z9PfVGLzx9ZlroE\n\t35qjnVyDmoGaR6RuvznENDUp/EZxhkPEzngh7r9A7Y8RbtvN2LhUjoiJVvGZqNfRN8JBF+mGwsD\n\tSVk9SsDmKE6Z0XgzRCy33PNvacEN7QwyqNSbn0K5Iiv0GNsX9+taPJS4ddX5LIj7TRm2EONw3iq\n\trCgIgrWKZnws8Vg==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If any of the polynomial component is missing in the tuning file the\nValueNode::Accessor specialization emits an\nerror message but continues and dereferences a potentially\ninvalid object.\n\nFix it by returning std::nullopt if a polynomial component is missing.\n\nThe caller already checks if the returned value is valid or not, causing\nthe algorithm initialization to fail if the tuning file is invalid.\n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/libipa/lsc_polynomial.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex d7d9ae42e360..a0d27c4b21d6 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -94,9 +94,11 @@ struct ValueNode::Accessor {\n \t\tstd::optional k3 = obj[\"k3\"].get();\n \t\tstd::optional k4 = obj[\"k4\"].get();\n \n-\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4))\n+\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4)) {\n \t\t\tLOG(LscPolynomial, Error)\n \t\t\t\t<< \"Polynomial is missing a parameter\";\n+\t\t\treturn std::nullopt;\n+\t\t}\n \n \t\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n \t}\n","prefixes":["v5","11/36"]}