{"id":27292,"url":"https://patchwork.libcamera.org/api/1.1/patches/27292/?format=json","web_url":"https://patchwork.libcamera.org/patch/27292/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260708-libipa-algorithms-v4-27-f0e99f035294@ideasonboard.com>","date":"2026-07-08T09:25:14","name":"[v4,27/35] ipa: libipa: lsc_polynomial: Remove sensorSize_","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dde145bcfa9c356e6da60fedba2fd63929dd809c","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27292/mbox/","series":[{"id":6046,"url":"https://patchwork.libcamera.org/api/1.1/series/6046/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6046","date":"2026-07-08T09:24:47","name":"ipa: libipa: Introduce libipa algorithms","version":4,"mbox":"https://patchwork.libcamera.org/series/6046/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27292/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27292/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AAE4C333A\n\tfor ;\n\tWed, 8 Jul 2026 09:25:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9AAB66098;\n\tWed, 8 Jul 2026 11:25:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F3D96609B\n\tfor ;\n\tWed, 8 Jul 2026 11:25:13 +0200 (CEST)","from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B79C31CFD;\n\tWed, 8 Jul 2026 11:24:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JxUAW8A+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783502663;\n\tbh=MRTK0aOxYFXDosRsnpj0oYQp6lv1gMPMd910d2p1od0=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=JxUAW8A+zKxlDZoNsxoBfjhYiyGi7D3Zrfb300hCgxChiihukwVpLq1NPJIa9rsXe\n\tgWE7GfBetDLslihohoWQFEpsZIrxrzBAS4MumGHI5Ot7y+X3pFSIlsMRKU9nlH6dDW\n\tgoMlgReBOktl1q7aErgFIaZQb6By+Ta++MbP8DsQ=","From":"Jacopo Mondi ","Date":"Wed, 08 Jul 2026 11:25:14 +0200","Subject":"[PATCH v4 27/35] ipa: libipa: lsc_polynomial: Remove sensorSize_","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260708-libipa-algorithms-v4-27-f0e99f035294@ideasonboard.com>","References":"<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>","In-Reply-To":"<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug ","Cc":"Jacopo Mondi , \n\tKieran Bingham ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3254;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=MRTK0aOxYFXDosRsnpj0oYQp6lv1gMPMd910d2p1od0=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqThdvmfQw/9/RzQZJL5NQHcdi1jaKu1mlk2y28\n\tLJlfjU9rW2JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak4XbwAKCRByNAaPFqFW\n\tPFCND/sESeWf1aZTT9lpH/rrhOXpitjPXagGW//CFN4B/BwZr/OdKhZ4Evc3edb5XMln/PJ8S40\n\t6r11wApQO7tPrGx1IAPnYoox0i4rUp/ZpjCBaBWqnzfXhKfkEGoyw68lt8OZlXcAgWnAQstaAzR\n\tjwTse3jocELUZ+3SsWLbFzNx7t8mWpUB9Y13kfHdVhY7bO4K4/IMJT1xqJjqScRv+tJgIBBBaR3\n\tV3s8QpMmhwDMmdDz9LsJVh8PldOGG22yxFf0rc6ke5qvZQ6fNJomxFbrU6WRFvLukvlkd7oXcfA\n\ttgkeQJoM673JOIHwGMPmEO1iB5VcYB8hNDZcqpafMq22LXJExt/S0K2PGT3tV3KjbGw4/DK2RFT\n\tLNP6sfK8On5b66GQSzS183ZuJfpVZqwpzKbIZS9URQZ4cycL6a9KIlQQ1yy40RF+82Fbc6r90im\n\tuXQHk43Eqcs7vBt9GI3O3Hb1X9niZKWuq2Pibhd6NAkr70AjYuGyv0Xh1n/7uiy0deNiXRB++uL\n\tYjlPnTdzL5bP7jN0NeQzLURV8pimJse9wCUrdNj6vJ9V14bg3lHl1jPhCVpXNq+S3HOC2uQCEvW\n\t1rcsqDrvA+evdwSun8q7Pz/dS0a5DT0ESufvLky2nb0GqVBhu7zi+o2I/k4S3ToY/uSm8SYbxRK\n\t1pn0lEpLPt9rB6Q==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The sensorSize_ field is only used during the init() function and is\nprovided to LscPolynomial using the LscDescriptor type.\n\nThere is no need to store it as a class member and to pass it in\nat class construction time.\n\nRemove it and move the \\todo comment in the LscDescriptor type\ndocumentation.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \n---\n src/ipa/libipa/lsc.cpp | 6 +-----\n src/ipa/libipa/lsc_base.cpp | 3 +++\n src/ipa/libipa/lsc_polynomial.cpp | 7 -------\n src/ipa/libipa/lsc_polynomial.h | 6 ------\n 4 files changed, 4 insertions(+), 18 deletions(-)","diff":"diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex 26c3e9968072..1d2f8eb1b41b 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control\n \t\timpl_ = std::make_unique();\n \t\tLOG(Lsc, Debug) << \"Using table-based Lsc\";\n \t} else if (type == \"polynomial\") {\n-\t\t/*\n-\t\t * \\todo: Most likely the reference frame should be native_size.\n-\t\t * Let's wait how the internal discussions progress.\n-\t\t */\n-\t\timpl_ = std::make_unique(descriptor.sensorSize);\n+\t\timpl_ = std::make_unique();\n \t\tpolynomial_ = true;\n \t\tLOG(Lsc, Debug) << \"Using polynomial Lsc\";\n \t} else {\ndiff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex 919622c6b951..adc09c15752a 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -78,6 +78,9 @@ void Interpolator::\n * \\var LscDescriptor::sensorSize\n * \\brief The physical sensor size. This is the largest frame size used to\n * generate the LSC table. Only used by the polynomial LSC algorithm\n+ *\n+ * \\todo: Most likely the reference frame should be native_size.\n+ * Let's wait how the internal discussions progress.\n */\n \n /**\ndiff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex 83594bb52696..110b43157ff3 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size)\n * \\sa LscImplementation\n */\n \n-/**\n- * \\fn LscPolynomial::LscPolynomial\n- * \\param[in] sensorSize The physical sensor size\n- *\n- * Construct an LscPolynomial\n- */\n-\n /**\n * \\brief Parse polynomial LSC data\n * \\param[in] sets The tuning file content\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex 2a26db499d68..6d19e46a50b7 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -57,11 +57,6 @@ private:\n \tusing PolynomialComponentsMap = std::map;\n \n public:\n-\tLscPolynomial(const Size &sensorSize)\n-\t\t: sensorSize_(sensorSize)\n-\t{\n-\t}\n-\n \tint parseLscData(const ValueNode &sets,\n \t\t\t const LscDescriptor &descriptor) override;\n \n@@ -75,7 +70,6 @@ private:\n \t\t\t\t\t Span yPositions,\n \t\t\t\t\t const Rectangle &cropRectangle);\n \tPolynomialComponentsMap lscData_;\n-\tSize sensorSize_;\n };\n \n } /* namespace ipa */\n","prefixes":["v4","27/35"]}