{"id":27283,"url":"https://patchwork.libcamera.org/api/1.1/patches/27283/?format=json","web_url":"https://patchwork.libcamera.org/patch/27283/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260708-libipa-algorithms-v4-18-f0e99f035294@ideasonboard.com>","date":"2026-07-08T09:25:05","name":"[v4,18/35] ipa: libipa: lsc_base: Add sampleForCrop documentation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"088ffed4f35d6ebfb7aa5a607ee3e4baa48a4a83","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27283/mbox/","series":[{"id":6046,"url":"https://patchwork.libcamera.org/api/1.1/series/6046/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6046","date":"2026-07-08T09:24:47","name":"ipa: libipa: Introduce libipa algorithms","version":4,"mbox":"https://patchwork.libcamera.org/series/6046/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27283/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27283/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB0AEC3332\n\tfor ;\n\tWed, 8 Jul 2026 09:25:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57D8A660B8;\n\tWed, 8 Jul 2026 11:25:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C94EE6607C\n\tfor ;\n\tWed, 8 Jul 2026 11:25:10 +0200 (CEST)","from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C2AB3FAF;\n\tWed, 8 Jul 2026 11:24:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dGW1yM+z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783502661;\n\tbh=ZQB2/8/lfwl0b3X1amVOEn3MSG9P/pJyN8UbLOUxTSE=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=dGW1yM+z5kSEMTgWwXORnGww72Vlxw35BV9WssEYDFNtD8h1rbH9ymIoO9hG9b4Tl\n\t7UwfVxY8KwUgvIklJ5T8XQwpvjwud5K+pYEIUJjRhp1/0KwftwPH11OQLeVKTyuDjg\n\txBuSZxRIiYrcFpWaJxIeo+9T1o72m70vi1J0Loug=","From":"Jacopo Mondi ","Date":"Wed, 08 Jul 2026 11:25:05 +0200","Subject":"[PATCH v4 18/35] ipa: libipa: lsc_base: Add sampleForCrop\n\tdocumentation","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260708-libipa-algorithms-v4-18-f0e99f035294@ideasonboard.com>","References":"<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>","In-Reply-To":"<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug ","Cc":"Jacopo Mondi ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1459;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=ZQB2/8/lfwl0b3X1amVOEn3MSG9P/pJyN8UbLOUxTSE=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqThdu1GCg42iOFvniekYWlEumB09cx7jdDVhX2\n\tPpR8BTEzmuJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak4XbgAKCRByNAaPFqFW\n\tPOAaD/9i0MV8LUMT20wKkqlyTUP3GnwukvWNG/dSWQ60ATB6OCau5jaFE8zdf06Eqwa4QAk8j7F\n\t1VnCz0nG8CZlghQE17R759sd+PXbzI2XsQYEzWvZGJ796zz8vSWmEnh9waNXIGtNxWdn55lQUWc\n\thXE7qYr24CuaYiMafqdBVNlm9VBcQAMNnZ8Il7p2Bv6eD8TbdPnU2yudpKlwLThDFmgFPzZ2dB6\n\tJjqnLIFVFYXTgAMVi7YivGBapXq61diW+S0J3UN0qbwyLeqMVO5K3+f9jm3M6obC3IsJ31Oqhmf\n\tLC2J12jm4aw07FXcmI16Tf1qRVd97xTh6NgXY5wWrnUWyjHUUiXttKfqfHX/9uu4aEcDUwtnjdP\n\t+fthJgpEt9LUXc0o/AsfpSM5xHEZfGH0f5efuw2vdeKJ+BK+uHhiW149FXYuYsVATsmqObnpCnb\n\t7bXIDcDnte4JaALj2PIqsirxR+aS0LR/HCxXxJiyVfef+Io8MwKoS4jGA4Kxf7wgXiKH42dToCn\n\tGVYZtQf7rIMEOd2RnoDYxSlOaGE0esjAld1s8HyZNAnpmqKPjnXAMAhJCJoNW8sl4rcthZ2exAV\n\t+UPRrkRAl0iMXXxTgcP7Urfe+BQFAfhiDRX00CVaB6hLtUmul7OBbhijPBlTN8CSn/NWnppW9HS\n\tgcmlLIzlo2ZGZPA==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that we have two in-tree implementations of LscImplementation\ndetail how the two perform lsc gain re-sampling.\n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/libipa/lsc_base.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)","diff":"diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex 945020794b57..678ba8a9a808 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -103,6 +103,21 @@ void Interpolator::\n * each segment of size 0.0625 and the list of nodes position will be\n * [0, 0.0625, 0.125, 0.1875, ... , 1]. It is expected that the first position\n * is 0 and the last position is 1.\n+ *\n+ * LSC tables are expressed in two formats:\n+ * - A list of gain values (LscTable)\n+ * - A radial polynomial (LscPolynomial)\n+ *\n+ * Table-based LSC tables are generated using an image at a fixed resolution and\n+ * can't at the moment be re-sampled when a different resolution is used for a\n+ * streaming session. Re-sampling a grid LSC table will return the same table\n+ * as loaded from the tuning file.\n+ *\n+ * \\todo: Implement grid based re-sampling\n+ *\n+ * Polynomial configurations are more flexible and can be re-sampled for a given\n+ * sensor frame resolution using a list of horizontal and vertical nodes that\n+ * define the LSC grid on which the polynomial is re-sampled on.\n */\n \n } /* namespace ipa */\n","prefixes":["v4","18/35"]}