{"id":27276,"url":"https://patchwork.libcamera.org/api/1.1/patches/27276/?format=json","web_url":"https://patchwork.libcamera.org/patch/27276/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260708-libipa-algorithms-v4-11-f0e99f035294@ideasonboard.com>","date":"2026-07-08T09:24:58","name":"[v4,11/35] ipa: libipa: lsc_polynomial: Don't inline ValueNode accessor","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"745b1fd64b786ed128fbe450896827271e980848","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27276/mbox/","series":[{"id":6046,"url":"https://patchwork.libcamera.org/api/1.1/series/6046/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6046","date":"2026-07-08T09:24:47","name":"ipa: libipa: Introduce libipa algorithms","version":4,"mbox":"https://patchwork.libcamera.org/series/6046/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27276/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27276/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5036C3301\n\tfor ;\n\tWed, 8 Jul 2026 09:25:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3549660B7;\n\tWed, 8 Jul 2026 11:25:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EFF96608F\n\tfor ;\n\tWed, 8 Jul 2026 11:25:08 +0200 (CEST)","from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1D5F1D27;\n\tWed, 8 Jul 2026 11:24:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TlRqLiFW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783502658;\n\tbh=rYGOyJqlg6KGcH57Gl0nXxGuPBsSavnxemzwwosWMBY=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=TlRqLiFWgWYiWQ+o/7ETV/dMYO7FUikq0uve9FALG1pHGDQA0XDr8m2hKapuxWRCK\n\t+edz+peWTDeOh+Iz9S7Z0vEpLXOtEhbDRzbvZuCdwvyhLVTzatPKKrQZQr0OQmsbw7\n\t+jrwrcer77V8WFtOsey4+O9icODMN1+qox8TDR+g=","From":"Jacopo Mondi ","Date":"Wed, 08 Jul 2026 11:24:58 +0200","Subject":"[PATCH v4 11/35] ipa: libipa: lsc_polynomial: Don't inline\n\tValueNode accessor","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260708-libipa-algorithms-v4-11-f0e99f035294@ideasonboard.com>","References":"<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>","In-Reply-To":"<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug ","Cc":"Jacopo Mondi , \n\tLaurent Pinchart , \n\tKieran Bingham ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2952;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=BEf1W1AyI5E5rj0wvDTXSlHFS7EeY8EQyX6MdqC3noI=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqThdtS6mkGIhgjjlkvAyPgbi6XgJ8eSKAs7JRs\n\tVuhvx8yjhiJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak4XbQAKCRByNAaPFqFW\n\tPJhKD/0TGZPWugWM8278SR+XI2eh6mAkSHzU5Iy4ZoGje3NTWKji6VLdm45UNkjotARtz+IvS59\n\tyYRwVqnUivJ4+XUPavwwFKVAYhxp5KLuf1g/sq9eKwDoWU/WQvoex/mibZ2Y2RMFriXTXcocFJY\n\tfEkww0MPO3esfy57DxX3oU+z/fgG1bKyEf5f0SjvziCS+/7sytB60HaZaU85vtAXqqyUgxFeV9C\n\tPvBPAAWEloRPRaEgLkqkVRyakwZpwcTkQOlphc+B2UAGYiie102E6sFlpHpdSjPb3cIIlEXgLyM\n\t7z2kxHlscFc0VMFhfkCW2UEYUM7D+R7JnfMubetsfd/iYHsogogV3pz30uroxSM73/hqjr7wceb\n\te3ShG7CdAEhBe6/FDxVSgraNekmXgqmm1jJx5mGU4f0q9eqe7SxdmX9WdsHv4j5WyAFUmsRPc0z\n\tsYgAAvpv+B5IXL8+Q4LFvE4O6s/DEe+3uCToxpHxJQA69n5Fol5O5wRR30CcNjviQGy5bum81pC\n\tb2sfDnkaXoKbJ0mBGUT0POWjpVIAzHop6bAjr4elHXA+BhUN8sBaK2JCHCTVZjg2QCnFAnXbf1E\n\tXdzpaiuOK1/+LulXmGJ9Ov+LIaxJSyYojuv78Omd9Ky7jkmgt24UyUAYsU76C/aT3wyVuQKZykr\n\t1FCdv5lim/nQoAQ==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nThere's no need to inline the ValueNode::Accessor::get() function for\nLscPolynomial. Move it to from lsc_polynomial.h to lsc_polynomial.cpp.\n\nWhile at it, replace C++-style comments with C-style comments according\nto the libcamera coding style.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nReviewed-by: Jacopo Mondi \nSigned-off-by: Jacopo Mondi \n---\n src/ipa/libipa/lsc_polynomial.cpp | 26 ++++++++++++++++++++++++--\n src/ipa/libipa/lsc_polynomial.h | 24 ------------------------\n 2 files changed, 24 insertions(+), 26 deletions(-)","diff":"diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex f607d86c54c3..00569c2fd160 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -77,5 +77,27 @@ namespace ipa {\n * \\param size The size of the reference image\n */\n \n-} // namespace ipa\n-} // namespace libcamera\n+} /* namespace ipa */\n+\n+#ifndef __DOXYGEN__\n+template<>\n+std::optional\n+ValueNode::Accessor::get(const ValueNode &obj) const\n+{\n+\tstd::optional cx = obj[\"cx\"].get();\n+\tstd::optional cy = obj[\"cy\"].get();\n+\tstd::optional k0 = obj[\"k0\"].get();\n+\tstd::optional k1 = obj[\"k1\"].get();\n+\tstd::optional k2 = obj[\"k2\"].get();\n+\tstd::optional k3 = obj[\"k3\"].get();\n+\tstd::optional k4 = obj[\"k4\"].get();\n+\n+\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4))\n+\t\tLOG(LscPolynomial, Error)\n+\t\t\t<< \"Polynomial is missing a parameter\";\n+\n+\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n+}\n+#endif /* __DOXYGEN__ */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex d7d9ae42e360..d52ec86946b1 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -80,28 +80,4 @@ private:\n \n } /* namespace ipa */\n \n-#ifndef __DOXYGEN__\n-\n-template<>\n-struct ValueNode::Accessor {\n-\tstd::optional get(const ValueNode &obj) const\n-\t{\n-\t\tstd::optional cx = obj[\"cx\"].get();\n-\t\tstd::optional cy = obj[\"cy\"].get();\n-\t\tstd::optional k0 = obj[\"k0\"].get();\n-\t\tstd::optional k1 = obj[\"k1\"].get();\n-\t\tstd::optional k2 = obj[\"k2\"].get();\n-\t\tstd::optional k3 = obj[\"k3\"].get();\n-\t\tstd::optional k4 = obj[\"k4\"].get();\n-\n-\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4))\n-\t\t\tLOG(LscPolynomial, Error)\n-\t\t\t\t<< \"Polynomial is missing a parameter\";\n-\n-\t\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n-\t}\n-};\n-\n-#endif\n-\n } /* namespace libcamera */\n","prefixes":["v4","11/35"]}