{"id":27232,"url":"https://patchwork.libcamera.org/api/1.1/patches/27232/?format=json","web_url":"https://patchwork.libcamera.org/patch/27232/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260706-libipa-algorithms-v3-32-968757b038bb@ideasonboard.com>","date":"2026-07-06T08:01:52","name":"[v3,32/35] ipa: libipa: lsc: Rename sampleForCrop to resampleLscData","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2952b44e8d53ab90299e00bdea725fc83121ed2f","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27232/mbox/","series":[{"id":6038,"url":"https://patchwork.libcamera.org/api/1.1/series/6038/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6038","date":"2026-07-06T08:01:20","name":"ipa: libipa: Introduce libipa algorithms","version":3,"mbox":"https://patchwork.libcamera.org/series/6038/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27232/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27232/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EFF66C331D\n\tfor ;\n\tMon, 6 Jul 2026 08:02:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E58B66054;\n\tMon, 6 Jul 2026 10:02:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A7476603B\n\tfor ;\n\tMon, 6 Jul 2026 10:02:19 +0200 (CEST)","from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it\n\t[109.113.60.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C03F23DCB;\n\tMon, 6 Jul 2026 10:01:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SODxA9nN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783324891;\n\tbh=dOfbZ8LZPhwdvMfBunOfkCUHa7YYqHotTtInI7cV5ow=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=SODxA9nNwaaTzKDtc8HYP3wAG7/NhF04E/b69dfnC3i2lMWlsUNywSjA90IFz9dXw\n\t5hA+2zLE4GaFBYkHyvTYtHJ+RzzTT8DLd9r0pUPGyPJInhBnjF2ahJ9TG7pbMhY59y\n\tKPv7hi11JnQ+7lyPy1KI76hwOCxMTusOhGe/j4hA=","From":"Jacopo Mondi ","Date":"Mon, 06 Jul 2026 10:01:52 +0200","Subject":"[PATCH v3 32/35] ipa: libipa: lsc: Rename sampleForCrop to\n\tresampleLscData","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260706-libipa-algorithms-v3-32-968757b038bb@ideasonboard.com>","References":"<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>","In-Reply-To":"<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug ","Cc":"Jacopo Mondi ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4426;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=dOfbZ8LZPhwdvMfBunOfkCUHa7YYqHotTtInI7cV5ow=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2DzUHPQ6dAjqDRKSsPiDXv7skAw4xtLQ4nEV\n\tW+G2RMM0qqJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8wAKCRByNAaPFqFW\n\tPA8vD/9db0jp7gg1FhMHp2r7sW6WtDPR6SpUTRk/HXOZUnBBjDxx6h92PJ2ut3cxcXCn/4iMOHF\n\tPm18OjWclhYwFdc4QzAQ3i454BDggWn444Ij60WgiJH1ggtfbPbCNE1X2sJ8hKoneRdMVjQWpVq\n\tgC2j6O0IxJnsTLNbeEj4Pd2AFYO/E7wQnVAiLMxQLyIkoSniLXXbcOYiQDu/Dir4wZM0fUQtC4u\n\tXfy/FJwB9llrGk2TXrPfU8jF2HDKCGyqWfqBZghm3ACcLfyDpMLjht5YY8Wskuuff4VuImkwpQg\n\tUe1gmx28z+7HyQ4TSNo85Fkt2+syDhAglEQoaAB05xhoTmtzWk+k9A8PDbHEzz4BL6sS2rD30BK\n\t5RDWtfcbF3vBVWbCpjsvNqg2fwXGqVQd9G431+AwQmuUBTW8TzTrXqMlPaofJ2xIBFi8iEPoYso\n\t2FfMKP9lpYQcDBZjLJXkfPYMyXI5HxRFv6WkJcoiqSIcMl/4636KsPpbMA0u2PdRCGZ5dWzB87W\n\tUWmjcTSLzsVdenIpqGEZO1FoaM9JLq8wRYGTRDgym95U51HinT9XMTau9NIofO/OoKvgIub7IwP\n\trrzgZxVkNMBP0s5Vsi9jk+nuJZD4IhTnEYc1MwUSbVoqN2GVePA6vjmkqAXMZ4KnXNERoa2RT8N\n\t/cP4a8MhB/+ziQg==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename the function to a more precise name.\n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/libipa/lsc.cpp | 2 +-\n src/ipa/libipa/lsc.h | 2 +-\n src/ipa/libipa/lsc_base.cpp | 2 +-\n src/ipa/libipa/lsc_base.h | 4 ++--\n src/ipa/libipa/lsc_polynomial.cpp | 2 +-\n src/ipa/libipa/lsc_polynomial.h | 4 ++--\n src/ipa/libipa/lsc_table.h | 6 +++---\n 7 files changed, 11 insertions(+), 11 deletions(-)","diff":"diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex 621c04d354a8..d1dc2524fcaa 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -269,7 +269,7 @@ void LscAlgorithmBase::process(lsc::FrameContext &context, ControlList &metadata\n * analogCrop on a grid specified by \\a xPos and \\a yPos. Re-sampling of\n * lsc data is currently supported by polynomial-based lsc tables.\n *\n- * \\sa LscImplementation::sampleForCrop\n+ * \\sa LscImplementation::resampleLscData\n *\n * \\return 0 on success, a negative error code otherwise\n */\ndiff --git a/src/ipa/libipa/lsc.h b/src/ipa/libipa/lsc.h\nindex 6dc76b6572b3..1f46555f9bf0 100644\n--- a/src/ipa/libipa/lsc.h\n+++ b/src/ipa/libipa/lsc.h\n@@ -98,7 +98,7 @@ public:\n \t{\n \t\tLOG(Lsc, Debug) << \"Sample Lsc data for \" << analogCrop;\n \t\tlsc::ComponentsMap lscData =\n-\t\t\timpl_->sampleForCrop(analogCrop, xPos, yPos);\n+\t\t\timpl_->resampleLscData(analogCrop, xPos, yPos);\n \n \t\t/*\n \t\t * Retain a copy of the components table.\ndiff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex ff5d47e85c01..f47c9619669e 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -127,7 +127,7 @@ void Interpolator>::\n */\n \n /**\n- * \\fn LscImplementation::sampleForCrop\n+ * \\fn LscImplementation::resampleLscData\n * \\brief Re-sample the lsc components for \\a cropRectangle\n * \\param[in] cropRectangle The sensor analogue crop rectangle\n * \\param[in] xPos List of horizontal positions of the lsc grid nodes\ndiff --git a/src/ipa/libipa/lsc_base.h b/src/ipa/libipa/lsc_base.h\nindex 4edcb2637d1b..a25d951e8ddb 100644\n--- a/src/ipa/libipa/lsc_base.h\n+++ b/src/ipa/libipa/lsc_base.h\n@@ -74,8 +74,8 @@ public:\n \t\t\t\t const LscDescriptor &descriptor) = 0;\n \n \tvirtual lsc::ComponentsMap\n-\tsampleForCrop(const Rectangle &cropRectangle,\n-\t\t std::vector xPos, std::vector yPos);\n+\tresampleLscData(const Rectangle &cropRectangle,\n+\t\t\tstd::vector xPos, std::vector yPos) = 0;\n };\n \n } /* namespace ipa */\ndiff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex 2b743ed53be7..7b3c13cb144f 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -190,7 +190,7 @@ int LscPolynomialBase::parseLscData(const ValueNode &sets,\n */\n \n /**\n- * \\fn LscPolynomial::sampleForCrop()\n+ * \\fn LscPolynomial::resampleLscData()\n * \\brief Re-sample the lsc components for \\a cropRectangle\n * \\param[in] cropRectangle The sensor analogue crop rectangle\n * \\param[in] xPos List of horizontal positions of the lsc grid nodes\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex a84a736734e1..00bbd068d537 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -78,8 +78,8 @@ public:\n \t}\n \n \tlsc::ComponentsMap\n-\tsampleForCrop(const Rectangle &cropRectangle,\n-\t\t std::vector xPos, std::vector yPos) override\n+\tresampleLscData(const Rectangle &cropRectangle,\n+\t\t\tstd::vector xPos, std::vector yPos) override\n \t{\n \t\tlsc::ComponentsMap components;\n \ndiff --git a/src/ipa/libipa/lsc_table.h b/src/ipa/libipa/lsc_table.h\nindex fe4e133060a6..c3d6c6b95dcd 100644\n--- a/src/ipa/libipa/lsc_table.h\n+++ b/src/ipa/libipa/lsc_table.h\n@@ -50,9 +50,9 @@ public:\n \t}\n \n \tlsc::ComponentsMap\n-\tsampleForCrop([[maybe_unused]] const Rectangle &cropRectangle,\n-\t\t [[maybe_unused]] std::vector xPos,\n-\t\t [[maybe_unused]] std::vector yPos) override\n+\tresampleLscData([[maybe_unused]] const Rectangle &cropRectangle,\n+\t\t\t[[maybe_unused]] std::vector xPos,\n+\t\t\t[[maybe_unused]] std::vector yPos) override\n \t{\n \t\tLOG(LscTable, Warning)\n \t\t\t<< \"Tabular LSC data doesn't support resampling\";\n","prefixes":["v3","32/35"]}