{"id":2719,"url":"https://patchwork.libcamera.org/api/1.1/patches/2719/?format=json","web_url":"https://patchwork.libcamera.org/patch/2719/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200122205723.8865-4-laurent.pinchart@ideasonboard.com>","date":"2020-01-22T20:57:13","name":"[libcamera-devel,v2,03/13] libcamera: camera_manager: Return a copy of the vector from cameras()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a069914053ece290ed16017b67f05f4351df96f1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2719/mbox/","series":[{"id":645,"url":"https://patchwork.libcamera.org/api/1.1/series/645/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=645","date":"2020-01-22T20:57:10","name":"Initial libcamera threading model","version":2,"mbox":"https://patchwork.libcamera.org/series/645/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2719/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2719/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD37C60871\n\tfor ;\n\tWed, 22 Jan 2020 21:57:43 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77BC72F9\n\tfor ;\n\tWed, 22 Jan 2020 21:57:43 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579726663;\n\tbh=yyjEI7pQLc+6xITewJUfAh0GuwQzH3yxmc44qDBtIc8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=vGVXP2VkSYmyUKGfVLOeU1+hhFh9jS7u8S381/CSQs72HYca8wDFdYhFAr5BbipEY\n\t3x4+KYtUEoI3MafGjLY9r2NXobTtmpOF7mj+w84n1WPYP1TMyGpKyfZiJ26chKdjMj\n\tUr/pKZx68QOLj6z5zBvGl6ChvS6pofrcMX0QdSZM=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 22 Jan 2020 22:57:13 +0200","Message-Id":"<20200122205723.8865-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200122205723.8865-1-laurent.pinchart@ideasonboard.com>","References":"<20200122205723.8865-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 03/13] libcamera: camera_manager:\n\tReturn a copy of the vector from cameras()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 22 Jan 2020 20:57:44 -0000"},"content":"Making CameraManager::cameras() thread-safe requires returning a copy of\nthe cameras vector instead of a reference. This is also required for\nhot-plugging support and is thus desirable.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/camera_manager.h | 2 +-\n src/libcamera/camera_manager.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\nindex 068afd58762f..079f848aec79 100644\n--- a/include/libcamera/camera_manager.h\n+++ b/include/libcamera/camera_manager.h\n@@ -30,7 +30,7 @@ public:\n \tint start();\n \tvoid stop();\n \n-\tconst std::vector> &cameras() const;\n+\tstd::vector> cameras() const;\n \tstd::shared_ptr get(const std::string &name);\n \tstd::shared_ptr get(dev_t devnum);\n \ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex e0a07ec557d3..5fc1bba974c6 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -244,7 +244,7 @@ void CameraManager::stop()\n *\n * \\return List of all available cameras\n */\n-const std::vector> &CameraManager::cameras() const\n+std::vector> CameraManager::cameras() const\n {\n \treturn p_->cameras_;\n }\n","prefixes":["libcamera-devel","v2","03/13"]}