{"id":27182,"url":"https://patchwork.libcamera.org/api/1.1/patches/27182/?format=json","web_url":"https://patchwork.libcamera.org/patch/27182/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260703153819.1088752-4-barnabas.pocze@ideasonboard.com>","date":"2026-07-03T15:38:05","name":"[RFC,v1,03/17] ipa: simple: agc: Do not overwrite sensor exposure/gain","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4d9904ec8ec97f8712ef1b96e37647956eeab704","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27182/mbox/","series":[{"id":6036,"url":"https://patchwork.libcamera.org/api/1.1/series/6036/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6036","date":"2026-07-03T15:38:02","name":"ipa: libipa: agc rework","version":1,"mbox":"https://patchwork.libcamera.org/series/6036/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27182/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27182/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80342C3261\n\tfor ;\n\tFri, 3 Jul 2026 15:38:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12F4965FD9;\n\tFri, 3 Jul 2026 17:38:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8707C65FC5\n\tfor ;\n\tFri, 3 Jul 2026 17:38:23 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DEBDDF3\n\tfor ;\n\tFri, 3 Jul 2026 17:37:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Th1xeRBn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783093057;\n\tbh=hlJaDkt7R0c5ZFDJHx4xibLsuI0JVwjjxUfp3cDs3y0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Th1xeRBnuq1sYDMfnjxppYzxtXgbW8Eh38l3MD7mfSqqe8gUc9EMugkhvRZQ8VLG8\n\tNwvVbKZBgfhjvni1Z8wTORXYFfRWixLjx6sTO+4SKT7lcQYskqCxegViT0qx2m8xFl\n\tRlzcNefqONT6SeF4FF0Gf7zig0YL1aMqhWcn/Ci4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 03/17] ipa: simple: agc: Do not overwrite sensor\n\texposure/gain","Date":"Fri, 3 Jul 2026 17:38:05 +0200","Message-ID":"<20260703153819.1088752-4-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>","References":"<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In the agc algorithm do not overwrite the sensor exposure/gain values,\ninstead add a new \"agc\" member to the frame context and update that.\n\nNo functional changes are intended as the agc algorithm runs last.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/simple/algorithms/agc.cpp | 11 +++++++----\n src/ipa/simple/ipa_context.h | 5 +++++\n src/ipa/simple/soft_simple.cpp | 9 +++++----\n 3 files changed, 17 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex a13a755280..e9bcb2c032 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -67,8 +67,8 @@ Agc::Agc()\n \n void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, double exposureMSV)\n {\n-\tint32_t &exposure = frameContext.sensor.exposure;\n-\tdouble &again = frameContext.sensor.gain;\n+\tint32_t exposure = frameContext.sensor.exposure;\n+\tdouble again = frameContext.sensor.gain;\n \n \tdouble error = kExposureOptimal - exposureMSV;\n \n@@ -115,6 +115,9 @@ void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, dou\n \tagain = std::clamp(again, context.configuration.agc.againMin,\n \t\t\t context.configuration.agc.againMax);\n \n+\tframeContext.agc.exposure = exposure;\n+\tframeContext.agc.gain = again;\n+\n \tcontext.activeState.agc.exposure = exposure;\n \tcontext.activeState.agc.again = again;\n \n@@ -150,8 +153,8 @@ void Agc::process(IPAContext &context,\n \t\t * Use the new exposure and gain values calculated the last time\n \t\t * there were valid stats.\n \t\t */\n-\t\tframeContext.sensor.exposure = context.activeState.agc.exposure;\n-\t\tframeContext.sensor.gain = context.activeState.agc.again;\n+\t\tframeContext.agc.exposure = context.activeState.agc.exposure;\n+\t\tframeContext.agc.gain = context.activeState.agc.again;\n \t\treturn;\n \t}\n \ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 8ccfacb46a..d35fb1e91d 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -66,6 +66,11 @@ struct IPAActiveState {\n struct IPAFrameContext : public FrameContext {\n \tMatrix ccm;\n \n+\tstruct {\n+\t\tint32_t exposure;\n+\t\tdouble gain;\n+\t} agc;\n+\n \tstruct {\n \t\tint32_t exposure;\n \t\tdouble gain;\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 2a41b5bac8..22702638bb 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -320,10 +320,11 @@ void IPASoftSimple::processStats(const uint32_t frame,\n \n \tControlList ctrls(sensorInfoMap_);\n \n-\tauto &againNew = frameContext.sensor.gain;\n-\tctrls.set(V4L2_CID_EXPOSURE, frameContext.sensor.exposure);\n-\tctrls.set(V4L2_CID_ANALOGUE_GAIN,\n-\t\t static_cast(camHelper_ ? camHelper_->gainCode(againNew) : againNew));\n+\tint32_t againNew = camHelper_\n+\t\t? camHelper_->gainCode(frameContext.agc.gain)\n+\t\t: static_cast(frameContext.agc.gain);\n+\tctrls.set(V4L2_CID_EXPOSURE, frameContext.agc.exposure);\n+\tctrls.set(V4L2_CID_ANALOGUE_GAIN, againNew);\n \n \tsetSensorControls.emit(ctrls);\n }\n","prefixes":["RFC","v1","03/17"]}