{"id":27112,"url":"https://patchwork.libcamera.org/api/1.1/patches/27112/?format=json","web_url":"https://patchwork.libcamera.org/patch/27112/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-35-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:57","name":"[RFC,v1,34/54] libcamera: pipeline_handler: completeRequest(): Return request count","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c5c7592c22a6bf4bf02b0fcd1dd97130284e331a","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27112/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/1.1/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27112/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27112/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03C7BC3303\n\tfor ;\n\tMon, 29 Jun 2026 16:31:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 86A9365F7C;\n\tMon, 29 Jun 2026 18:31:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89B8065F42\n\tfor ;\n\tMon, 29 Jun 2026 18:30:28 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 622998D4\n\tfor ;\n\tMon, 29 Jun 2026 18:29:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZJ0WJZLu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750585;\n\tbh=+vK2SpvNzAluJ1zJKqGtjiQTF+2eigRZ0Q+xrML6KJE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ZJ0WJZLuGazRqfwuKFNVURvqwCqAOCpFWo68DLBqiC3NtuNQRS8SFD2z+kmWwrlOA\n\tY2DAnvWZ+v4oG2iCYmM+YxziGbTf9LDAKHrrQkSoE1Up7Kv+VYanpNmdqgiosDvBfI\n\tzUA/XA7HogghxX69TcJ+RroQKNhTrkqnz+1i7/Us=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 34/54] libcamera: pipeline_handler: completeRequest():\n\tReturn request count","Date":"Mon, 29 Jun 2026 18:29:57 +0200","Message-ID":"<20260629163017.863145-35-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Return the number of requests that were consumed from the head of\nthe `queuedRequests_` queue. This can be used by pipeline handlers\nusing the `queuedRequests_` queue for their bookeeing.\n\nReviewed-by: Barnabás Pőcze \n---\n include/libcamera/internal/pipeline_handler.h | 2 +-\n src/libcamera/pipeline_handler.cpp | 9 ++++++++-\n 2 files changed, 9 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex d5b8fdb730..5aced40cea 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -70,7 +70,7 @@ public:\n \t\treturn request->_d()->completeBuffer(buffer);\n \t}\n \n-\tvoid completeRequest(Request *request);\n+\tsize_t completeRequest(Request *request);\n \tvoid cancelRequest(Request *request);\n \n \tvoid addBuffer(Camera *camera,\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex ad1174d043..755c78b308 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -636,14 +636,18 @@ void PipelineHandler::doQueueRequests(Camera *camera)\n * without any ordering constraint.\n *\n * \\context This function shall be called from the CameraManager thread.\n+ *\n+ * \\return The number of requests that were removed from the head of the queued\n+ * requests queue.\n */\n-void PipelineHandler::completeRequest(Request *request)\n+size_t PipelineHandler::completeRequest(Request *request)\n {\n \tCamera *camera = request->_d()->camera();\n \n \trequest->_d()->complete();\n \n \tCamera::Private *data = camera->_d();\n+\tsize_t consumed = 0;\n \n \twhile (!data->queuedRequests_.empty()) {\n \t\tRequest *req = data->queuedRequests_.front();\n@@ -653,10 +657,13 @@ void PipelineHandler::completeRequest(Request *request)\n \t\tASSERT(!req->hasPendingBuffers());\n \t\tdata->queuedRequests_.pop_front();\n \t\tcamera->requestComplete(req);\n+\t\tconsumed += 1;\n \t}\n \n \t/* Allow any waiting requests to be queued to the pipeline. */\n \tdoQueueRequests(camera);\n+\n+\treturn consumed;\n }\n \n /**\n","prefixes":["RFC","v1","34/54"]}