{"id":27109,"url":"https://patchwork.libcamera.org/api/1.1/patches/27109/?format=json","web_url":"https://patchwork.libcamera.org/patch/27109/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-32-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:54","name":"[RFC,v1,31/54] libcamera: camera: rejectBuffer(): Add","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fd04d5f769772cc0927de9f7378b59de29ca1164","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27109/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/1.1/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27109/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27109/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A04AEC3261\n\tfor ;\n\tMon, 29 Jun 2026 16:31:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FF2C65FB4;\n\tMon, 29 Jun 2026 18:31:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2A6565F55\n\tfor ;\n\tMon, 29 Jun 2026 18:30:27 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDB9EE91\n\tfor ;\n\tMon, 29 Jun 2026 18:29:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xbl3pHIz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750584;\n\tbh=IJi/icnrKqaZDiI5CZq7vFXpwDQxSQPkURvjTG1Vu1g=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Xbl3pHIzShpeGuo6cJe7FH79Zvnp+MB1kZVYhDKN01uYWbmyesEJgnNUSV5TYmqog\n\trdO0VoFSrhfD8rhhrgYkBQOe4g3J/tFRwB8mopTBoRpdObMGkpx/25jlhMy3axwgUJ\n\tstvmPcxKxyDVWcUZ10raNmD3Mpf9g2dlJg0vf78M=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 31/54] libcamera: camera: rejectBuffer(): Add","Date":"Mon, 29 Jun 2026 18:29:54 +0200","Message-ID":"<20260629163017.863145-32-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a function that can be used to signal that a queued buffer is not\nacceptable and no data has been stored into it.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/camera.h | 6 ++++++\n src/libcamera/camera.cpp | 32 +++++++++++++++++++++++++++++\n 2 files changed, 38 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 31914075f0..13b72258ff 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -59,6 +59,12 @@ public:\n \tusing PooledFrameBuffer = std::unique_ptr;\n \n \t[[nodiscard]] PooledFrameBuffer acquireBuffer(const Stream *stream);\n+\tvoid rejectBuffer(FrameBuffer *buffer);\n+\n+\tvoid rejectBuffer(PooledFrameBuffer buffer)\n+\t{\n+\t\treturn rejectBuffer(buffer.release());\n+\t}\n \n private:\n \tenum State {\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 016f36e796..be55ed72c4 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -790,6 +790,38 @@ Camera::Private::acquireBuffer(const Stream *stream)\n \tit->second.buffers.pop_back();\n \treturn { buffer, { &it->second.buffers } };\n }\n+\n+/**\n+ * \\brief Return a buffer to the application\n+ * \\param[in] buffer The buffer\n+ *\n+ * \\note \\a buffer must not be in the camera's buffer pool\n+ * \\todo return fence on timeout?\n+ */\n+void Camera::Private::rejectBuffer(FrameBuffer *buffer)\n+{\n+\tASSERT(!buffer->_d()->request());\n+\tASSERT(buffer->_d()->stream_);\n+\n+\tLOG(Camera, Debug)\n+\t\t<< \"Camera:\" << LIBCAMERA_O_PTR() << \" rejects buffer:\"\n+\t\t<< buffer << \" for stream:\" << buffer->_d()->stream_;\n+\n+\t/*\n+\t * \\todo Not `FrameError` because that requires `timestamp` and\n+\t * `sequence` to be valid.\n+\t */\n+\tbuffer->_d()->cancel();\n+\tbuffer->_d()->stream_ = nullptr;\n+\n+\t// \\todo separate event (with stream) ?\n+\tLIBCAMERA_O_PTR()->bufferCompleted.emit(nullptr, buffer);\n+}\n+\n+/**\n+ * \\fn Camera::Private::rejectBuffer(PooledFrameBuffer buffer)\n+ * \\copydoc Camera::Private::rejectBuffer(FrameBuffer *buffer)\n+ */\n #endif /* __DOXYGEN_PUBLIC__ */\n \n /**\n","prefixes":["RFC","v1","31/54"]}