{"id":27104,"url":"https://patchwork.libcamera.org/api/1.1/patches/27104/?format=json","web_url":"https://patchwork.libcamera.org/patch/27104/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-27-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:49","name":"[RFC,v1,26/54] libcamera: request: doCancelRequest(): Remove","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ace1dd00188aa11cb58407085c72f644b517868a","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27104/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/1.1/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27104/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27104/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 901E0C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:31:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DA2365F60;\n\tMon, 29 Jun 2026 18:31:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7A8865F4E\n\tfor ;\n\tMon, 29 Jun 2026 18:30:26 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AE5108D4\n\tfor ;\n\tMon, 29 Jun 2026 18:29:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zbtap92l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750583;\n\tbh=gon94y9wMnnMOQcCwsKOys90ovyKUVLz6WnjDA3ne5E=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Zbtap92lhhi4iONe5aNu1F0nmBbhjSGYk4oUlGSXzPXorfX8OXRbNnWgUO+YPWdVc\n\tyc6rNhMp4fysXonFv/4OGktGtWbT6PCYzqGdTS/lX5u3enwyr0uUoTS/TjET00t7eD\n\tkItgo8dRiEra/QiDtaad3SxZet4GYHkHb/KYqAqI=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 26/54] libcamera: request: doCancelRequest(): Remove","Date":"Mon, 29 Jun 2026 18:29:49 +0200","Message-ID":"<20260629163017.863145-27-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that request cancellation does not emit the `bufferCompleted`\nevent for pending buffers (because there are no longer such things),\nthe function need not be called from the destructor and it can be\ninlined into its only caller.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/request.h | 2 --\n src/libcamera/request.cpp | 10 ++--------\n 2 files changed, 2 insertions(+), 10 deletions(-)","diff":"diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex 09768c6fcd..922d14f14c 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -40,8 +40,6 @@ private:\n \tfriend class PipelineHandler;\n \tfriend std::ostream &operator<<(std::ostream &out, const Request &r);\n \n-\tvoid doCancelRequest();\n-\n \tCamera *camera_;\n \tbool cancelled_;\n \tuint32_t sequence_ = 0;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 9544a8993d..4df8b0f1ad 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -62,7 +62,6 @@ Request::Private::Private(Camera *camera)\n \n Request::Private::~Private()\n {\n-\tdoCancelRequest();\n }\n \n /**\n@@ -141,12 +140,6 @@ void Request::Private::complete()\n \tLIBCAMERA_TRACEPOINT(request_complete, this);\n }\n \n-void Request::Private::doCancelRequest()\n-{\n-\tcancelled_ = true;\n-\tpending_ = 0;\n-}\n-\n /**\n * \\brief Cancel a queued request\n *\n@@ -162,7 +155,8 @@ void Request::Private::cancel()\n \tRequest *request = _o();\n \tASSERT(request->status() == RequestPending);\n \n-\tdoCancelRequest();\n+\tcancelled_ = true;\n+\tpending_ = 0;\n }\n \n /**\n","prefixes":["RFC","v1","26/54"]}