{"id":27094,"url":"https://patchwork.libcamera.org/api/1.1/patches/27094/?format=json","web_url":"https://patchwork.libcamera.org/patch/27094/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-16-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:38","name":"[RFC,v1,15/54] v4l2: v4l2_camera: Clear completed requests when stopping","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8de3cc9385a30994dacee93182db2d2c94bff6de","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27094/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/1.1/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27094/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27094/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC389C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:31:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A964165F35;\n\tMon, 29 Jun 2026 18:30:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DB6965F3D\n\tfor ;\n\tMon, 29 Jun 2026 18:30:24 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AB5E1044\n\tfor ;\n\tMon, 29 Jun 2026 18:29:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mV3ZwC15\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750581;\n\tbh=Y/1MYfy85QlfUMD+IhTKG4vHPwL0j8jsvwzEosEwqpM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=mV3ZwC15Hh9ULDb+1kYLA2PCvyrZf/6L/bC2VFdHQs1RsaiWQ+wc6llbEjzg54yh7\n\tIcO8yLvzCPR1FtNDQTsqvgHxifqe+FJJs62auR1C2wzKnCjVIECAqb/R11D+pTB9AD\n\t5zXmFx9RhchMgGNVPkqas1gSDomig3aY5UwEbXqs=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 15/54] v4l2: v4l2_camera: Clear completed requests\n\twhen stopping","Date":"Mon, 29 Jun 2026 18:29:38 +0200","Message-ID":"<20260629163017.863145-16-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The queue `completedBuffers_` keeps track of the completed buffers\nfor servicing `VIDIOC_DQBUF` calls. It should be cleared when the\nstreaming is stopped otherwise after the next startup stale data\nmight be used.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/v4l2/v4l2_camera.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 8c7de8e92b..99109e93af 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -242,6 +242,7 @@ int V4L2Camera::streamOff()\n \t{\n \t\tMutexLocker locker(bufferMutex_);\n \t\tisRunning_ = false;\n+\t\tcompletedBuffers_.clear();\n \t}\n \tbufferCV_.notify_all();\n \n","prefixes":["RFC","v1","15/54"]}