{"id":27088,"url":"https://patchwork.libcamera.org/api/1.1/patches/27088/?format=json","web_url":"https://patchwork.libcamera.org/patch/27088/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-10-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:32","name":"[RFC,v1,09/54] v4l2: v4l2_camera: Remove repated index checks","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"99eeb06fbf99a400b8e63fef5814c105b02af3e2","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27088/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/1.1/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27088/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27088/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21736C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:30:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BBEC65F3D;\n\tMon, 29 Jun 2026 18:30:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE35465F04\n\tfor ;\n\tMon, 29 Jun 2026 18:30:22 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AFAC68D4\n\tfor ;\n\tMon, 29 Jun 2026 18:29:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OKK1vQ77\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750579;\n\tbh=K6Mvvbe+ry8dhA9unPPH9k/Yv6jmPD7iXc8rogky2lU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=OKK1vQ779RneQBfw02WMk+FTyiTDgfl53mGPC7a6g/Vbp7uhb2xbWMG6GxHD36qvX\n\tk5EKBAB6R0ihpJbCKy4dLq/+XuByJ3PGVmsDhr2K2Kd11q++hlnPREUUwkbDGt1BeU\n\thEah+OSvW5urjAg1ZFqTK09hFVf8KBPOVsPMSOe4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 09/54] v4l2: v4l2_camera: Remove repated index checks","Date":"Mon, 29 Jun 2026 18:29:32 +0200","Message-ID":"<20260629163017.863145-10-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Check only once if the buffer index is valid.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/v4l2/v4l2_camera_proxy.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 03cd4810cc..b4f06c1c51 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -582,8 +582,7 @@ int V4L2CameraProxy::vidioc_querybuf(V4L2CameraFile *file, struct v4l2_buffer *a\n \tif (arg->index >= bufferCount_)\n \t\treturn -EINVAL;\n \n-\tif (!validateBufferType(arg->type) ||\n-\t arg->index >= bufferCount_)\n+\tif (!validateBufferType(arg->type))\n \t\treturn -EINVAL;\n \n \tupdateBuffers();\n@@ -641,8 +640,7 @@ int V4L2CameraProxy::vidioc_qbuf(V4L2CameraFile *file, struct v4l2_buffer *arg)\n \t\treturn -EBUSY;\n \n \tif (!validateBufferType(arg->type) ||\n-\t !validateMemoryType(arg->memory) ||\n-\t arg->index >= bufferCount_)\n+\t !validateMemoryType(arg->memory))\n \t\treturn -EINVAL;\n \n \tint ret = vcam_->qbuf(arg->index);\n","prefixes":["RFC","v1","09/54"]}