{"id":27087,"url":"https://patchwork.libcamera.org/api/1.1/patches/27087/?format=json","web_url":"https://patchwork.libcamera.org/patch/27087/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-9-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:31","name":"[RFC,v1,08/54] v4l2: v4l2_camera: Avoid a level of indirection","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"16493f3ead65a538828cc5904195bfce5d2e8cdc","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27087/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/1.1/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27087/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27087/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51B08C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:30:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C7FD65F39;\n\tMon, 29 Jun 2026 18:30:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C8EB65F2E\n\tfor ;\n\tMon, 29 Jun 2026 18:30:22 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 655381044;\n\tMon, 29 Jun 2026 18:29:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TFtEW4wi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750579;\n\tbh=rqqzN5Jhikx2SOBPz/annoESvH/M7mkdiSpqXo8Z40Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TFtEW4wirhpCl4h6ENsOOEEU5+93oYX5Ys7TaORqrRiiygYRF6e9Frq5jeWXVt/0S\n\toGcO3ziSU87obPuF4lTvMpDNjWX23Ufr2lLmJQ/kvgfVqYyVJavfUctvLj12wCO96S\n\tKr7psxTH+RBEjtIHLfG7D6kDbF4d8HZ1botcyJzI=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tLaurent Pinchart ,\n\tPaul Elder ","Subject":"[RFC PATCH v1 08/54] v4l2: v4l2_camera: Avoid a level of indirection","Date":"Mon, 29 Jun 2026 18:29:31 +0200","Message-ID":"<20260629163017.863145-9-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Convert the `completedBuffers_` container to store the items directly\nand not via an `std::unique_ptr`.\n\nSigned-off-by: Barnabás Pőcze \nAcked-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \nReviewed-by: Paul Elder \n---\n src/v4l2/v4l2_camera.cpp | 11 ++++-------\n src/v4l2/v4l2_camera.h | 2 +-\n 2 files changed, 5 insertions(+), 8 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 412ab4ea67..648578c22b 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -70,11 +70,10 @@ void V4L2Camera::unbind()\n \n std::vector V4L2Camera::completedBuffers()\n {\n-\tstd::vector v;\n-\n \tMutexLocker lock(bufferLock_);\n-\tfor (std::unique_ptr &metadata : completedBuffers_)\n-\t\tv.push_back(*metadata.get());\n+\tstd::vector v(std::move_iterator(completedBuffers_.begin()),\n+\t\t std::move_iterator(completedBuffers_.end()));\n+\n \tcompletedBuffers_.clear();\n \n \treturn v;\n@@ -88,9 +87,7 @@ void V4L2Camera::requestComplete(Request *request)\n \t/* We only have one stream at the moment. */\n \tbufferLock_.lock();\n \tFrameBuffer *buffer = request->buffers().begin()->second;\n-\tstd::unique_ptr metadata =\n-\t\tstd::make_unique(request->cookie(), buffer->metadata());\n-\tcompletedBuffers_.push_back(std::move(metadata));\n+\tcompletedBuffers_.emplace_back(request->cookie(), buffer->metadata());\n \tbufferLock_.unlock();\n \n \tuint64_t data = 1;\ndiff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex 3d09ae7d60..1528f9aad8 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -85,7 +85,7 @@ private:\n \tstd::vector> requestPool_;\n \n \tstd::deque pendingRequests_;\n-\tstd::deque> completedBuffers_\n+\tstd::deque completedBuffers_\n \t\tLIBCAMERA_TSA_GUARDED_BY(bufferLock_);\n \n \tint efd_;\n","prefixes":["RFC","v1","08/54"]}