{"id":27083,"url":"https://patchwork.libcamera.org/api/1.1/patches/27083/?format=json","web_url":"https://patchwork.libcamera.org/patch/27083/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-5-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:27","name":"[RFC,v1,04/54] libcamera: pipeline: mali-c55: Remove `setRequest()` calls","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4b3d71ced31571cb201b6119fe97d7496eba79f3","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27083/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/1.1/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27083/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27083/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6E8FC3261\n\tfor ;\n\tMon, 29 Jun 2026 16:30:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5767F65F61;\n\tMon, 29 Jun 2026 18:30:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DB5065F04\n\tfor ;\n\tMon, 29 Jun 2026 18:30:21 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EF03E91\n\tfor ;\n\tMon, 29 Jun 2026 18:29:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TAfeecM+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750578;\n\tbh=PuZgyyAqywl0ytorJi6f1SdmjAFzOagjt5FkHhiy9aw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=TAfeecM+zOBxBP6l9c+4A96nJJPhzBzVst6uvsnAcvsKlg4N4bn32VbYnZXWHVpGi\n\tz2l9Wz6sD561EvhbxHndAjYQQXq+lCrnDbQrjUTLdC++AgebqvSnwSwiQXgwVQ5y5j\n\tjVgu0qe+IX33I8z20v5cmT5dQLFkb7Sqi3MExVLQ=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 04/54] libcamera: pipeline: mali-c55: Remove\n\t`setRequest()` calls","Date":"Mon, 29 Jun 2026 18:29:27 +0200","Message-ID":"<20260629163017.863145-5-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The buffer completion handler (`PipelineHandlerMaliC55::cruBufferReady()`)\ndoes not query the request of the buffer, so setting it is unnecessary.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp | 3 +--\n src/libcamera/pipeline/mali-c55/rzg2l-cru.h | 3 +--\n 3 files changed, 3 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 599ff88b59..b30455683e 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -1541,7 +1541,7 @@ void PipelineHandlerMaliC55::queueRequestToCru(MaliC55CameraData *data,\n \tauto *mem = std::get_if(&data->input_);\n \tASSERT(mem);\n \n-\tFrameBuffer *cruBuffer = mem->cru_->queueBuffer(request);\n+\tFrameBuffer *cruBuffer = mem->cru_->queueBuffer();\n \tASSERT(cruBuffer);\n \n \tauto frameInfo = prepareFrameInfo(request);\ndiff --git a/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp b/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp\nindex 9cb7cc3f10..3de4527561 100644\n--- a/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp\n+++ b/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp\n@@ -35,7 +35,7 @@ static const std::map bitDepthToFmt{\n \n LOG_DEFINE_CATEGORY(RZG2LCRU)\n \n-FrameBuffer *RZG2LCRU::queueBuffer(Request *request)\n+FrameBuffer *RZG2LCRU::queueBuffer()\n {\n \tFrameBuffer *buffer;\n \n@@ -53,7 +53,6 @@ FrameBuffer *RZG2LCRU::queueBuffer(Request *request)\n \t}\n \n \tavailableBuffers_.pop_back();\n-\tbuffer->_d()->setRequest(request);\n \n \treturn buffer;\n }\ndiff --git a/src/libcamera/pipeline/mali-c55/rzg2l-cru.h b/src/libcamera/pipeline/mali-c55/rzg2l-cru.h\nindex 8bd4c027ad..7ef5e2b5ee 100644\n--- a/src/libcamera/pipeline/mali-c55/rzg2l-cru.h\n+++ b/src/libcamera/pipeline/mali-c55/rzg2l-cru.h\n@@ -20,7 +20,6 @@ namespace libcamera {\n class CameraSensor;\n class FrameBuffer;\n class MediaDevice;\n-class Request;\n class Size;\n \n class RZG2LCRU\n@@ -45,7 +44,7 @@ public:\n \tV4L2VideoDevice *output() { return output_.get(); }\n \n \tint configure(V4L2SubdeviceFormat *subdevFormat, V4L2DeviceFormat *inputFormat);\n-\tFrameBuffer *queueBuffer(Request *request);\n+\tFrameBuffer *queueBuffer();\n \tvoid returnBuffer(FrameBuffer *buffer);\n \tint freeBuffers();\n \n","prefixes":["RFC","v1","04/54"]}