{"id":27081,"url":"https://patchwork.libcamera.org/api/1.1/patches/27081/?format=json","web_url":"https://patchwork.libcamera.org/patch/27081/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-3-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:25","name":"[RFC,v1,02/54] libcamera: request: Disassociate buffer when cancelling","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fe12341f83a9534db7d0aec4b8d7e26276da23e8","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27081/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/1.1/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27081/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27081/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAC59C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:30:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 26C8865F31;\n\tMon, 29 Jun 2026 18:30:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29DF065F21\n\tfor ;\n\tMon, 29 Jun 2026 18:30:21 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D50101044;\n\tMon, 29 Jun 2026 18:29:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O/n1U1Ic\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750578;\n\tbh=so6WTDiZP0Yg9iTDyJ0AArtYlJl8k5aH4ItHX611/0k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=O/n1U1IcXyAfw4fow2+HIE1GHBgiVKKErqtMxBv1jgwRkfN+vdaVqmn27ysyVdHQX\n\tT4WNg71b3n+VMhmRj0p4Hi8T6zddgKniAreTMKFljY+OM4AX1kQYIzXDv77gd8LyKY\n\tEy67K4ZuLXCN6Hig1EdR3yDnXoorwZ0k9XYGYNNY=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tLaurent Pinchart ","Subject":"[RFC PATCH v1 02/54] libcamera: request: Disassociate buffer when\n\tcancelling","Date":"Mon, 29 Jun 2026 18:29:25 +0200","Message-ID":"<20260629163017.863145-3-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Match the behaviour of `completeBuffer()` by unsetting the \"parent\" `Request`\npointer of the `FrameBuffer`.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/request.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 163d8cf920..5f983e0ce6 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -143,6 +143,7 @@ void Request::Private::doCancelRequest()\n \tfor (FrameBuffer *buffer : pending_) {\n \t\tbuffer->_d()->cancel();\n \t\tcamera_->bufferCompleted.emit(request, buffer);\n+\t\tbuffer->_d()->setRequest(nullptr);\n \t}\n \n \tcancelled_ = true;\n","prefixes":["RFC","v1","02/54"]}