{"id":26988,"url":"https://patchwork.libcamera.org/api/1.1/patches/26988/?format=json","web_url":"https://patchwork.libcamera.org/patch/26988/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618123844.656396-26-barnabas.pocze@ideasonboard.com>","date":"2026-06-18T12:38:42","name":"[RFC,v1,25/27] v4l2: v4l2_camera: Rename `Buffer` to `CompletedBuffer`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0d7116cc76c6153c83b7cafd4879ceec8857a018","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26988/mbox/","series":[{"id":6006,"url":"https://patchwork.libcamera.org/api/1.1/series/6006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6006","date":"2026-06-18T12:38:17","name":"Misc. changes before request-buffer split","version":1,"mbox":"https://patchwork.libcamera.org/series/6006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26988/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26988/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF951C332A\n\tfor ;\n\tThu, 18 Jun 2026 12:39:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22F326571E;\n\tThu, 18 Jun 2026 14:39:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A25E656F6\n\tfor ;\n\tThu, 18 Jun 2026 14:38:53 +0200 (CEST)","from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 98E0A2F8\n\tfor ;\n\tThu, 18 Jun 2026 14:38:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kfpEUblP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786298;\n\tbh=pIXJf1n38uFdSboSrG9npAOlghWJrOkjcNt4p8VZOUM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=kfpEUblPrmhQfG8kozcCrHTF9nB387ozWTvQ2BVxrnzyDPOTNx/gPGWAhSaQl8Rxo\n\tcNIl71TBicOqyjlimVJtiWNaWv1S4cySdbnRBe4cYBgRCKu6ExQETSbKgIFBG6pFlY\n\tuDu/GbwhK6Ty408HoLY/qF+q8/4V1GmlhZATBnPo=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 25/27] v4l2: v4l2_camera: Rename `Buffer` to\n\t`CompletedBuffer`","Date":"Thu, 18 Jun 2026 14:38:42 +0200","Message-ID":"<20260618123844.656396-26-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","References":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This expresses the meaning better.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/v4l2/v4l2_camera.cpp | 2 +-\n src/v4l2/v4l2_camera.h | 8 ++++----\n src/v4l2/v4l2_camera_proxy.cpp | 4 ++--\n 3 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 7dd0ea1ef9..e72b73a22a 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -68,7 +68,7 @@ void V4L2Camera::unbind()\n \tefd_ = -1;\n }\n \n-std::vector V4L2Camera::completedBuffers()\n+std::vector V4L2Camera::completedBuffers()\n {\n \tMutexLocker lock(bufferLock_);\n \tstd::vector v(std::move_iterator(completedBuffers_.begin()),\ndiff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex 8a58169d89..1d90eb43e4 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -23,8 +23,8 @@\n class V4L2Camera\n {\n public:\n-\tstruct Buffer {\n-\t\tBuffer(unsigned int index, const libcamera::FrameMetadata &data)\n+\tstruct CompletedBuffer {\n+\t\tCompletedBuffer(unsigned int index, const libcamera::FrameMetadata &data)\n \t\t\t: index_(index), data_(data)\n \t\t{\n \t\t}\n@@ -41,7 +41,7 @@ public:\n \tvoid bind(int efd);\n \tvoid unbind();\n \n-\tstd::vector completedBuffers() LIBCAMERA_TSA_EXCLUDES(bufferLock_);\n+\tstd::vector completedBuffers() LIBCAMERA_TSA_EXCLUDES(bufferLock_);\n \n \tint configure(libcamera::StreamConfiguration *streamConfigOut,\n \t\t const libcamera::Size &size,\n@@ -85,7 +85,7 @@ private:\n \tstd::vector> requestPool_;\n \n \tstd::deque pendingRequests_;\n-\tstd::deque completedBuffers_\n+\tstd::deque completedBuffers_\n \t\tLIBCAMERA_TSA_GUARDED_BY(bufferLock_);\n \n \tint efd_;\ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 5281f10552..820a417a9c 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -243,8 +243,8 @@ void V4L2CameraProxy::querycap(std::shared_ptr camera)\n \n void V4L2CameraProxy::updateBuffers()\n {\n-\tstd::vector completedBuffers = vcam_->completedBuffers();\n-\tfor (const V4L2Camera::Buffer &buffer : completedBuffers) {\n+\tstd::vector completedBuffers = vcam_->completedBuffers();\n+\tfor (const V4L2Camera::CompletedBuffer &buffer : completedBuffers) {\n \t\tconst FrameMetadata &fmd = buffer.data_;\n \t\tstruct v4l2_buffer &buf = buffers_[buffer.index_];\n \n","prefixes":["RFC","v1","25/27"]}