{"id":26986,"url":"https://patchwork.libcamera.org/api/1.1/patches/26986/?format=json","web_url":"https://patchwork.libcamera.org/patch/26986/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618123844.656396-22-barnabas.pocze@ideasonboard.com>","date":"2026-06-18T12:38:38","name":"[RFC,v1,21/27] gstreamer: Use `FrameBuffer` cookie to associate with `GstBuffer`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e72b8b0d0e7769452f2822950ed811d5656015e4","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26986/mbox/","series":[{"id":6006,"url":"https://patchwork.libcamera.org/api/1.1/series/6006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6006","date":"2026-06-18T12:38:17","name":"Misc. changes before request-buffer split","version":1,"mbox":"https://patchwork.libcamera.org/series/6006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26986/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26986/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99DC7C3323\n\tfor ;\n\tThu, 18 Jun 2026 12:39:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C97765718;\n\tThu, 18 Jun 2026 14:39:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D82E656C1\n\tfor ;\n\tThu, 18 Jun 2026 14:38:52 +0200 (CEST)","from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BAECB2F8\n\tfor ;\n\tThu, 18 Jun 2026 14:38:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JHH/wm8h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786297;\n\tbh=DUQ/KdTHe3MZyPeFGHix4N1v0F/tbiou66p+M6o+MDM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=JHH/wm8hsEBmY1RxA5hcpOpXFh75UGMoamxiFqQgmX2SyUEtyTMbdY5VcqxkUloLK\n\t4GhcUdNvIiamRYkvMHmiZrY6kuoAthmW3hcgxKape3m72Dle2a8pxeiTyEf0jtVCZm\n\txn/GisakvCPXxXhQL0MT9sSCfv/YMUpw33TbB1Ik=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 21/27] gstreamer: Use `FrameBuffer` cookie to\n\tassociate with `GstBuffer`","Date":"Thu, 18 Jun 2026 14:38:38 +0200","Message-ID":"<20260618123844.656396-22-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","References":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the `FrameBuffer`'s arbitrary \"cookie\" data to reference the\nassociated `GstBuffer` while the `FrameBuffer` is attached to a\nparticular request. Otherwise keep the cookie 0.\n\nThis is allowed since the `FrameBuffer`s are allocated with the\n`FrameBufferAllocator`. This also removes the need for the explicit\nmapping of Stream -> GstBuffer in `RequestWrap`.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/gstreamer/gstlibcamerasrc.cpp | 37 ++++++++++++++++---------------\n 1 file changed, 19 insertions(+), 18 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 5d3ee3a213..9061f9163c 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -52,7 +52,6 @@ struct RequestWrap {\n \tGstBuffer *detachBuffer(GstPad *srcpad);\n \n \tstd::unique_ptr request_;\n-\tstd::map buffers_;\n \n \tGstClockTime latency_;\n \tGstClockTime pts_;\n@@ -65,9 +64,15 @@ RequestWrap::RequestWrap(std::unique_ptr request)\n \n RequestWrap::~RequestWrap()\n {\n-\tfor (std::pair &item : buffers_) {\n-\t\tif (item.second)\n-\t\t\tgst_buffer_unref(item.second);\n+\tif (!request_)\n+\t\treturn;\n+\n+\tfor (const auto &[stream, fb] : request_->buffers()) {\n+\t\tauto *buffer = reinterpret_cast(fb->cookie());\n+\t\tif (buffer)\n+\t\t\tgst_buffer_unref(buffer);\n+\n+\t\tfb->setCookie(0);\n \t}\n }\n \n@@ -77,25 +82,21 @@ void RequestWrap::attachBuffer(GstPad *srcpad, GstBuffer *buffer)\n \tStream *stream = gst_libcamera_pad_get_stream(srcpad);\n \n \trequest_->addBuffer(stream, fb);\n-\n-\tauto item = buffers_.find(srcpad);\n-\tif (item != buffers_.end()) {\n-\t\tgst_buffer_unref(item->second);\n-\t\titem->second = buffer;\n-\t} else {\n-\t\tbuffers_[srcpad] = buffer;\n-\t}\n+\tfb->setCookie(reinterpret_cast(buffer));\n }\n \n GstBuffer *RequestWrap::detachBuffer(GstPad *srcpad)\n {\n-\tGstBuffer *buffer = nullptr;\n+\tconst Stream *stream = gst_libcamera_pad_get_stream(srcpad);\n+\tFrameBuffer *fb = request_->findBuffer(stream);\n+\tif (!fb)\n+\t\treturn nullptr;\n \n-\tauto item = buffers_.find(srcpad);\n-\tif (item != buffers_.end()) {\n-\t\tbuffer = item->second;\n-\t\titem->second = nullptr;\n-\t}\n+\tauto *buffer = reinterpret_cast(fb->cookie());\n+\n+\tfb->setCookie(0);\n+\n+\tg_assert(!buffer || fb == gst_libcamera_buffer_get_frame_buffer(buffer));\n \n \treturn buffer;\n }\n","prefixes":["RFC","v1","21/27"]}