{"id":26985,"url":"https://patchwork.libcamera.org/api/1.1/patches/26985/?format=json","web_url":"https://patchwork.libcamera.org/patch/26985/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618123844.656396-21-barnabas.pocze@ideasonboard.com>","date":"2026-06-18T12:38:37","name":"[RFC,v1,20/27] gstreamer: allocator: get_pool_size(): Fix return value","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9b356d8316263481a66ae2b15ade84dde1e2f9d1","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26985/mbox/","series":[{"id":6006,"url":"https://patchwork.libcamera.org/api/1.1/series/6006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6006","date":"2026-06-18T12:38:17","name":"Misc. changes before request-buffer split","version":1,"mbox":"https://patchwork.libcamera.org/series/6006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26985/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26985/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FD08C331D\n\tfor ;\n\tThu, 18 Jun 2026 12:39:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2874165729;\n\tThu, 18 Jun 2026 14:39:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F5DF62B29\n\tfor ;\n\tThu, 18 Jun 2026 14:38:52 +0200 (CEST)","from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 85188DF3\n\tfor ;\n\tThu, 18 Jun 2026 14:38:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hdm/j9eM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786297;\n\tbh=k2p7+a1HsYWsur0N/4I5XSOEbYNefgqL9qhidFP2ltM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Hdm/j9eM/sbZqAHRBPyKVM+0zsK6Z8NUIPtZnmKXbU/oGGzYbx0x3tDtm4/GVvz8q\n\tReWcdn9i+pClVHu3ezq0edWbYcOpR1N3NGnmHTJmhT1ofS1z0tgnPg3l6bkzgyEBFC\n\t3/QJioyALSTnEkFvCTuLFKLitrcuO6ksjdDVSgAA=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 20/27] gstreamer: allocator: get_pool_size(): Fix\n\treturn value","Date":"Thu, 18 Jun 2026 14:38:37 +0200","Message-ID":"<20260618123844.656396-21-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","References":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Return `0` instead of `false` in the error case.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\nindex d4492d994b..d9d771d545 100644\n--- a/src/gstreamer/gstlibcameraallocator.cpp\n+++ b/src/gstreamer/gstlibcameraallocator.cpp\n@@ -260,7 +260,7 @@ gst_libcamera_allocator_get_pool_size(GstLibcameraAllocator *self,\n \tGLibLocker lock(GST_OBJECT(self));\n \n \tauto *pool = reinterpret_cast(g_hash_table_lookup(self->pools, stream));\n-\tg_return_val_if_fail(pool, false);\n+\tg_return_val_if_fail(pool, 0);\n \n \treturn pool->length;\n }\n","prefixes":["RFC","v1","20/27"]}