{"id":26982,"url":"https://patchwork.libcamera.org/api/1.1/patches/26982/?format=json","web_url":"https://patchwork.libcamera.org/patch/26982/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618123844.656396-18-barnabas.pocze@ideasonboard.com>","date":"2026-06-18T12:38:34","name":"[RFC,v1,17/27] libcamera: pipeline_handler: Use `std::deque`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f6d160432d8264e0bb987ae827e45df6f1acadc2","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26982/mbox/","series":[{"id":6006,"url":"https://patchwork.libcamera.org/api/1.1/series/6006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6006","date":"2026-06-18T12:38:17","name":"Misc. changes before request-buffer split","version":1,"mbox":"https://patchwork.libcamera.org/series/6006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26982/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26982/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BBCBC3316\n\tfor ;\n\tThu, 18 Jun 2026 12:39:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B54965702;\n\tThu, 18 Jun 2026 14:39:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6CBC62C6F\n\tfor ;\n\tThu, 18 Jun 2026 14:38:51 +0200 (CEST)","from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5BAF2F8\n\tfor ;\n\tThu, 18 Jun 2026 14:38:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AvJvnfSl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786297;\n\tbh=EcfYKHGpz3/abJQGTuFyGSU5AQ37uNVNq64FIVh25TU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=AvJvnfSl/7UrpaGsaU+coLMMfLH04T/HUm+rvjb8AS+I/JidDkYDg0qKoJiq+/2Fq\n\tLAtUTjzizLmjU3hRB1YDSV0gjiT6GiCh1aLKYmcEF6hdnY+YAzevZ9hRPPrA0GIYlt\n\t37x+TNOO3FDl4fusehcpPdM7GQCKnYuXYYx9BdXM=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 17/27] libcamera: pipeline_handler: Use `std::deque`","Date":"Thu, 18 Jun 2026 14:38:34 +0200","Message-ID":"<20260618123844.656396-18-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","References":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`std::queue` already uses `std::deque` as its implementation, so there is\nno difference there. And getting a specific index of `std::list` is a linear\noperation, so replace it with an `std::deque`, to enable pipeline handlers\nto look into the list more easily.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/camera.h | 7 +++----\n src/libcamera/pipeline_handler.cpp | 8 ++++----\n 2 files changed, 7 insertions(+), 8 deletions(-)","diff":"diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 8a2e9ed589..be3e5ff97e 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -8,9 +8,8 @@\n #pragma once\n \n #include \n-#include \n+#include \n #include \n-#include \n #include \n #include \n #include \n@@ -36,8 +35,8 @@ public:\n \tPipelineHandler *pipe() { return pipe_.get(); }\n \tconst PipelineHandler *pipe() const { return pipe_.get(); }\n \n-\tstd::list queuedRequests_;\n-\tstd::queue waitingRequests_;\n+\tstd::deque queuedRequests_;\n+\tstd::deque waitingRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n \ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 99f35d1e42..5376fee299 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -372,7 +372,7 @@ void PipelineHandler::stop(Camera *camera)\n \t * after the device to keep them in order.\n \t */\n \tCamera::Private *data = camera->_d();\n-\tstd::queue waitingRequests;\n+\tstd::deque waitingRequests;\n \twaitingRequests.swap(data->waitingRequests_);\n \n \t/* Stop the pipeline handler and let the queued requests complete. */\n@@ -381,7 +381,7 @@ void PipelineHandler::stop(Camera *camera)\n \t/* Cancel and signal as complete all waiting requests. */\n \twhile (!waitingRequests.empty()) {\n \t\tRequest *request = waitingRequests.front();\n-\t\twaitingRequests.pop();\n+\t\twaitingRequests.pop_front();\n \n \t\t/*\n \t\t * Cancel all requests by marking them as cancelled and calling\n@@ -472,7 +472,7 @@ void PipelineHandler::queueRequest(Request *request)\n \n \tCamera *camera = request->_d()->camera();\n \tCamera::Private *data = camera->_d();\n-\tdata->waitingRequests_.push(request);\n+\tdata->waitingRequests_.push_back(request);\n \n \trequest->_d()->prepare(300ms);\n }\n@@ -521,7 +521,7 @@ void PipelineHandler::doQueueRequests(Camera *camera)\n \t\t * Pop the request first, in case doQueueRequests() is called\n \t\t * recursively from within doQueueRequest()\n \t\t */\n-\t\tdata->waitingRequests_.pop();\n+\t\tdata->waitingRequests_.pop_front();\n \t\tdoQueueRequest(request);\n \t}\n }\n","prefixes":["RFC","v1","17/27"]}