{"id":26971,"url":"https://patchwork.libcamera.org/api/1.1/patches/26971/?format=json","web_url":"https://patchwork.libcamera.org/patch/26971/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618123844.656396-8-barnabas.pocze@ideasonboard.com>","date":"2026-06-18T12:38:24","name":"[RFC,v1,07/27] libcamera: pipeline: imx8-isi: Use `completeBuffer()` return value","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e8740696984508a2d66b76f61a0b2c00113f9275","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26971/mbox/","series":[{"id":6006,"url":"https://patchwork.libcamera.org/api/1.1/series/6006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6006","date":"2026-06-18T12:38:17","name":"Misc. changes before request-buffer split","version":1,"mbox":"https://patchwork.libcamera.org/series/6006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26971/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26971/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76B5FC3303\n\tfor ;\n\tThu, 18 Jun 2026 12:39:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0F8E62C7B;\n\tThu, 18 Jun 2026 14:39:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D402F62B3F\n\tfor ;\n\tThu, 18 Jun 2026 14:38:49 +0200 (CEST)","from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED0AA2F8\n\tfor ;\n\tThu, 18 Jun 2026 14:38:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Wn3ZkPsV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786295;\n\tbh=x8gcCAIS/4cUnDTG2+3N95O71DzE410X4cOw9WYp6SQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Wn3ZkPsVJWCxMD3uviXY5ugl7u7sBx4l6SD4v6ykFWvMz9jLLxZSdIYNxHUCoHi58\n\tuSmMMvXgsyztjg1yvtv+W/4OQjnSt0aOd+/xE9p8w2yLW1I1IPmK96vFwMRZQ5CprT\n\tf/QN9Bmj/1VV5iIeuAwmPbGN7DExPrT88szIgnMI=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 07/27] libcamera: pipeline: imx8-isi: Use\n\t`completeBuffer()` return value","Date":"Thu, 18 Jun 2026 14:38:24 +0200","Message-ID":"<20260618123844.656396-8-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","References":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no need to check `hasPendingBuffers()` since `completeBuffer()`\nreturn `true` if there are no buffers left to complete in the request.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex 706681fce5..c3d2695556 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -1131,11 +1131,8 @@ void PipelineHandlerISI::bufferReady(FrameBuffer *buffer)\n \t\tmetadata.set(controls::SensorTimestamp,\n \t\t\t buffer->metadata().timestamp);\n \n-\tcompleteBuffer(request, buffer);\n-\tif (request->hasPendingBuffers())\n-\t\treturn;\n-\n-\tcompleteRequest(request);\n+\tif (completeBuffer(request, buffer))\n+\t\tcompleteRequest(request);\n }\n \n /* Original function taken from simple.cpp */\n","prefixes":["RFC","v1","07/27"]}