{"id":26969,"url":"https://patchwork.libcamera.org/api/1.1/patches/26969/?format=json","web_url":"https://patchwork.libcamera.org/patch/26969/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618123844.656396-6-barnabas.pocze@ideasonboard.com>","date":"2026-06-18T12:38:22","name":"[RFC,v1,05/27] libcamera: software_isp: Replace open-coded buffer cancellation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8b81d3dcd49c66589fdd5e893c0486dc87578274","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26969/mbox/","series":[{"id":6006,"url":"https://patchwork.libcamera.org/api/1.1/series/6006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6006","date":"2026-06-18T12:38:17","name":"Misc. changes before request-buffer split","version":1,"mbox":"https://patchwork.libcamera.org/series/6006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26969/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26969/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 731AEC3302\n\tfor ;\n\tThu, 18 Jun 2026 12:39:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 622A3656FB;\n\tThu, 18 Jun 2026 14:38:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71EE262B32\n\tfor ;\n\tThu, 18 Jun 2026 14:38:49 +0200 (CEST)","from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8E1CF2F8\n\tfor ;\n\tThu, 18 Jun 2026 14:38:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UKkEGHma\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786294;\n\tbh=7pk2akcIO+LKapSx5LH2m1u6MaKxxgke+i79MVQIb/I=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=UKkEGHmauLG8/BH+N451VSynDZMgTDNSS9rvIH/XcMoniugJF+J5iYadwTWJeqI38\n\tgm2Oib7H7ouZilgCA3cgPxvruVKAQXrllg5W8EYV5+qJKd2Ihe95vG+CFzctrtxpaU\n\tfGeDf7UaBdo8ulfTcntC1UgYhEn6BgaDzNSPdl1I=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 05/27] libcamera: software_isp: Replace open-coded\n\tbuffer cancellation","Date":"Thu, 18 Jun 2026 14:38:22 +0200","Message-ID":"<20260618123844.656396-6-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","References":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of manually setting `FrameMetadata::status`, simply call the\nappropriate `cancel()` method.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/software_isp/software_isp.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 1b316c54c6..c73a16ce0a 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -406,15 +406,13 @@ void SoftwareIsp::stop()\n \tipa_->stop();\n \n \tfor (auto buffer : queuedOutputBuffers_) {\n-\t\tFrameMetadata &metadata = buffer->_d()->metadata();\n-\t\tmetadata.status = FrameMetadata::FrameCancelled;\n+\t\tbuffer->_d()->cancel();\n \t\toutputBufferReady.emit(buffer);\n \t}\n \tqueuedOutputBuffers_.clear();\n \n \tfor (auto buffer : queuedInputBuffers_) {\n-\t\tFrameMetadata &metadata = buffer->_d()->metadata();\n-\t\tmetadata.status = FrameMetadata::FrameCancelled;\n+\t\tbuffer->_d()->cancel();\n \t\tinputBufferReady.emit(buffer);\n \t}\n \tqueuedInputBuffers_.clear();\n","prefixes":["RFC","v1","05/27"]}