{"id":26966,"url":"https://patchwork.libcamera.org/api/1.1/patches/26966/?format=json","web_url":"https://patchwork.libcamera.org/patch/26966/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618123844.656396-3-barnabas.pocze@ideasonboard.com>","date":"2026-06-18T12:38:19","name":"[RFC,v1,02/27] libcamera: request: Inline `Private::hasPendingRequests()`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9c3a415f54d540a19ee7ef45ef305d5646c8001c","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26966/mbox/","series":[{"id":6006,"url":"https://patchwork.libcamera.org/api/1.1/series/6006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6006","date":"2026-06-18T12:38:17","name":"Misc. changes before request-buffer split","version":1,"mbox":"https://patchwork.libcamera.org/series/6006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26966/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26966/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CF25BF415\n\tfor ;\n\tThu, 18 Jun 2026 12:39:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B2DA656E4;\n\tThu, 18 Jun 2026 14:38:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE265629E0\n\tfor ;\n\tThu, 18 Jun 2026 14:38:48 +0200 (CEST)","from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7F841894\n\tfor ;\n\tThu, 18 Jun 2026 14:38:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NvczzRdC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786294;\n\tbh=G9E3MiS16ADVtBPpBAXgn6HC2Ogh1myfLFKuYuDtyxE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=NvczzRdCp4EZZyE6jAvcTythzZSV7wbcJ+FeNCtYSCH6jdx7zX7+DwUb9cZyze/uO\n\tPxKzSsH7mvl55ViCtj+Cl2DZIwLaKMSoFJi9LXqe8MsUxGqtX5trrpfMkzI8Xmlxox\n\tfug5CIqsAPaCMXaN1pXuiWpkagLHvHG5C1qmS2+4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 02/27] libcamera: request: Inline\n\t`Private::hasPendingRequests()`","Date":"Thu, 18 Jun 2026 14:38:19 +0200","Message-ID":"<20260618123844.656396-3-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","References":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It is a trivial function, inline it.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/request.h | 2 +-\n src/libcamera/request.cpp | 5 +----\n 2 files changed, 2 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex 693097ee9a..382ed28bca 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -34,7 +34,7 @@ public:\n \t~Private();\n \n \tCamera *camera() const { return camera_; }\n-\tbool hasPendingBuffers() const;\n+\tbool hasPendingBuffers() const { return !pending_.empty(); }\n \n \tControlList &metadata() { return metadata_; }\n \ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex b50a642052..e31c9c006a 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -74,15 +74,12 @@ Request::Private::~Private()\n */\n \n /**\n+ * \\fn Request::Private::hasPendingBuffers()\n * \\brief Check if a request has buffers yet to be completed\n *\n * \\return True if the request has buffers pending for completion, false\n * otherwise\n */\n-bool Request::Private::hasPendingBuffers() const\n-{\n-\treturn !pending_.empty();\n-}\n \n /**\n * \\fn Request::Private::metadata()\n","prefixes":["RFC","v1","02/27"]}