{"id":26950,"url":"https://patchwork.libcamera.org/api/1.1/patches/26950/?format=json","web_url":"https://patchwork.libcamera.org/patch/26950/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618122245.946138-18-bryan.odonoghue@linaro.org>","date":"2026-06-18T12:22:30","name":"[17/30] libcamera: software_isp: egl: Rename createTexture2D to createInputTexture2D","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"520f9ce62409239e24f0f1eb9f763db94f0aa4fa","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26950/mbox/","series":[{"id":6005,"url":"https://patchwork.libcamera.org/api/1.1/series/6005/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6005","date":"2026-06-18T12:22:13","name":"RFC/RFT: gpuisp: Multipass with speed optimisations on top","version":1,"mbox":"https://patchwork.libcamera.org/series/6005/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26950/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26950/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF5BFC3310\n\tfor ;\n\tThu, 18 Jun 2026 12:23:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FCF262E9D;\n\tThu, 18 Jun 2026 14:23:29 +0200 (CEST)","from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56D0362C6D\n\tfor ;\n\tThu, 18 Jun 2026 14:23:11 +0200 (CEST)","by mail-wr1-x42e.google.com with SMTP id\n\tffacd0b85a97d-45ef189aa1cso661000f8f.0\n\tfor ;\n\tThu, 18 Jun 2026 05:23:11 -0700 (PDT)","from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:23:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"afzoI4Ez\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785391; x=1782390191;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=CfDeIMUwfSa5hEgn9yj8YVav8Kysxh3e9PDp4yN9qns=;\n\tb=afzoI4EzNHBdsDG24+FQzAKDI+ws0gUawVLkK/Yjz0kMgqg1SrEiGNwuGudUavr2eT\n\twCqjAsB7vDJhvlFh5JYE/HNuKfhhTlMUx0AmX9xMD1i53MLEUY97udDHATejl9EMB/ov\n\tjFwNwW2E/tPO0XKAvlLZL5hzP9chy3/L6l266O3/j4oxJIjKozRi20FnbQmhb5tZSy6a\n\trIQYP9mCvK598+pb8hvy84FBgpNXEhLg/Z+dz12WqMlTR7kPOExym8aMy7v5EB9vvN1l\n\tAIahiGnwV66MvZQHgFw7aB/P5Mzvb8O/IDHY/binGcC24OzcJ291FTJqQBZeRiC01q8y\n\txFhA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785391; x=1782390191;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=CfDeIMUwfSa5hEgn9yj8YVav8Kysxh3e9PDp4yN9qns=;\n\tb=IWOeKVj929Qw3qCohbG29qGFB/sajZpQW1zvPmb8bIZNOGm8/AG1HNftyhZbMRr7k1\n\t5w1dzTIN5G+dI4AjXEo/CiJZWaPzo9gq1uJ540R3u9j8lEZkWp0Rpalb8JdkAH/Ol9fk\n\tVj8h4sHLBycwHuyR8iwqLLs3CvBALQEkKM6vpag5QccAVURzQmGKUNBTP4mWGtoAUQyd\n\tSyvT5cRrVDET9qHag1cWeLLz48xWQz2WyaBccb4E5qhu24pY0uz72T1ZkvCPaxNqs3/4\n\tWO6+VLukR9zcd4y/4isqgwXQv2RBHpTZEMifh3y0ev/sOujlf4AWJQtSG8cX744vF2yh\n\t06Fw==","X-Gm-Message-State":"AOJu0Yy9o9ayTdPJumGuX+CvVQFMj5gsu4VkmmYY23XitXb+Wju/9ICP\n\tUwS3WkkGL2Ix8yMHXwoYnoWAJXNSxzWU6s+Q3GgZKcE2KC+x+PKX+twToeiKjhRvWKKtM+DyitG\n\tzW8uJAL8=","X-Gm-Gg":"AfdE7cnE2GPRDbc1oOWoL2v1lx1SBtNXN+0iUf4tfDEn1KUq9vIjydCHoq+R4dcadL3\n\tSqBEFJgUBvzlX2m7ikqDEVgmbYQR/bCRBAUb/WAEEoFodl0Z9ywe4j1ZQmaf5x1N+N1tldYIJLp\n\tMdnCJ0uO6XKhsXyOpmFM6ha2zlQaK6FydoNh3tMjAI3xFExxjZxcYKvqhwc65jeD0/g5YiZMLeg\n\tdfh+4ze+wLS2ncGVdqd/mXVZQiEsLVz5bScDpwWIJZZOM0CdUKQ8TL10OC72lTaV55mEw3C83s2\n\tMyZhtAKdk6JewgwH3ru43aGi+jSoq3r5KX4EOQqwJRyeLT1GYRJHNoYWKY3FfI3xTw8/2t2iuBZ\n\tVfS0uNvi8nin+97+LI5tWqnIuaddH4ZZcUUsLBQbbGuWvaIcklhRaZAwrUj/6DurXF0kg/nK5Og\n\t9UfRICFnL0jk/HLWSuJpa7SZeRfYJN","X-Received":"by 2002:a05:600c:4ed4:b0:490:da12:f1fa with SMTP id\n\t5b1f17b1804b1-492333ecc2bmr143344365e9.31.1781785390776; \n\tThu, 18 Jun 2026 05:23:10 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz","Subject":"[PATCH 17/30] libcamera: software_isp: egl: Rename createTexture2D\n\tto createInputTexture2D","Date":"Thu, 18 Jun 2026 13:22:30 +0100","Message-ID":"<20260618122245.946138-18-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618122245.946138-1-bryan.odonoghue@linaro.org>","References":"<20260618122245.946138-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Right now this routine makes a texture from a supplied data-buffer. It\nshould have a more descriptive and accurate name.\n\nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/egl.h | 2 +-\n src/libcamera/egl.cpp | 2 +-\n src/libcamera/software_isp/software_isp_pipeline_gpu.cpp | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 3956c6669..182a4dc55 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -106,7 +106,7 @@ public:\n \n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n-\tvoid createTexture2D(eGLImage &eglImage, void *data);\n+\tvoid createInputTexture2D(eGLImage &eglImage, void *data);\n \n \tint attachTextureToFBO(eGLImage &eglImage);\n \ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex a5e59c09c..ffaa6bc49 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -262,7 +262,7 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n * is useful for uploading static data like lookup tables or uniform color\n * matrices to the GPU.\n */\n-void eGL::createTexture2D(eGLImage &eglImage, void *data)\n+void eGL::createInputTexture2D(eGLImage &eglImage, void *data)\n {\n \tGLenum format;\n \tGLenum type = GL_UNSIGNED_BYTE;\ndiff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\nindex 7de77319d..8bafd70f8 100644\n--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n@@ -247,7 +247,7 @@ int SoftwareIspPipelineGpu::processGPU(FrameBuffer *input, FrameBuffer *output,\n \t\t\tLOG(Debayer, Error) << \"mmap-ing buffer(s) failed\";\n \t\t\treturn -ENODEV;\n \t\t}\n-\t\tegl_.createTexture2D(*eglImageBayerIn_, inMapped->value().planes()[0].data());\n+\t\tegl_.createInputTexture2D(*eglImageBayerIn_, inMapped->value().planes()[0].data());\n \t}\n \n \t/* Generate the output render framebuffer as render to texture */\n","prefixes":["17/30"]}