{"id":26862,"url":"https://patchwork.libcamera.org/api/1.1/patches/26862/?format=json","web_url":"https://patchwork.libcamera.org/patch/26862/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260609155043.1121340-1-laurent.pinchart@ideasonboard.com>","date":"2026-06-09T15:50:43","name":"libcamera: matrix: Improve comment related to C++20","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4e7ccced609f759ea18640d25d1d5fa6b6d896ea","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26862/mbox/","series":[{"id":5983,"url":"https://patchwork.libcamera.org/api/1.1/series/5983/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5983","date":"2026-06-09T15:50:43","name":"libcamera: matrix: Improve comment related to C++20","version":1,"mbox":"https://patchwork.libcamera.org/series/5983/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26862/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26862/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36942C324C\n\tfor ;\n\tTue, 9 Jun 2026 15:50:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5845861EF0;\n\tTue, 9 Jun 2026 17:50:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 954DB61E61\n\tfor ;\n\tTue, 9 Jun 2026 17:50:45 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D6A5F244\n\tfor ;\n\tTue, 9 Jun 2026 17:50:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jFND20Cb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781020217;\n\tbh=QV/y2AX7QEIgvRcN2o1t+g+NruyaxjvPuBK+VKtfFXw=;\n\th=From:To:Subject:Date:From;\n\tb=jFND20CbaaT73N2Phou8GlCSdBcis2fH1pkjOxp3OFpNkl1rBNJYhbJFPBJ/hI6H8\n\tLbJylp3hpCNc0XF6XphvihZGa2KJyP1w1/eDpy+LxW56ZTG6aL57/LyPULyUUYX7Fv\n\t9u4gAn543qi2PBAzDLUwpex9nRTGTpNFsWJonVT0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH] libcamera: matrix: Improve comment related to C++20","Date":"Tue, 9 Jun 2026 18:50:43 +0300","Message-ID":"<20260609155043.1121340-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It was envisioned that the Matrix::data_ initializer could be dropped\nonce moving to C++20. Unfortunately older compilers don't agree. Update\nthe comment accordingly.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/matrix.h | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)\n\n\nbase-commit: 5701eb5f47cf3649e2746a2082c7bb3e0a0577e8","diff":"diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\nindex 0f72263f2536..4900dcc0a419 100644\n--- a/include/libcamera/internal/matrix.h\n+++ b/include/libcamera/internal/matrix.h\n@@ -117,9 +117,11 @@ public:\n \n private:\n \t/*\n-\t * \\todo The initializer is only necessary for the constructor to be\n-\t * constexpr in C++17. Remove the initializer as soon as we are on\n-\t * C++20.\n+\t * \\todo The initializer should be only necessary for the constructor to\n+\t * be constexpr in C++17. However, older gcc versions (at least 9 and\n+\t * 12, but apparently not 10), as well as clang versions (at least 14\n+\t * and 19), throw compilation errors, even with C++20. Remove the\n+\t * initializer once we can drop support of those old compiler versions.\n \t */\n \tstd::array data_ = {};\n };\n","prefixes":[]}