{"id":2682,"url":"https://patchwork.libcamera.org/api/1.1/patches/2682/?format=json","web_url":"https://patchwork.libcamera.org/patch/2682/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200118213123.27096-1-nicolas@ndufresne.ca>","date":"2020-01-18T21:31:23","name":"[libcamera-devel] v4l2: Extend device caps with V4L2_CAP_STREAMING","commit_ref":"632e0fc09f4e7f32307c101ef9ee970669e1ccf2","pull_url":null,"state":"accepted","archived":false,"hash":"2640840bc5c38a25f5c166f28f047a3868268ad5","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/1.1/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2682/mbox/","series":[{"id":638,"url":"https://patchwork.libcamera.org/api/1.1/series/638/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=638","date":"2020-01-18T21:31:23","name":"[libcamera-devel] v4l2: Extend device caps with V4L2_CAP_STREAMING","version":1,"mbox":"https://patchwork.libcamera.org/series/638/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2682/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2682/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E72360457\n\tfor ;\n\tSat, 18 Jan 2020 22:34:06 +0100 (CET)","from nicolas-tpx395.localdomain (unknown\n\t[IPv6:2002:c0de:c115:0:66fc:8b:2a38:8313])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 05FFD28A2DB;\n\tSat, 18 Jan 2020 21:34:04 +0000 (GMT)"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","Date":"Sat, 18 Jan 2020 16:31:23 -0500","Message-Id":"<20200118213123.27096-1-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] v4l2: Extend device caps with\n\tV4L2_CAP_STREAMING","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 18 Jan 2020 21:34:06 -0000"},"content":"From: Nicolas Dufresne \n\nThis capability tells the application that mmap() is supported. GStreamer\nwould return an error saying there there is no input/output method supported\nby this device otherwise. This was tested with:\n\nLD_PRELOAD=$(pwd)/build/src/v4l2/v4l2-compat.so GST_DEBUG=\"v4l2*:7\" gst-launch-1.0 v4l2src ! videoconvert ! autovideosink\n\nWith this patch, GStreamer will reach playing state. It then blocks waiting on\npoll() which is not implemented yet on our side.\n\nSigned-off-by: Nicolas Dufresne \n---\n src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 3013a3d..e58fd6a 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -179,7 +179,7 @@ void V4L2CameraProxy::querycap(std::shared_ptr camera)\n \t\t sizeof(capabilities_.bus_info));\n \t/* \\todo Put this in a header/config somewhere. */\n \tcapabilities_.version = KERNEL_VERSION(5, 2, 0);\n-\tcapabilities_.device_caps = V4L2_CAP_VIDEO_CAPTURE;\n+\tcapabilities_.device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;\n \tcapabilities_.capabilities = capabilities_.device_caps\n \t\t\t\t | V4L2_CAP_DEVICE_CAPS;\n \tmemset(capabilities_.reserved, 0, sizeof(capabilities_.reserved));\n","prefixes":["libcamera-devel"]}