{"id":265,"url":"https://patchwork.libcamera.org/api/1.1/patches/265/?format=json","web_url":"https://patchwork.libcamera.org/patch/265/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190117230636.16176-1-niklas.soderlund@ragnatech.se>","date":"2019-01-17T23:06:36","name":"[libcamera-devel] libcamera: device_enumerator: extend documentation of DeviceMatch","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"21a67b11fae4e789226f7c03ec13e851604c9691","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/265/mbox/","series":[{"id":89,"url":"https://patchwork.libcamera.org/api/1.1/series/89/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=89","date":"2019-01-17T23:06:36","name":"[libcamera-devel] libcamera: device_enumerator: extend documentation of DeviceMatch","version":1,"mbox":"https://patchwork.libcamera.org/series/89/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/265/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/265/checks/","tags":{},"headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E7D660B2D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jan 2019 00:06:44 +0100 (CET)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 7f8462cc-1aac-11e9-911a-0050569116f7;\n\tFri, 18 Jan 2019 00:06:23 +0100 (CET)"],"X-Halon-ID":"7f8462cc-1aac-11e9-911a-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Jan 2019 00:06:36 +0100","Message-Id":"<20190117230636.16176-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: device_enumerator: extend\n\tdocumentation of DeviceMatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 17 Jan 2019 23:06:44 -0000"},"content":"Extend the document of the intended usage of DeviceMatch need for\ninformation to correctly function to find a uniquely identifiable media\ndevice.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/device_enumerator.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 55c510e3b79a415b..e0b19313552f6aa5 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -52,6 +52,15 @@ namespace libcamera {\n  *\n  * The description is meant to be filled by pipeline managers and passed to a\n  * device enumerator to find matching media devices.\n+ *\n+ * A DeviceMatch is created with a specific Linux device driver in mind, therefor\n+ * the name of the driver is a required property. One or more Entity names can\n+ * be added the matching with \\a add().\n+ *\n+ * A pipeline handler should add as many entities to a DeviceMatch so that the\n+ * media device can be uniquely identified in case a Linux device driver is\n+ * capable of producing different media graphs as a result of different hardware\n+ * versions or other circumstances.\n  */\n \n /**\n","prefixes":["libcamera-devel"]}