{"id":26489,"url":"https://patchwork.libcamera.org/api/1.1/patches/26489/?format=json","web_url":"https://patchwork.libcamera.org/patch/26489/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407-kbingham-awb-split-v1-6-a39af3f4dc20@ideasonboard.com>","date":"2026-04-07T22:01:09","name":"[06/13] ipa: libipa: provide lux context structures","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"15816129cb18b9282222f60f31374c04a383305e","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26489/mbox/","series":[{"id":5874,"url":"https://patchwork.libcamera.org/api/1.1/series/5874/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5874","date":"2026-04-07T22:01:03","name":"ipa: simple: Convert to libipa AWB implementation","version":1,"mbox":"https://patchwork.libcamera.org/series/5874/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26489/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26489/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75F6DC32F5\n\tfor ;\n\tTue, 7 Apr 2026 22:02:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8DD562DEC;\n\tWed, 8 Apr 2026 00:02:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B24B62DA0\n\tfor ;\n\tWed, 8 Apr 2026 00:02:42 +0200 (CEST)","from [192.168.0.204] (ams.linuxembedded.co.uk [209.38.108.23])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78A296A6;\n\tWed, 8 Apr 2026 00:01:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bgERZKK4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775599274;\n\tbh=PBHUldN1WdxIrokwZoMzPpOP155RcwSuQlPOXE1uJ0A=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=bgERZKK4Nhw9Sy89KtooRcd7pA+3IBHjr1S8TUtIBACCOZkj/SM4Ug1saw/hXUfQp\n\tpd5cvjc7x3m8cSdrOiFhCFmavwyWTssXRhsYDfiMdLcaKGjsiV6MXHnq8vXkvld1cO\n\taHzxIljVtAHBVnOZsW3DVxRUXx+MQ3ho0HLt3egA=","From":"Kieran Bingham ","Date":"Tue, 07 Apr 2026 23:01:09 +0100","Subject":"[PATCH 06/13] ipa: libipa: provide lux context structures","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260407-kbingham-awb-split-v1-6-a39af3f4dc20@ideasonboard.com>","References":"<20260407-kbingham-awb-split-v1-0-a39af3f4dc20@ideasonboard.com>","In-Reply-To":"<20260407-kbingham-awb-split-v1-0-a39af3f4dc20@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1775599360; l=2818;\n\ti=kieran.bingham@ideasonboard.com; s=20260204;\n\th=from:subject:message-id; \n\tbh=PBHUldN1WdxIrokwZoMzPpOP155RcwSuQlPOXE1uJ0A=;\n\tb=b3vzdNwxd8c+kUZvqQSG79kZmYvRoBk3WPgYoPJT7VwsA/KXGINOZd48fKjVjzcqwGiJqGQdX\n\tbkxxcf9bphUCCdiLbkGj1SAmdfRcNef5DZMK/plTYOJTpPUN24tiayr","X-Developer-Key":"i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=IOxS2C6nWHNjLfkDR71Iesk904i6wJDfEERqV7hDBdY=","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move the ActiveState and FrameContext as used by the RKISP1 lux\nto be exposed by the libipa implementation for re-use.\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/libipa/lux.cpp | 16 ++++++++++++++++\n src/ipa/libipa/lux.h | 12 ++++++++++++\n src/ipa/rkisp1/ipa_context.h | 13 +++++--------\n 3 files changed, 33 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/libipa/lux.cpp b/src/ipa/libipa/lux.cpp\nindex 899e88248f04fbe0d6986528c81b468384fe4a9f..012c6fb367142ce40f60f5e102e3addb142c4a6b 100644\n--- a/src/ipa/libipa/lux.cpp\n+++ b/src/ipa/libipa/lux.cpp\n@@ -33,6 +33,22 @@ LOG_DEFINE_CATEGORY(Lux)\n \n namespace ipa {\n \n+/**\n+ * \\struct lux::ActiveState\n+ * \\brief Active lux estimation state shared across frames\n+ *\n+ * \\var lux::ActiveState::lux\n+ * \\brief The most recently estimated lux value\n+ */\n+\n+/**\n+ * \\struct lux::FrameContext\n+ * \\brief Per-frame lux estimation context\n+ *\n+ * \\var lux::FrameContext::lux\n+ * \\brief The lux value estimation used for processing the frame\n+ */\n+\n /**\n * \\class Lux\n * \\brief Class that implements lux estimation\ndiff --git a/src/ipa/libipa/lux.h b/src/ipa/libipa/lux.h\nindex d95bcdafcfcdb44641ddb12306e4705157dc09ae..2aa630a1097e4bc672c792395d2d179dc084c7d8 100644\n--- a/src/ipa/libipa/lux.h\n+++ b/src/ipa/libipa/lux.h\n@@ -16,6 +16,18 @@ class YamlObject;\n \n namespace ipa {\n \n+namespace lux {\n+\n+struct ActiveState {\n+\tdouble lux;\n+};\n+\n+struct FrameContext {\n+\tdouble lux;\n+};\n+\n+} /* namespace lux */\n+\n class Histogram;\n \n class Lux\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex e61391bb1510bb642dafc544ee7775390e6948d6..63a6f2b7d884bfff2553175fa32e45ae747fb4c7 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -28,6 +28,7 @@\n #include \"libipa/camera_sensor_helper.h\"\n #include \"libipa/fc_queue.h\"\n #include \"libipa/fixedpoint.h\"\n+#include \"libipa/lux.h\"\n \n namespace libcamera {\n \n@@ -78,6 +79,8 @@ struct IPASessionConfiguration {\n };\n \n struct IPAActiveState {\n+\tipa::lux::ActiveState lux;\n+\n \tstruct {\n \t\tstruct {\n \t\t\tuint32_t exposure;\n@@ -137,10 +140,6 @@ struct IPAActiveState {\n \t\tdouble gamma;\n \t} goc;\n \n-\tstruct {\n-\t\tdouble lux;\n-\t} lux;\n-\n \tstruct {\n \t\tcontrols::WdrModeEnum mode;\n \t\tAgcMeanLuminance::AgcConstraint constraint;\n@@ -154,6 +153,8 @@ struct IPAActiveState {\n };\n \n struct IPAFrameContext : public FrameContext {\n+\tipa::lux::FrameContext lux;\n+\n \tstruct {\n \t\tuint32_t exposure;\n \t\tdouble gain;\n@@ -219,10 +220,6 @@ struct IPAFrameContext : public FrameContext {\n \t\tMatrix ccm;\n \t} ccm;\n \n-\tstruct {\n-\t\tdouble lux;\n-\t} lux;\n-\n \tstruct {\n \t\tcontrols::WdrModeEnum mode;\n \t\tdouble strength;\n","prefixes":["06/13"]}