{"id":26448,"url":"https://patchwork.libcamera.org/api/1.1/patches/26448/?format=json","web_url":"https://patchwork.libcamera.org/patch/26448/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407153427.1825999-9-laurent.pinchart@ideasonboard.com>","date":"2026-04-07T15:33:53","name":"[v2,08/42] libcamera: yaml_parser: Use std::make_unique<>","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5fdb345427c65c483d8dbc41666e4455b47a83e6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26448/mbox/","series":[{"id":5873,"url":"https://patchwork.libcamera.org/api/1.1/series/5873/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5873","date":"2026-04-07T15:33:45","name":"libcamera: Global configuration file improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/5873/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26448/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26448/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1921EC32F8\n\tfor ;\n\tTue, 7 Apr 2026 15:34:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 648FB62DB8;\n\tTue, 7 Apr 2026 17:34:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C89862DA2\n\tfor ;\n\tTue, 7 Apr 2026 17:34:39 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CE1276A6\n\tfor ;\n\tTue, 7 Apr 2026 17:33:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gTkC+RWq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775575992;\n\tbh=vqb+V5KiW+iQzA+wKfrOttyEJip+8YUkGI2wXdO0r/4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=gTkC+RWqpocrlsg8tcKtf6FFX+HCJSpg38v+R0WYRmTNIvdJjBvVn7XlG60zfl8CC\n\tBLIm3ivQJxbM78nK9S5kSvKjcxxwafXXpOM2KGWgBzGuHphCAzzP057A4NQG2wYekQ\n\t7MpR2oAyd5OJbQwZpiT8gtTBxGiicUBLwASWccC8=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 08/42] libcamera: yaml_parser: Use std::make_unique<>","Date":"Tue, 7 Apr 2026 18:33:53 +0300","Message-ID":"<20260407153427.1825999-9-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>","References":"<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The YamlParser::parse() function constructs a std::unique_ptr<> instance\nwith a manual call to operator new. Replace it with std::make_unique<>.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Barnabás Pőcze \nReviewed-by: Stefan Klug \n---\n src/libcamera/yaml_parser.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex e13b5faedd81..791fb6eeafa8 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -769,7 +769,7 @@ std::unique_ptr YamlParser::parse(File &file)\n \tif (context.init(file))\n \t\treturn nullptr;\n \n-\tstd::unique_ptr root(new YamlObject());\n+\tstd::unique_ptr root = std::make_unique();\n \n \tif (context.parseContent(*root)) {\n \t\tLOG(YamlParser, Error)\n","prefixes":["v2","08/42"]}