{"id":26445,"url":"https://patchwork.libcamera.org/api/1.1/patches/26445/?format=json","web_url":"https://patchwork.libcamera.org/patch/26445/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407153427.1825999-6-laurent.pinchart@ideasonboard.com>","date":"2026-04-07T15:33:50","name":"[v2,05/42] test: ipa: ipa_interface: Use IPAManager::createIPA()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c204d0fd2a8229e093c9554a8df1ea872f304bf2","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26445/mbox/","series":[{"id":5873,"url":"https://patchwork.libcamera.org/api/1.1/series/5873/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5873","date":"2026-04-07T15:33:45","name":"libcamera: Global configuration file improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/5873/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26445/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26445/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2DD1C32F6\n\tfor ;\n\tTue, 7 Apr 2026 15:34:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E18D62DB5;\n\tTue, 7 Apr 2026 17:34:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 562A262D9D\n\tfor ;\n\tTue, 7 Apr 2026 17:34:35 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CC8836A6\n\tfor ;\n\tTue, 7 Apr 2026 17:33:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RTNNa+9A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775575987;\n\tbh=hBpMyS0YxcY9DSFeNBS4rsFhthcjbfeuWaM0OnFgi3I=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=RTNNa+9AwzKIjiZtzIAP08LDosojbGQlVx7W2d+I7PpXfu/OjygofIPTFnwvreo5e\n\tVkXIJx2j1apXpB7tJWtV2oUdz3QekzvpGqWYoMgsOWVmS4QWNdYdpqYch7c4xGLi7c\n\tq06dbV2cj2fWpQTlQZRpDe2ANkDUpApUHgcwIo3A=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 05/42] test: ipa: ipa_interface: Use\n\tIPAManager::createIPA()","Date":"Tue, 7 Apr 2026 18:33:50 +0300","Message-ID":"<20260407153427.1825999-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>","References":"<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The goal of ipa_interface is to unit test the IPA interface. It\ncurrently creates the IPA proxy through the higher level PipelineHandler\nclass. Use the IPAManager::createIPA() function instead to keep the\nfocus on the components that were meant to be tested.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Barnabás Pőcze \n---\n test/ipa/ipa_interface_test.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\nindex ccff6ac106c8..41ef81721bfa 100644\n--- a/test/ipa/ipa_interface_test.cpp\n+++ b/test/ipa/ipa_interface_test.cpp\n@@ -22,6 +22,8 @@\n \n #include \"libcamera/internal/camera_manager.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n+#include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/ipa_module.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n \n@@ -43,6 +45,8 @@ public:\n \t{\n \t\tdelete notifier_;\n \t\tipa_.reset();\n+\t\tipaManager_.reset();\n+\t\tconfig_.reset();\n \t\tcameraManager_.reset();\n \t}\n \n@@ -90,6 +94,10 @@ protected:\n \t\tnotifier_ = new EventNotifier(fd_, EventNotifier::Read, this);\n \t\tnotifier_->activated.connect(this, &IPAInterfaceTest::readTrace);\n \n+\t\t/* Create the IPA manager. */\n+\t\tconfig_ = std::make_unique();\n+\t\tipaManager_ = std::make_unique(*config_);\n+\n \t\treturn TestPass;\n \t}\n \n@@ -98,7 +106,7 @@ protected:\n \t\tEventDispatcher *dispatcher = thread()->eventDispatcher();\n \t\tTimer timer;\n \n-\t\tipa_ = pipe_->createIPA(0, 0);\n+\t\tipa_ = ipaManager_->createIPA(pipe_.get(), 0, 0);\n \t\tif (!ipa_) {\n \t\t\tcerr << \"Failed to create VIMC IPA interface\" << endl;\n \t\t\treturn TestFail;\n@@ -173,6 +181,8 @@ private:\n \tstd::shared_ptr pipe_;\n \tstd::unique_ptr ipa_;\n \tstd::unique_ptr cameraManager_;\n+\tstd::unique_ptr config_;\n+\tstd::unique_ptr ipaManager_;\n \tenum ipa::vimc::IPAOperationCode trace_;\n \tEventNotifier *notifier_;\n \tint fd_;\n","prefixes":["v2","05/42"]}