{"id":2642,"url":"https://patchwork.libcamera.org/api/1.1/patches/2642/?format=json","web_url":"https://patchwork.libcamera.org/patch/2642/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200114012626.25265-1-kieran.bingham@ideasonboard.com>","date":"2020-01-14T01:26:26","name":"[libcamera-devel] libcamera: log: Expand log level names","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1f009b0098c60bf7f364e07798e2857a6ff9a0fa","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2642/mbox/","series":[{"id":621,"url":"https://patchwork.libcamera.org/api/1.1/series/621/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=621","date":"2020-01-14T01:26:26","name":"[libcamera-devel] libcamera: log: Expand log level names","version":1,"mbox":"https://patchwork.libcamera.org/series/621/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2642/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2642/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 398DD6070F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jan 2020 02:26:31 +0100 (CET)","from localhost.localdomain\n\t(cpc108967-cmbg20-2-0-cust420.5-4.cable.virginm.net [81.101.7.165])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AD5B563;\n\tTue, 14 Jan 2020 02:26:30 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578965190;\n\tbh=+jZyLFoG1ahr4AYhYG5DT3WTGtZEbz9jHyF7b+7BJB4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=M9UXGGEw4xuBj/dB55uELdjvBTuR7K2NbDc4VE7cGskuvHoJVf8gBWOM8W5yAzJ2M\n\tgHbXykOuGhFATrS9CIl5nXIdJhFnHHn+Ipmf5sucKeNfRR0H8Gd4pmrHYck0io5gDA\n\tWWR+IDv1HzJxsOrzZOBSiylvyC05ZwQhHo3TEfa8=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Tue, 14 Jan 2020 01:26:26 +0000","Message-Id":"<20200114012626.25265-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: log: Expand log level names","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 14 Jan 2020 01:26:31 -0000"},"content":"When the log severity names were added, there was only 4 characters\nreserved for their printing. When the FATAL level was added, this\nincreased to 5, and thus both DBG and ERR can be expanded to their full\nspelling.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/log.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\nindex f4eb8c11adc3..4fc4b5ce0d39 100644\n--- a/src/libcamera/log.cpp\n+++ b/src/libcamera/log.cpp\n@@ -83,10 +83,10 @@ static int log_severity_to_syslog(LogSeverity severity)\n static const char *log_severity_name(LogSeverity severity)\n {\n \tstatic const char *const names[] = {\n-\t\t\"  DBG\",\n+\t\t\"DEBUG\",\n \t\t\" INFO\",\n \t\t\" WARN\",\n-\t\t\"  ERR\",\n+\t\t\"ERROR\",\n \t\t\"FATAL\",\n \t};\n \n","prefixes":["libcamera-devel"]}