{"id":26361,"url":"https://patchwork.libcamera.org/api/1.1/patches/26361/?format=json","web_url":"https://patchwork.libcamera.org/patch/26361/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260325151416.2114564-20-stefan.klug@ideasonboard.com>","date":"2026-03-25T15:13:51","name":"[v2,19/32] libcamera: delayed_controls: Ignore double pushes for the same frame number","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ead9e97bba893facab47c8adc201b279e03768f8","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26361/mbox/","series":[{"id":5849,"url":"https://patchwork.libcamera.org/api/1.1/series/5849/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5849","date":"2026-03-25T15:13:32","name":"rkisp1: pipeline rework for PFC","version":2,"mbox":"https://patchwork.libcamera.org/series/5849/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26361/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26361/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF0BFC3303\n\tfor ;\n\tWed, 25 Mar 2026 15:15:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 255E962C4E;\n\tWed, 25 Mar 2026 16:15:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D2AA62BF0\n\tfor ;\n\tWed, 25 Mar 2026 16:15:34 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b16a:5ed9:4ada:a95a])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8A8571B98; \n\tWed, 25 Mar 2026 16:14:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FA2YZy+7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774451656;\n\tbh=328G/l2Pz1R8U8ujQ2WBNyhtWw2/yBzz2aZhPPiXddU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FA2YZy+79XnoE4YkiK/ZW4Jyq1Uaf1TlItSJF8j0TBGFp+6QTqYdkl6fbiAp/M99t\n\tiuXXbIt/Q1jjsMkLavDnndbNh8T8FYnaPyDoBzRE2WNaxKdkIIJPG+xgWLxf/fWyfy\n\tr/T1XsYHq9do+Q4bzsEFPwY6smOpMrWJqXrDRsCU=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tPaul Elder ","Subject":"[PATCH v2 19/32] libcamera: delayed_controls: Ignore double pushes\n\tfor the same frame number","Date":"Wed, 25 Mar 2026 16:13:51 +0100","Message-ID":"<20260325151416.2114564-20-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260325151416.2114564-1-stefan.klug@ideasonboard.com>","References":"<20260325151416.2114564-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For successful PFC a single sequence must only be pushed once to delayed\ncontrols. Such a situation can occur if no-ops were pushed in delayed\ncontrols due to a buffer underrun.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Paul Elder \n\n---\n\nChanges in v2:\n- Collated double log message\n- Collected tag\n---\n src/libcamera/delayed_controls.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex 4efe3b39c3f6..bcbce4413456 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -173,8 +173,9 @@ bool DelayedControls::push(uint32_t sequence, const ControlList &controls)\n {\n \tif (sequence < queueCount_) {\n \t\tLOG(DelayedControls, Warning)\n-\t\t\t<< \"Double push for sequence \" << sequence\n-\t\t\t<< \" current queue index: \" << queueCount_;\n+\t\t\t<< \"Ignored double push for sequence \" << sequence\n+\t\t\t<< \". Current queue index: \" << queueCount_;\n+\t\treturn true;\n \t}\n \n \twhile (sequence > queueCount_) {\n@@ -277,7 +278,10 @@ ControlList DelayedControls::get(uint32_t sequence)\n */\n void DelayedControls::applyControls(uint32_t sequence)\n {\n-\tLOG(DelayedControls, Debug) << \"frame \" << sequence << \" started\";\n+\tLOG(DelayedControls, Debug)\n+\t\t<< \"Apply controls for: \" << sequence\n+\t\t<< \" (instant controls for frame \"\n+\t\t<< (sequence - maxDelay_) << \")\";\n \n \twhile (queueCount_ - 1 < sequence) {\n \t\tLOG(DelayedControls, Warning)\n","prefixes":["v2","19/32"]}