{"id":26221,"url":"https://patchwork.libcamera.org/api/1.1/patches/26221/?format=json","web_url":"https://patchwork.libcamera.org/patch/26221/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260220221636.216353-6-rui.wang@ideasonboard.com>","date":"2026-02-20T22:16:34","name":"[v2,5/7] ipa: rkisp1: filter: Parse tuning at init and active manual-mode","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d2b53b7f0eb563a3f1c3f263e7c1cff5cc36886a","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26221/mbox/","series":[{"id":5806,"url":"https://patchwork.libcamera.org/api/1.1/series/5806/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5806","date":"2026-02-20T22:16:29","name":"ipa: rkisp1: make Filter tuning-driven and add manual controls","version":2,"mbox":"https://patchwork.libcamera.org/series/5806/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26221/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26221/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA67DC3240\n\tfor ;\n\tFri, 20 Feb 2026 22:17:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CFF162290;\n\tFri, 20 Feb 2026 23:17:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 492F66228C\n\tfor ;\n\tFri, 20 Feb 2026 23:16:57 +0100 (CET)","from rui-Precision-7560.tail5b760b.ts.net (unknown\n\t[209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED64F63B;\n\tFri, 20 Feb 2026 23:16:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WHXZT8/n\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771625763;\n\tbh=f8zYxdK2G/Tij2aWtdJGssJG2KAyVeggyeEttcAt/8g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WHXZT8/n4YmLuOGTLHFAJrRnnTX9+78L1dV5sMri+QwZHY7qgTRRblYc/i+5jbye7\n\tgNcfrylNR9XM+Oi0z7Sx+Kn4ckxIjI/itSSPUY+i4xmhCUWn3AAAER1/jTDjGSu8wj\n\tw7wfXaQQJIB0trwMEvI+JS5VkD4fnmsHcqfiOeKY=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v2 5/7] ipa: rkisp1: filter: Parse tuning at init and active\n\tmanual-mode","Date":"Fri, 20 Feb 2026 17:16:34 -0500","Message-ID":"<20260220221636.216353-6-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260220221636.216353-1-rui.wang@ideasonboard.com>","References":"<20260220221636.216353-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"-Initialize Filter from tuning data in init() via parseConfig/registerControls.\n -Route manual mode requests through parseControls().\n -Clamp Sharpness using tuning-defined levels.\n -Skip sharpness table override in prepare() when NoiseReductionModeManual is active.\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/filter.cpp | 40 +++++++++++++++++-----------\n 1 file changed, 25 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/filter.cpp b/src/ipa/rkisp1/algorithms/filter.cpp\nindex 62d470f4..48831791 100644\n--- a/src/ipa/rkisp1/algorithms/filter.cpp\n+++ b/src/ipa/rkisp1/algorithms/filter.cpp\n@@ -56,10 +56,13 @@ const std::unordered_set kFilterKeyNames = {\n * \\copydoc libcamera::ipa::Algorithm::init\n */\n int Filter::init(IPAContext &context,\n-\t\t [[maybe_unused]] const YamlObject &tuningData)\n+\t\t const YamlObject &tuningData)\n {\n-\tauto &cmap = context.ctrlMap;\n-\tcmap[&controls::Sharpness] = ControlInfo(0.0f, 10.0f, 1.0f);\n+\tint ret = parseConfig(tuningData);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tregisterControls(context);\n \n \treturn 0;\n }\n@@ -323,18 +326,6 @@ void Filter::queueRequest(IPAContext &context,\n \tauto &filter = context.activeState.filter;\n \tbool update = false;\n \n-\tconst auto &sharpness = controls.get(controls::Sharpness);\n-\tif (sharpness) {\n-\t\tunsigned int value = std::round(std::clamp(*sharpness, 0.0f, 10.0f));\n-\n-\t\tif (filter.sharpness != value) {\n-\t\t\tfilter.sharpness = value;\n-\t\t\tupdate = true;\n-\t\t}\n-\n-\t\tLOG(RkISP1Filter, Debug) << \"Set sharpness to \" << *sharpness;\n-\t}\n-\n \tconst auto &denoise = controls.get(controls::draft::NoiseReductionMode);\n \tif (denoise) {\n \t\tLOG(RkISP1Filter, Debug) << \"Set denoise to \" << *denoise;\n@@ -346,6 +337,22 @@ void Filter::queueRequest(IPAContext &context,\n \t\t}\n \t}\n \n+\tif (filter.denoise == controls::draft::NoiseReductionModeManual) {\n+\t\tupdate |= parseControls(controls);\n+\t} else {\n+\t\tconst auto &sharpness = controls.get(controls::Sharpness);\n+\t\tif (sharpness) {\n+\t\t\tunsigned int value = std::round(std::clamp(*sharpness, 0.0f, static_cast(sharpness_.size() - 1)));\n+\n+\t\t\tif (filter.sharpness != value) {\n+\t\t\t\tfilter.sharpness = value;\n+\t\t\t\tupdate = true;\n+\t\t\t}\n+\n+\t\t\tLOG(RkISP1Filter, Debug) << \"Set sharpness to \" << *sharpness;\n+\t\t}\n+\t}\n+\n \tframeContext.filter.denoise = filter.denoise;\n \tframeContext.filter.sharpness = filter.sharpness;\n \tframeContext.filter.update = update;\n@@ -399,6 +406,9 @@ void Filter::prepare([[maybe_unused]] IPAContext &context,\n \t\treturn;\n \t}\n \n+\tif (denoise == controls::draft::NoiseReductionModeManual)\n+\t\treturn;\n+\n \t/* sharpness override filter register .*/\n \tconst auto &sharp = sharpness_[sharpness];\n \tconfig->fac_sh0 = sharp.at(\"fac_sh0\");\n","prefixes":["v2","5/7"]}