{"id":26219,"url":"https://patchwork.libcamera.org/api/1.1/patches/26219/?format=json","web_url":"https://patchwork.libcamera.org/patch/26219/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260220221636.216353-4-rui.wang@ideasonboard.com>","date":"2026-02-20T22:16:32","name":"[v2,3/7] libcamera: Add rkisp1 vendor control definitions","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2872a5c9eea42b63ee36034e102f3b4b19a7d32b","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26219/mbox/","series":[{"id":5806,"url":"https://patchwork.libcamera.org/api/1.1/series/5806/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5806","date":"2026-02-20T22:16:29","name":"ipa: rkisp1: make Filter tuning-driven and add manual controls","version":2,"mbox":"https://patchwork.libcamera.org/series/5806/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26219/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26219/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 416B3C31E9\n\tfor ;\n\tFri, 20 Feb 2026 22:17:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B91962287;\n\tFri, 20 Feb 2026 23:16:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82DC262271\n\tfor ;\n\tFri, 20 Feb 2026 23:16:55 +0100 (CET)","from rui-Precision-7560.tail5b760b.ts.net (unknown\n\t[209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC5D5371;\n\tFri, 20 Feb 2026 23:16:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VFxVFjAZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771625761;\n\tbh=8dZW7fY38FjRivg92D/ZB/b9tj+rzvrN4ZWHuhS96aY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VFxVFjAZ31cEQtbOc4StNF20ozhLi22hKFlj3SbHOmdb6uKSOMl/ecieGvUUqMr4m\n\tRpAWC7W4EKWbl5gNS3YRRt2vz8uoSiewstzVKSHXPMiAl3nrWnAT5vhLsuprngIh9/\n\tGxeaYt1Mn9R2q9kRGcG2L58nxbTXeKMrvbWHWMUM=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v2 3/7] libcamera: Add rkisp1 vendor control definitions","Date":"Fri, 20 Feb 2026 17:16:32 -0500","Message-ID":"<20260220221636.216353-4-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260220221636.216353-1-rui.wang@ideasonboard.com>","References":"<20260220221636.216353-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"-Add rkisp1 control in meson.\n -Define rkisp1 filter controls in a new control_ids_rkisp1.yaml.\n -Reserve the rkisp1 vendor range in control_ranges.yaml.\n\nSigned-off-by: Rui Wang \n---\n include/libcamera/meson.build | 1 +\n src/libcamera/control_ids_rkisp1.yaml | 151 ++++++++++++++++++++++++++\n src/libcamera/control_ranges.yaml | 4 +-\n 3 files changed, 155 insertions(+), 1 deletion(-)\n create mode 100644 src/libcamera/control_ids_rkisp1.yaml","diff":"diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 30ea76f9..3fd7ef94 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -39,6 +39,7 @@ controls_map = {\n 'draft': 'control_ids_draft.yaml',\n 'rpi/pisp': 'control_ids_rpi.yaml',\n 'rpi/vc4': 'control_ids_rpi.yaml',\n+ 'rkisp1': 'control_ids_rkisp1.yaml',\n },\n \n 'properties': {\ndiff --git a/src/libcamera/control_ids_rkisp1.yaml b/src/libcamera/control_ids_rkisp1.yaml\nnew file mode 100644\nindex 00000000..1fe92e45\n--- /dev/null\n+++ b/src/libcamera/control_ids_rkisp1.yaml\n@@ -0,0 +1,151 @@\n+# SPDX-License-Identifier: LGPL-2.1-or-later\n+#\n+# Copyright (C) 2026, Ideas On Board\n+#\n+# RkISP1 specific control definitions\n+---\n+vendor: rkisp1\n+controls:\n+ # --- RkISP1 Filter controls ---\n+ - FilterEnable:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Enable or disable the Filter processing.\n+ When disabled (false) the hardware filter is forced off regardless of\n+ filter mode selection. When enabled (true) the algorithm may\n+ program parameters and adapt them from manual mode overrides.\n+ Reported in metadata as an int32_t.\n+ enum:\n+ - name: FilterEnableOff\n+ value: 0\n+ description: The filter is disabled.\n+ - name: FilterEnableOn\n+ value: 1\n+ description: The filter is enabled.\n+\n+ - FilterFacSh0:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the fac_sh0 sharpness factor.\n+ Value maps to hardware filter register (typically 0..63).\n+ minimum: 0\n+ maximum: 63\n+\n+ - FilterFacSh1:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the fac_sh1 sharpness factor.\n+ Value maps to hardware filter register (typically 0..63).\n+ minimum: 0\n+ maximum: 63\n+\n+ - FilterFacMid:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the fac_mid sharpness factor.\n+ Value maps to hardware filter register (typically 0..63).\n+ minimum: 0\n+ maximum: 63\n+\n+ - FilterFacBl0:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the fac_bl0 sharpness factor.\n+ Value maps to hardware filter register (typically 0..63).\n+ minimum: 0\n+ maximum: 63\n+\n+ - FilterFacBl1:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the fac_bl1 sharpness factor.\n+ Value maps to hardware filter register (typically 0..63).\n+ minimum: 0\n+ maximum: 63\n+\n+ - FilterThreshSh0:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the thresh_sh0 denoise threshold.\n+ Value maps to hardware threshold register (typically 0..255).\n+ minimum: 0\n+ maximum: 255\n+\n+ - FilterThreshSh1:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the thresh_sh1 denoise threshold.\n+ Value maps to hardware threshold register (typically 0..255).\n+ minimum: 0\n+ maximum: 255\n+\n+ - FilterThreshBl0:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the thresh_bl0 denoise threshold.\n+ Value maps to hardware threshold register (typically 0..255).\n+ minimum: 0\n+ maximum: 255\n+\n+ - FilterThreshBl1:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the thresh_bl1 denoise threshold.\n+ Value maps to hardware threshold register (typically 0..255).\n+ minimum: 0\n+ maximum: 255\n+\n+ - FilterDenoiseMode:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the denoise mode for the filter.\n+ Value maps to hardware mode register (typically 0..255).\n+ minimum: 0\n+ maximum: 255\n+\n+ - FilterDenoiseLumWeight:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the luminance weight for denoise.\n+ Value maps to hardware lum_weight register (typically 0..255).\n+ minimum: 0\n+ maximum: 255\n+\n+ - FilterDenoiseGreenStage1:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the green stage 1 filter for denoise.\n+ Value maps to hardware grn_stage1 register (typically 0..7).\n+ minimum: 0\n+ maximum: 7\n+\n+ - FilterDenoiseChrVMode:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the chroma vertical mode for denoise.\n+ Value maps to hardware chr_v_mode register (typically 0..3).\n+ minimum: 0\n+ maximum: 3\n+\n+ - FilterDenoiseChrHMode:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the chroma horizontal mode for denoise.\n+ Value maps to hardware chr_h_mode register (typically 0..3).\n+ minimum: 0\n+ maximum: 3\ndiff --git a/src/libcamera/control_ranges.yaml b/src/libcamera/control_ranges.yaml\nindex 6752eb98..4964894b 100644\n--- a/src/libcamera/control_ranges.yaml\n+++ b/src/libcamera/control_ranges.yaml\n@@ -15,6 +15,8 @@ ranges:\n rpi: 20000\n # Controls for debug metadata\n debug: 30000\n- # Next range starts at 40000\n+ # Rockchip ISP1 vendor controls\n+ rkisp1: 40000\n+ # Next range starts at 50000\n \n ...\n","prefixes":["v2","3/7"]}