{"id":26206,"url":"https://patchwork.libcamera.org/api/1.1/patches/26206/?format=json","web_url":"https://patchwork.libcamera.org/patch/26206/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219-kbingham-quantizers-v8-10-2b6ff68ead26@ideasonboard.com>","date":"2026-02-19T15:05:11","name":"[v8,10/15] ipa: rkisp1: ccm: Use Q<4, 7> format directly","commit_ref":"411646771016d985946a9fb5f0ca1974c8ad562f","pull_url":null,"state":"accepted","archived":false,"hash":"bdb6b793191bcdfb1f40e7cce77a9bc2eba7b3c4","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26206/mbox/","series":[{"id":5802,"url":"https://patchwork.libcamera.org/api/1.1/series/5802/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5802","date":"2026-02-19T15:05:01","name":"libipa: Introduce a Quantized type","version":8,"mbox":"https://patchwork.libcamera.org/series/5802/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26206/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26206/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90035C32EF\n\tfor ;\n\tThu, 19 Feb 2026 15:05:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7CD662297;\n\tThu, 19 Feb 2026 16:05:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D6CB62262\n\tfor ;\n\tThu, 19 Feb 2026 16:05:11 +0100 (CET)","from ping.linuxembedded.co.uk\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4858E1F17;\n\tThu, 19 Feb 2026 16:04:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u8Wpp8QJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771513458;\n\tbh=4pCBfQSee7I0pfwKO4in0LLcCKgDO/USt9/vbY6gvNs=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=u8Wpp8QJyNKJnoSpUm5sb2jqdTxhbaZO5BZvjiaD81Fbd7uC5UFMCS6FZH95167PO\n\tHo7sIC0vAp2FWDWmLlaYUBXjZJngN15ABG/bHw+AtO8JSLtQpvJXNZ8jLHfT4JaC8A\n\t3JsamraweeK2YKx98p1bPCCZSMy5uzhUVSq/gNxY=","From":"Kieran Bingham ","Date":"Thu, 19 Feb 2026 15:05:11 +0000","Subject":"[PATCH v8 10/15] ipa: rkisp1: ccm: Use Q<4, 7> format directly","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260219-kbingham-quantizers-v8-10-2b6ff68ead26@ideasonboard.com>","References":"<20260219-kbingham-quantizers-v8-0-2b6ff68ead26@ideasonboard.com>","In-Reply-To":"<20260219-kbingham-quantizers-v8-0-2b6ff68ead26@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham , Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t, Laurent Pinchart\n\t","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1771513507; l=1173;\n\ti=kieran.bingham@ideasonboard.com; s=20260207;\n\th=from:subject:message-id; \n\tbh=4pCBfQSee7I0pfwKO4in0LLcCKgDO/USt9/vbY6gvNs=;\n\tb=l8Pvi9CTn6qDFUhy5gmbOmEo9YiEoNxMZ6CgherZrz3ZIsE4C5YXcqEt5KY6P+wFuH+dAcGkJ\n\tDuvMSyjQenqC4XsgZs6dWtFE+VRkCY0ZEuS58/z6ZpGRnfbhmgg97Wa","X-Developer-Key":"i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY=","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace the legacy call to floatingToFixedPoint with the new FixedPoint\nquantizer to explicitly describe the type used by the RKISP1 Colour\nCorrection Matrix.\n\nReviewed-by: Isaac Scott \nReviewed-by: Barnabás Pőcze \nReviewed-by: Paul Elder \nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n---\n src/ipa/rkisp1/algorithms/ccm.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\nindex de2b6fe775aa..466d7a116eea 100644\n--- a/src/ipa/rkisp1/algorithms/ccm.cpp\n+++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n@@ -117,8 +117,7 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n \t */\n \tfor (unsigned int i = 0; i < 3; i++) {\n \t\tfor (unsigned int j = 0; j < 3; j++)\n-\t\t\tconfig.coeff[i][j] =\n-\t\t\t\tfloatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n+\t\t\tconfig.coeff[i][j] = Q<4, 7>(matrix[i][j]).quantized();\n \t}\n \n \tfor (unsigned int i = 0; i < 3; i++)\n","prefixes":["v8","10/15"]}