{"id":26195,"url":"https://patchwork.libcamera.org/api/1.1/patches/26195/?format=json","web_url":"https://patchwork.libcamera.org/patch/26195/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219144040.1615042-4-laurent.pinchart@ideasonboard.com>","date":"2026-02-19T14:40:39","name":"[v3,3/4] libcamera: Use `it` variable name for iterators only","commit_ref":"5a44c5af0649a0f29feaee0f9a2a1612fe4b4ac3","pull_url":null,"state":"accepted","archived":false,"hash":"2fd794763ddb2bb926863eb664b3ee69d73506d9","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26195/mbox/","series":[{"id":5801,"url":"https://patchwork.libcamera.org/api/1.1/series/5801/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5801","date":"2026-02-19T14:40:36","name":"libcamera: Clean up iterators","version":3,"mbox":"https://patchwork.libcamera.org/series/5801/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26195/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26195/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FF04C31E9\n\tfor ;\n\tThu, 19 Feb 2026 14:40:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D93F362253;\n\tThu, 19 Feb 2026 15:40:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EE90620C9\n\tfor ;\n\tThu, 19 Feb 2026 15:40:55 +0100 (CET)","from killaraus.ideasonboard.com (unknown [83.245.237.175])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CF4D0FCC\n\tfor ;\n\tThu, 19 Feb 2026 15:40:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U5F58Hp/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771512002;\n\tbh=tlgaLMRuX0jLgEAwryLrRy8t19ujPYRzLT7aNW+9DC4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=U5F58Hp/QfSQFqR4GKJ776pK4qSiQ2id6jdzXeikTsZ9vy3/9QOg3vBGWFzDjTUta\n\tldZQBRPJcHM90OJvnyUvyErJ/6VaraztqXBOG0dQGHhxOMxPVxkJppGko0Bd4/hgDm\n\t0lNhn2SWIzXMWG1YSLO7rKsvNGQjaXYW8JLEvUGU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 3/4] libcamera: Use `it` variable name for iterators only","Date":"Thu, 19 Feb 2026 15:40:39 +0100","Message-ID":"<20260219144040.1615042-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219144040.1615042-1-laurent.pinchart@ideasonboard.com>","References":"<20260219144040.1615042-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Using the name `it` for a variable that is not an iterator is confusing.\nGive the variable a more explanatory name.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Barnabás Pőcze \n---\n include/libcamera/internal/ipa_data_serializer.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\nindex 61bada52f691..0dda76d5b1d1 100644\n--- a/include/libcamera/internal/ipa_data_serializer.h\n+++ b/include/libcamera/internal/ipa_data_serializer.h\n@@ -114,12 +114,12 @@ public:\n \t\tappendPOD(dataVec, vecLen);\n \n \t\t/* Serialize the members. */\n-\t\tfor (auto const &it : data) {\n+\t\tfor (const auto &value : data) {\n \t\t\tstd::vector dvec;\n \t\t\tstd::vector fvec;\n \n \t\t\tstd::tie(dvec, fvec) =\n-\t\t\t\tIPADataSerializer::serialize(it, cs);\n+\t\t\t\tIPADataSerializer::serialize(value, cs);\n \n \t\t\tappendPOD(dataVec, dvec.size());\n \t\t\tappendPOD(dataVec, fvec.size());\n","prefixes":["v3","3/4"]}