{"id":2619,"url":"https://patchwork.libcamera.org/api/1.1/patches/2619/?format=json","web_url":"https://patchwork.libcamera.org/patch/2619/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200113164245.52535-5-jacopo@jmondi.org>","date":"2020-01-13T16:42:26","name":"[libcamera-devel,04/23] libcamera: properties: Add rotation property","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bb61f51a6ae84166404593ddf06e2b8d245c1255","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2619/mbox/","series":[{"id":618,"url":"https://patchwork.libcamera.org/api/1.1/series/618/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=618","date":"2020-01-13T16:42:22","name":"Properties and compound controls","version":1,"mbox":"https://patchwork.libcamera.org/series/618/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2619/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2619/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0782160700\n\tfor ;\n\tMon, 13 Jan 2020 17:40:27 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 96382100003;\n\tMon, 13 Jan 2020 16:40:26 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 13 Jan 2020 17:42:26 +0100","Message-Id":"<20200113164245.52535-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.24.0","In-Reply-To":"<20200113164245.52535-1-jacopo@jmondi.org>","References":"<20200113164245.52535-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 04/23] libcamera: properties: Add rotation\n\tproperty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 13 Jan 2020 16:40:27 -0000"},"content":"The rotation property describes the rotation of the camera sensor.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/property_ids.yaml | 309 ++++++++++++++++++++++++++++++++\n 1 file changed, 309 insertions(+)","diff":"diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex aaadcbd3e52b..243af7bd0a03 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -25,4 +25,313 @@ controls:\n description: |\n The camera is attached to the device in a way that allows it to\n be moved freely\n+\n+ - Rotation:\n+ type: int32_t\n+ description: |\n+ The camera rotation is expressed as the angular difference in degrees\n+ between two reference systems, one implicitly defined by the camera\n+ module intrinsics characteristics, and one artificially defined on the\n+ external world scene to be captured when projected on the image sensor\n+ pixel array.\n+\n+ A camera sensor has an implicitly defined 2-dimensional reference\n+ system 'Rc' defined by its pixel array scan-out order, with its origin\n+ posed at pixel address (0,0), the x-axis progressing from there towards\n+ the last scanned out column of the pixel array and the y-axis\n+ progressing towards the last scanned out line.\n+\n+ A typical example for a sensor with a (2592x1944) pixel array matrix\n+ observed from the front is\n+\n+ (2592) x-axis 0\n+ <------------------------+ 0\n+ .......... ... ..........!\n+ .......... ... ..........! y-axis\n+ ... !\n+ .......... ... ..........!\n+ .......... ... ..........! (1944)\n+ V\n+\n+ The external world scene reference system scene 'Rs' is defined as a\n+ 2-dimensional reference system on the parallel plane posed in front\n+ of the camera module's focal plane, with its origin placed on the\n+ visible top-left corner, the x-axis progressing towards the right from\n+ there and the y-axis progressing towards the bottom of the visible\n+ scene.\n+\n+ A typical example of a (very common) picture of a shark swimming from\n+ left to right is\n+\n+ x-axis\n+ (0,0)---------------------->\n+ !\n+ !\n+ ! |\\____)\\___\n+ ! ) _____ __`<\n+ ! |/ )/\n+ !\n+ V\n+ y-axis\n+\n+ With the reference plane posed in front of the camera module and\n+ parallel to its focal plane\n+\n+ !\n+ / !\n+ / !\n+ / !\n+ _ / !\n+ +-/ \\-+ / !\n+ | (o) | ! 'Rs' reference plane\n+ +-----+ \\ !\n+ \\ !\n+ \\ !\n+ \\ !\n+ \\ !\n+ !\n+\n+ When projected on the sensor's pixel array, the image and the associated\n+ reference system 'Rs' are typically inverted, due to the camera module's\n+ lens optical inversion effect.\n+\n+ Assuming the above represented scene of the swimming shark, the lens\n+ inversion projects on the sensor pixel array the reference plane 'Rp'\n+\n+ y-axis\n+ ^\n+ !\n+ ! |\\_____)\\__\n+ ! ) ____ ___.<\n+ ! |/ )/\n+ !\n+ !\n+ (0,0)---------------------->\n+ x-axis\n+\n+ The camera rotation property is then defined as the angular difference\n+ in counterclockwise direction between the origin of the camera reference\n+ system 'Rc', defined by the camera sensor scan-out direction and its\n+ mounting position, and the origin of the projected scene reference\n+ system 'Rp', result of the optical projection of the scene reference\n+ system 'Rs' on the sensor pixel array.\n+\n+ Examples\n+\n+ 0 degrees camera rotation\n+\n+ y-Rp\n+ y-Rc ^\n+ ^ !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! (0,0)---------------------->\n+ ! x-Rp\n+ 0 +------------------------------------->\n+ 0 x-Rc\n+\n+\n+ x-Rc 0\n+ <------------------------+ 0\n+ x-Rp !\n+ <-----------------------(0,0) !\n+ ! !\n+ ! !\n+ ! !\n+ ! V\n+ ! y-Rc\n+ V\n+ y-Rp\n+\n+ 90 degrees camera rotation\n+\n+ 0 y-Rc\n+ 0 +----------------------->\n+ !\n+ ! y-Rp\n+ ! ^\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! (0,0)---------------------->\n+ ! x-Rp\n+ !\n+ V\n+ x-Rc\n+\n+ 180 degrees camera rotation\n+\n+ x-Cr 0\n+ <------------------------+ 0\n+ y-Rp !\n+ ^ !\n+ ! ! y-Cr\n+ ! !\n+ ! !\n+ ! V\n+ !\n+ !\n+ (0,0)--------------------->\n+ x-Rp\n+\n+ 270 degrees camera rotation\n+\n+ 0 y-Rc\n+ 0 +----------------------->\n+ ! x-Rp\n+ ! <-----------------------(0,0\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! V\n+ ! y-Rp\n+ !\n+ !\n+ V\n+ x-Rc\n+\n+\n+\n+ Example one - Webcam\n+\n+ A camera module installed on the user facing part of a laptop screen\n+ casing used for video calls. The captured images are meant to be\n+ displayed in landscape mode (width > height) on the laptop screen.\n+\n+ The camera is typically mounted 180 degrees rotated to compensate the\n+ lens optical inversion effect.\n+\n+ y-Rp\n+ y-Rc ^\n+ ^ !\n+ ! ! |\\_____)\\__\n+ ! ! ) ____ ___.<\n+ ! ! |/ )/\n+ ! !\n+ ! !\n+ ! (0,0)---------------------->\n+ ! x-Rp\n+ 0 +------------------------------------->\n+ 0 x-Rc\n+\n+ The two reference systems are aligned, the resulting camera rotation is\n+ 0 degrees, no rotation correction should be applied to the resulting\n+ image once captured to memory buffers to correctly display it to users.\n+\n+ +--------------------------+\n+ ! |\\____)\\___ !\n+ ! ) _____ __`< !\n+ ! |/ )/ !\n+ +--------------------------+\n+\n+ If the camera module is not mounted 180 degrees rotated to compensate\n+ the lens optical inversion, the two reference system will result not\n+ aligned, with 'Rp' plane 180 degrees rotated in respect to the 'Rc'\n+ plane.\n+\n+ x-Rc 0\n+ <------------------------+ 0\n+ y-Rp !\n+ ^ !\n+ ! ! y-Rc\n+ ! |\\_____)\\__ !\n+ ! ) ____ ___.< !\n+ ! |/ )/ V\n+ !\n+ !\n+ (0,0)--------------------->\n+ x-Rp\n+\n+ The image once captured to memory will then be 180 degrees rotated\n+\n+ +--------------------------+\n+ ! __/(_____/| !\n+ ! >.___ ____ ( !\n+ ! \\( \\| !\n+ +--------------------------+\n+\n+ A software rotation correction of 180 degrees should be applied to\n+ correctly display the image.\n+\n+ +--------------------------+\n+ ! |\\____)\\___ !\n+ ! ) _____ __`< !\n+ ! |/ )/ !\n+ +--------------------------+\n+\n+ Example two - Phone camera\n+\n+ A camera installed on the back-side of a mobile device facing away from\n+ the user. The captured images are meant to be displayed in portrait mode\n+ (height > width) to match the device screen orientation and the device\n+ usage orientation used when taking the picture.\n+\n+ The camera is typically mounted with its pixel array longer side aligned\n+ to the device longer side, 180 degrees rotated to compensate the lens\n+ optical inversion effect.\n+\n+ 0 y-Rc\n+ 0 +----------------------->\n+ !\n+ ! y-Rp\n+ ! ^\n+ ! !\n+ ! ! |\\_____)\\__\n+ ! ! ) ____ ___.<\n+ ! ! |/ )/\n+ ! !\n+ ! !\n+ ! (0,0)---------------------->\n+ ! x-Rp\n+ !\n+ !\n+ V\n+ x-Rc\n+\n+ The two reference systems are not aligned and the 'Rp' reference\n+ system is 90 degrees rotated in counterclockwise direction in respect\n+ to the 'Rc' reference system.\n+\n+ The image, when captured to memory buffer will be rotated.\n+\n+ +---------------------------------------+\n+ | _ _ |\n+ | \\ / |\n+ | | | |\n+ | | | |\n+ | | > |\n+ | < | |\n+ | | | |\n+ | . |\n+ | V |\n+ +---------------------------------------+\n+\n+ A correction of 90 degrees in counterclockwise direction has to be\n+ applied to correctly display the image in portrait mode on the device\n+ screen.\n+\n+ +-----------------+\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\\____)\\___ |\n+ | ) _____ __`< |\n+ | |/ )/ |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ +-----------------+\n ...\n","prefixes":["libcamera-devel","04/23"]}