{"id":26172,"url":"https://patchwork.libcamera.org/api/1.1/patches/26172/?format=json","web_url":"https://patchwork.libcamera.org/patch/26172/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216203034.27558-4-mzamazal@redhat.com>","date":"2026-02-16T20:30:22","name":"[RFC,v2,03/14] libcamera: software_isp: Separate allocation of the parameters buffer","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d7d82c675ff90dc0b99aaf1c291d528e196d2a87","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26172/mbox/","series":[{"id":5795,"url":"https://patchwork.libcamera.org/api/1.1/series/5795/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5795","date":"2026-02-16T20:30:19","name":"Software ISP: Share params and stats buffers","version":2,"mbox":"https://patchwork.libcamera.org/series/5795/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26172/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26172/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12F0FC0DA4\n\tfor ;\n\tMon, 16 Feb 2026 20:30:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97CC16220E;\n\tMon, 16 Feb 2026 21:30:51 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1176C62205\n\tfor ;\n\tMon, 16 Feb 2026 21:30:49 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-130-WgpgWodQM1O9DgPM1_2r-A-1;\n\tMon, 16 Feb 2026 15:30:47 -0500","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 9B9BE1956094 for ;\n\tMon, 16 Feb 2026 20:30:46 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.25])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 60AE518004AD; Mon, 16 Feb 2026 20:30:45 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"MtQo3kvF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1771273848;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ty7Pl+oSdBnm4kdYhkv46mxz2PSFLMnGeRLtqMy2QL8=;\n\tb=MtQo3kvF4ifoCsSq4kTh3/dof8bZ0IDqOeUsXg+WNVaNTPXfuQqMux4UYGZMi+zyc0dAt0\n\tAhLLQ86rNtyItFz+gCluOrIwLTxpFpXyP+SO1XTGAlqbGrV3rIYFKDo7j9LSh7U3qLaLhp\n\tanbm/sUN9FHqG4VgKgCdhUOZ7Fc6wIM=","X-MC-Unique":"WgpgWodQM1O9DgPM1_2r-A-1","X-Mimecast-MFC-AGG-ID":"WgpgWodQM1O9DgPM1_2r-A_1771273846","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[RFC PATCH v2 03/14] libcamera: software_isp: Separate allocation of\n\tthe parameters buffer","Date":"Mon, 16 Feb 2026 21:30:22 +0100","Message-ID":"<20260216203034.27558-4-mzamazal@redhat.com>","In-Reply-To":"<20260216203034.27558-1-mzamazal@redhat.com>","References":"<20260216203034.27558-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"dyg-1wE3eKow6gOVClPMHfW1VewQj3PP4zTOE7MCqqI_1771273846","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There will be some additions to that code in followup patches and let's\nnot blow the code in SoftwareIsp constructor even more.\n\nSigned-off-by: Milan Zamazal \n---\n .../internal/software_isp/software_isp.h | 1 +\n src/libcamera/software_isp/software_isp.cpp | 17 ++++++++++++-----\n 2 files changed, 13 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 30b25cddf..dc6b6f7c1 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -98,6 +98,7 @@ private:\n \tThread ispWorkerThread_;\n \tSharedMemObject sharedParams_;\n \tDebayerParams debayerParams_;\n+\tbool allocateParamsBuffers();\n \tDmaBufAllocator dmaHeap_;\n \tbool ccmEnabled_;\n \ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 0447d2171..dc0a8eb84 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -88,12 +88,8 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\tLOG(SoftwareIsp, Error) << \"Failed to create DmaBufAllocator object\";\n \t\treturn;\n \t}\n-\n-\tsharedParams_ = SharedMemObject(\"softIsp_params\");\n-\tif (!sharedParams_) {\n-\t\tLOG(SoftwareIsp, Error) << \"Failed to create shared memory for parameters\";\n+\tif (!allocateParamsBuffers())\n \t\treturn;\n-\t}\n \n \tconst GlobalConfiguration &configuration = pipe->cameraManager()->_d()->configuration();\n \n@@ -176,6 +172,17 @@ SoftwareIsp::~SoftwareIsp()\n \tdebayer_.reset();\n }\n \n+bool SoftwareIsp::allocateParamsBuffers()\n+{\n+\tsharedParams_ = SharedMemObject(\"softIsp_params\");\n+\tif (!sharedParams_) {\n+\t\tLOG(SoftwareIsp, Error) << \"Failed to create shared memory for parameters\";\n+\t\treturn false;\n+\t}\n+\n+\treturn true;\n+}\n+\n /**\n * \\fn int SoftwareIsp::loadConfiguration([[maybe_unused]] const std::string &filename)\n * \\brief Load a configuration from a file\n","prefixes":["RFC","v2","03/14"]}