{"id":26158,"url":"https://patchwork.libcamera.org/api/1.1/patches/26158/?format=json","web_url":"https://patchwork.libcamera.org/patch/26158/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260215094418.18642-1-johannes.goede@oss.qualcomm.com>","date":"2026-02-15T09:44:17","name":"[v2,1/2] software_isp: benchmark: Add missing _ postfix to measure data member","commit_ref":"f0a79dd68b062a0a01da2b98257fdeae8710363d","pull_url":null,"state":"accepted","archived":false,"hash":"f4b6816ed87497d25ce00da4c846afea84ab8300","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/1.1/people/242/?format=json","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26158/mbox/","series":[{"id":5790,"url":"https://patchwork.libcamera.org/api/1.1/series/5790/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5790","date":"2026-02-15T09:44:17","name":"[v2,1/2] software_isp: benchmark: Add missing _ postfix to measure data member","version":2,"mbox":"https://patchwork.libcamera.org/series/5790/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26158/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26158/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23516BDE6B\n\tfor ;\n\tSun, 15 Feb 2026 09:44:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF70D621EB;\n\tSun, 15 Feb 2026 10:44:26 +0100 (CET)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E099161FA0\n\tfor ;\n\tSun, 15 Feb 2026 10:44:24 +0100 (CET)","from pps.filterd (m0279868.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t61F5iVQb309658 for ;\n\tSun, 15 Feb 2026 09:44:23 GMT","from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n\t[209.85.222.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cagcf26h8-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tSun, 15 Feb 2026 09:44:23 +0000 (GMT)","by mail-qk1-f197.google.com with SMTP id\n\taf79cd13be357-8c70b6a5821so998389785a.0\n\tfor ;\n\tSun, 15 Feb 2026 01:44:23 -0800 (PST)","from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-65bad3e390bsm1413658a12.17.2026.02.15.01.44.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 15 Feb 2026 01:44:20 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"guW+UQRJ\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"MmF9niDH\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=qcppdkim1; bh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgT\n\todHMLqjo=; b=guW+UQRJNAqCccgjUy4R1BiJiuelxHJChlGxgiSl7K0+dGjP8fC\n\tMonyXryllk2fK285gapP7IxzBQx2guczLtF+hCKeki0V7sUGIYIqUWJGda9OfOJu\n\tQ6/sZvqjRxWdapGg5l+FR3LDNnryD7Ys+FhsoGaTIP4llhwzW77vB4MzjqRcnd1e\n\tc7g33CZXIu6kLUMMhdXHjNIJjuwuShJSq24UzlOGdUqog86bPEgYDUbHmR3DpHlv\n\t5fK7WL95GKDXRPZhGDFKVJz6BUUy4LTIH5CaHx36eg5AqOUMXPRiN5KY7BUZDwZY\n\t6TEn2Su+xFDROjK8Kp4WG2c3rQctgnH4QSg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1771148662; x=1771753462;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgTodHMLqjo=;\n\tb=MmF9niDH5qSHJMMu8DJujypZcuML6yTf/n3Ril/3JTTXbHZk/oy/Ks3CHzFGAQLPdd\n\tuLJGLqypH02JTKE3rV64lOCSn1TlJNj/dn2m/tgSw2+gm2gajsauuv3DB1rSYCJek5YD\n\tnU7CDjVwTVBtNmDPTRlWXCtdCwFBJeUUgSIP02Ep1zBR2QQgRoz+iKgSWXAmzVq0mXD9\n\tOlJzhoVpHoZQeH8gyVDl8yLqMil7QvxKkDkvLYTD4stZcrux6u6pZ5MTmuJMtgEzJXVb\n\tFp1ehwXi0oj4BDkiELi4fTrbvV05ilVTlrkxKmyvBrt+G9aOKhpnMBFMq7jXk219t5F1\n\teQFg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1771148662; x=1771753462;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgTodHMLqjo=;\n\tb=VcCCA384wuw0a0Es9Xg3YXaegsLWt4RFf4mHQq89DMfGzpz/TPbTFkGGo4WZeEudMm\n\tTyysm9qq6fFLGxx743gFQeXBvhO09xIVIu+sOYuHVZsTnvBnr58lO9jG7dsfh+/XOYhc\n\tMw/f1yaONpPLOsn2HvIB6ywCvx6CLWjDAgZ54SVNz+ZJp/VLFSOFJTiEnuql2vq5BDhh\n\tmHCbT2O6amWr8UkMoq8uO4m9Oo3w2E60e4A/84OyoC662zkMFPeL0ast3dZU8VzqBlh/\n\tP9YqhIgIq0x4M6lJQL571b4LoJnTEihPL3L8NmpF+LphsqoKEX3DDz+NHVK4HlxduRtC\n\tTRPQ==","X-Gm-Message-State":"AOJu0Yybt2RFWP0+3QjxALnrnR90i6F1WVIi35eNEEJecqQlctifAQZX\n\tM/qTqUYWeA0CyBpcjQCEgceomVdajLJpiAjjYSxm7VCFMOnicf98yTU2qvoOYp8m5qVnAJ81CYE\n\tW2r18quexVXtGh7r0IRus35QGtVqjXuCIWHZ3PgjTHIS+GaxEzIGLTvA5Xx9d0mYU9QM7hkIpUj\n\tk1V8+Ya+Z/","X-Gm-Gg":"AZuq6aL4gkNKLVQ0x6tpfVXqOfPb2I3h34JbbHDARRnnec4fA1h+r1j02ytEYlJZEKz\n\t7egY8uUfCxiPy+Wd2nP4suRlvAnyetmNCorynFTD0I3ZcTrsHKldipXgHxDFPdNhpN0RHQhiZZz\n\tigWHBQk6l8DlgVwdSP1ZVGKRpN9nAaBXddD7POO0Q2j/m11rW61vkaAsd5O/zDq7oiq6MTZpGM/\n\t1zHuXub0OX3J2hSWJUkBjoP+JYpQRvLi9284cvs4nIjfIMbLA8gc+dKSmOZbHXG03mQjSgyNhg3\n\tuPF+vJ/auS0gWETNxYAj+sxPGjV6QJcGwqFFT2kY7VhS8tkCCMqn6uwCoAy/5byy9xVgvggczmI\n\t1p0UelcIDSmaMJgbpXX4L3lzKfTKSVdb+EtXgp91BtoWzFeiSgiHbT2RL2vrkKKJ0DyzLyA28n1\n\t7wbaas4gDRQ2LP4u1T3+ZsZubnphTsA2OyaB7g","X-Received":["by 2002:a05:620a:7107:b0:8c6:ed6b:5865 with SMTP id\n\taf79cd13be357-8cb4216c99cmr891840985a.0.1771148662444; \n\tSun, 15 Feb 2026 01:44:22 -0800 (PST)","by 2002:a05:620a:7107:b0:8c6:ed6b:5865 with SMTP id\n\taf79cd13be357-8cb4216c99cmr891839785a.0.1771148662005; \n\tSun, 15 Feb 2026 01:44:22 -0800 (PST)"],"From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org, Milan Zamazal ","Cc":"Hans de Goede ","Subject":"[PATCH v2 1/2] software_isp: benchmark: Add missing _ postfix to\n\tmeasure data member","Date":"Sun, 15 Feb 2026 10:44:17 +0100","Message-ID":"<20260215094418.18642-1-johannes.goede@oss.qualcomm.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-GUID":"Zmi0Y8vt1644oMnWh2GZ1rcoV3yME6YY","X-Proofpoint-ORIG-GUID":"Zmi0Y8vt1644oMnWh2GZ1rcoV3yME6YY","X-Authority-Analysis":"v=2.4 cv=Sc76t/Ru c=1 sm=1 tr=0 ts=69919577 cx=c_pps\n\ta=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n\ta=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=2M7dtBtliclCZGfxGjwA:9\n\ta=IoWCM6iH3mJn3m4BftBB:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMjE1MDA3NiBTYWx0ZWRfXyxFjhxICnVOb\n\taSowIPSk3SbAFs6FhMqCEVOf1USQfAEtGCYBnFa7/BgqP+z/TLVWgCmUJVTkQRrCpns6RjNle0s\n\tVcDGxJiVYXAbMeLOGXbfF5K1Bdm8rezPR00+weZlJocT5ai+/fWvbXrOjGuxdsfbDOlmTS7p04n\n\t9425XHqx8Hatna0LV8GBq3WcAD+4MaFTn/BReL4hlnwpWWpKSy017PK1NU6YA2v5Id4B7p1iBUE\n\t5xaK2YoYrR+qkTawa6u56pzMR88c/G9WsTaVJ+i/sqwvfHUApzaEdrKsSFyj232hkL26DzL8hzI\n\tVxZK7PpZrOKvYsFfdSafSuRmT4GefU4nIsp69CXoBMpyv3ptdkfIHtq/CfOLo86+q/akBNkPrTY\n\tjRzdWxij0PqrNdsLomUNmpYh4UH4UTMMNa07QDivhZXKNrEVLEBxwhV8BZzBTo9kE61GO5krXKF\n\taUCZygvnT+rWRBjRVTQ==","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-02-15_03,2026-02-13_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tbulkscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501\n\tphishscore=0\n\timpostorscore=0 spamscore=0 clxscore=1015 suspectscore=0\n\tmalwarescore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2601150000\n\tdefinitions=main-2602150076","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"All class data members should have a _ postifx, add the missing _ postfix\nto the Benchmark::measure_ data member.\n\nSigned-off-by: Hans de Goede \n---\n include/libcamera/internal/software_isp/benchmark.h | 2 +-\n src/libcamera/software_isp/benchmark.cpp | 10 +++++-----\n 2 files changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/include/libcamera/internal/software_isp/benchmark.h b/include/libcamera/internal/software_isp/benchmark.h\nindex 0680d6cd..46bdb86d 100644\n--- a/include/libcamera/internal/software_isp/benchmark.h\n+++ b/include/libcamera/internal/software_isp/benchmark.h\n@@ -28,7 +28,7 @@ public:\n \n private:\n \ttimespec frameStartTime_;\n-\tbool measure;\n+\tbool measure_;\n \t/* Skip 30 frames for things to stabilize then measure 30 frames */\n \tunsigned int encounteredFrames_ = 0;\n \tint64_t frameProcessTime_ = 0;\ndiff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp\nindex 1a00ae56..4ffb6773 100644\n--- a/src/libcamera/software_isp/benchmark.cpp\n+++ b/src/libcamera/software_isp/benchmark.cpp\n@@ -54,11 +54,11 @@ static inline int64_t timeDiff(timespec &after, timespec &before)\n */\n void Benchmark::startFrame(void)\n {\n-\tmeasure = framesToMeasure_ > 0 &&\n-\t\t encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ &&\n-\t\t ++encounteredFrames_ > skipBeforeMeasure_;\n+\tmeasure_ = framesToMeasure_ > 0 &&\n+\t\t encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ &&\n+\t\t ++encounteredFrames_ > skipBeforeMeasure_;\n \n-\tif (measure) {\n+\tif (measure_) {\n \t\tframeStartTime_ = {};\n \t\tclock_gettime(CLOCK_MONOTONIC_RAW, &frameStartTime_);\n \t}\n@@ -75,7 +75,7 @@ void Benchmark::startFrame(void)\n */\n void Benchmark::finishFrame(void)\n {\n-\tif (measure) {\n+\tif (measure_) {\n \t\ttimespec frameEndTime = {};\n \t\tclock_gettime(CLOCK_MONOTONIC_RAW, &frameEndTime);\n \t\tframeProcessTime_ += timeDiff(frameEndTime, frameStartTime_);\n","prefixes":["v2","1/2"]}