{"id":26151,"url":"https://patchwork.libcamera.org/api/1.1/patches/26151/?format=json","web_url":"https://patchwork.libcamera.org/patch/26151/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260213-kbingham-quantizers-v7-9-1626b9aaabf1@ideasonboard.com>","date":"2026-02-13T16:57:48","name":"[v7,09/15] ipa: rkisp1: cproc: Provide a Hue control","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3f42ef7371f52ab9aa559029d5f18d2d1d3794ee","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26151/mbox/","series":[{"id":5789,"url":"https://patchwork.libcamera.org/api/1.1/series/5789/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5789","date":"2026-02-13T16:57:39","name":"libipa: Introduce a Quantized type","version":7,"mbox":"https://patchwork.libcamera.org/series/5789/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26151/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26151/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3A91C32F4\n\tfor ;\n\tFri, 13 Feb 2026 16:58:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A6C56220C;\n\tFri, 13 Feb 2026 17:58:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B953621EB\n\tfor ;\n\tFri, 13 Feb 2026 17:58:06 +0100 (CET)","from ping.linuxembedded.co.uk\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 558CB26C4;\n\tFri, 13 Feb 2026 17:57:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nWKKSt0s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771001837;\n\tbh=9l1KDP7Esu5b5XWJMph6Z3R7VlhMCGR2V6tiw0wVo4w=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=nWKKSt0sOACALQpA2GCt86QQ1rROqVGojp8pFUDR13xC5k3TAq4Kca4cG+716ZM2R\n\tyUkLvVU1Yp4BmLXsmvAJcdlZ/vu09NXWy+WfK7XGIqBMXQbxNc+w/p1GHR3F9w0eYz\n\ttdew1+ZSiI1ixmxn/2+FELuVSWrO+YeqMQ96NeVQ=","From":"Kieran Bingham ","Date":"Fri, 13 Feb 2026 16:57:48 +0000","Subject":"[PATCH v7 09/15] ipa: rkisp1: cproc: Provide a Hue control","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260213-kbingham-quantizers-v7-9-1626b9aaabf1@ideasonboard.com>","References":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>","In-Reply-To":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham , Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1771001883; l=5043;\n\ti=kieran.bingham@ideasonboard.com; s=20260207;\n\th=from:subject:message-id; \n\tbh=9l1KDP7Esu5b5XWJMph6Z3R7VlhMCGR2V6tiw0wVo4w=;\n\tb=HlCQVELubasZCDke/sijo8XfCIK10F+h5lfq9eU/C0SfxThuXYSyw8+3v3/9nSj4WgcFLa5gX\n\t8XjJIbWCBSkBIhSB/vlqorZnpE6LxX6XgCuIn3YR230HDPPVMStG482","X-Developer-Key":"i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY=","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The RKISP1 supports a configurable Hue as part of the colour processing\nunit (cproc).\n\nImplement the new control converting to the hardware scale accordingly\nand report the applied control in the completed request metadata.\n\nThis is implemented as a phase shift of the chrominance values between\n-90 and +87.188 degrees according to the datasheet however the type\nitself would imply that this is a range between -90 and 89.2969.\n\nMoreover, the hardware applies the inverse phase shift to the operation\nexpected and documented by libcamera, so we apply a negative scale when\nconverting the libcamera control to the Q<1,7> type, resulting in a\nrange of -89.2969 to +90.0 degrees control.\n\nReviewed-by: Isaac Scott \nTested-by: Barnabás Pőcze \nSigned-off-by: Kieran Bingham \n\n---\n\nv5:\n- Use Q<1, 7> directly and handle scaling in cproc.cpp\n- Use full string of quantized in debug log\n- Invert/Negate the hardware hue direction\n---\n src/ipa/rkisp1/algorithms/cproc.cpp | 28 ++++++++++++++++++++++++++++\n src/ipa/rkisp1/ipa_context.h | 3 +++\n 2 files changed, 31 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\nindex e9e2b5444bc9..7484e4780094 100644\n--- a/src/ipa/rkisp1/algorithms/cproc.cpp\n+++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n@@ -37,8 +37,15 @@ namespace {\n \n constexpr float kDefaultBrightness = 0.0f;\n constexpr float kDefaultContrast = 1.0f;\n+constexpr float kDefaultHue = 0.0f;\n constexpr float kDefaultSaturation = 1.0f;\n \n+/*\n+ * The Hue scale is negated as the hardware performs the opposite phase shift\n+ * to what is expected and defined from the libcamera Hue control value.\n+ */\n+constexpr float kHueScale = -90.0f;\n+\n } /* namespace */\n \n /**\n@@ -53,6 +60,11 @@ int ColorProcessing::init(IPAContext &context,\n \tcmap[&controls::Contrast] = ControlInfo(0.0f, 1.993f, kDefaultContrast);\n \tcmap[&controls::Saturation] = ControlInfo(0.0f, 1.993f, kDefaultSaturation);\n \n+\t/* Hue adjustment is negated by kHueScale, min/max are swapped */\n+\tcmap[&controls::Hue] = ControlInfo(HueQ::TraitsType::max * kHueScale,\n+\t\t\t\t\t HueQ::TraitsType::min * kHueScale,\n+\t\t\t\t\t kDefaultHue);\n+\n \treturn 0;\n }\n \n@@ -66,6 +78,7 @@ int ColorProcessing::configure(IPAContext &context,\n \n \tcproc.brightness = BrightnessQ(kDefaultBrightness);\n \tcproc.contrast = ContrastQ(kDefaultContrast);\n+\tcproc.hue = HueQ(kDefaultHue);\n \tcproc.saturation = SaturationQ(kDefaultSaturation);\n \n \treturn 0;\n@@ -107,6 +120,18 @@ void ColorProcessing::queueRequest(IPAContext &context,\n \t\tLOG(RkISP1CProc, Debug) << \"Set contrast to \" << value;\n \t}\n \n+\tconst auto &hue = controls.get(controls::Hue);\n+\tif (hue) {\n+\t\t/* Scale the Hue from ]-90, +90] */\n+\t\tHueQ value = *hue / kHueScale;\n+\t\tif (cproc.hue != value) {\n+\t\t\tcproc.hue = value;\n+\t\t\tupdate = true;\n+\t\t}\n+\n+\t\tLOG(RkISP1CProc, Debug) << \"Set hue to \" << value;\n+\t}\n+\n \tconst auto saturation = controls.get(controls::Saturation);\n \tif (saturation) {\n \t\tSaturationQ value = *saturation;\n@@ -120,6 +145,7 @@ void ColorProcessing::queueRequest(IPAContext &context,\n \n \tframeContext.cproc.brightness = cproc.brightness;\n \tframeContext.cproc.contrast = cproc.contrast;\n+\tframeContext.cproc.hue = cproc.hue;\n \tframeContext.cproc.saturation = cproc.saturation;\n \tframeContext.cproc.update = update;\n }\n@@ -140,6 +166,7 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,\n \tconfig.setEnabled(true);\n \tconfig->brightness = frameContext.cproc.brightness.quantized();\n \tconfig->contrast = frameContext.cproc.contrast.quantized();\n+\tconfig->hue = frameContext.cproc.hue.quantized();\n \tconfig->sat = frameContext.cproc.saturation.quantized();\n }\n \n@@ -154,6 +181,7 @@ void ColorProcessing::process([[maybe_unused]] IPAContext &context,\n {\n \tmetadata.set(controls::Brightness, frameContext.cproc.brightness.value());\n \tmetadata.set(controls::Contrast, frameContext.cproc.contrast.value());\n+\tmetadata.set(controls::Hue, frameContext.cproc.hue.value() * kHueScale);\n \tmetadata.set(controls::Saturation, frameContext.cproc.saturation.value());\n }\n \ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex cca5e281c732..e61391bb1510 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -36,6 +36,7 @@ namespace ipa::rkisp1 {\n /* Fixed point types used by CPROC */\n using BrightnessQ = Q<1, 7>;\n using ContrastQ = UQ<1, 7>;\n+using HueQ = Q<1, 7>;\n using SaturationQ = UQ<1, 7>;\n \n struct IPAHwSettings {\n@@ -119,6 +120,7 @@ struct IPAActiveState {\n \tstruct {\n \t\tBrightnessQ brightness;\n \t\tContrastQ contrast;\n+\t\tHueQ hue;\n \t\tSaturationQ saturation;\n \t} cproc;\n \n@@ -181,6 +183,7 @@ struct IPAFrameContext : public FrameContext {\n \tstruct {\n \t\tBrightnessQ brightness;\n \t\tContrastQ contrast;\n+\t\tHueQ hue;\n \t\tSaturationQ saturation;\n \n \t\tbool update;\n","prefixes":["v7","09/15"]}