{"id":26139,"url":"https://patchwork.libcamera.org/api/1.1/patches/26139/?format=json","web_url":"https://patchwork.libcamera.org/patch/26139/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260212151238.3736234-4-laurent.pinchart@ideasonboard.com>","date":"2026-02-12T15:12:37","name":"[v2,3/4] libcamera: Use `it` variable name for iterators only","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2fd794763ddb2bb926863eb664b3ee69d73506d9","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26139/mbox/","series":[{"id":5787,"url":"https://patchwork.libcamera.org/api/1.1/series/5787/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5787","date":"2026-02-12T15:12:34","name":"libcamera: Clean up iterators","version":2,"mbox":"https://patchwork.libcamera.org/series/5787/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26139/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26139/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D255AC32EA\n\tfor ;\n\tThu, 12 Feb 2026 15:12:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 572D361FBF;\n\tThu, 12 Feb 2026 16:12:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA7A0621CC\n\tfor ;\n\tThu, 12 Feb 2026 16:12:43 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id DBA2D492\n\tfor ;\n\tThu, 12 Feb 2026 16:11:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cPOrMGY2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770909116;\n\tbh=l+01Hbanx+4e9pwhpj6nDti2Vnjhyi23IyAa1Ba30No=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=cPOrMGY2mMHrxsA74LIJF7g/ZrF9r0sBXhXCqwlXhOUxaJxxz6Q6aOk2RDj2wjNGA\n\taF4Fn+PmkerTPJB3okD0DjhxT0u3lxpm5CP1YmwOaj5NXJ9zxRpDGES2DTHgmVsAa0\n\trgS3vONQFdXdz2PXAsYH8RiwpNZF/g0ReuZCyRFY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 3/4] libcamera: Use `it` variable name for iterators only","Date":"Thu, 12 Feb 2026 17:12:37 +0200","Message-ID":"<20260212151238.3736234-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260212151238.3736234-1-laurent.pinchart@ideasonboard.com>","References":"<20260212151238.3736234-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Using the name `it` for a variable that is not an iterator is confusing.\nGive the variable a more explanatory name.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/ipa_data_serializer.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\nindex 61bada52f691..0dda76d5b1d1 100644\n--- a/include/libcamera/internal/ipa_data_serializer.h\n+++ b/include/libcamera/internal/ipa_data_serializer.h\n@@ -114,12 +114,12 @@ public:\n \t\tappendPOD(dataVec, vecLen);\n \n \t\t/* Serialize the members. */\n-\t\tfor (auto const &it : data) {\n+\t\tfor (const auto &value : data) {\n \t\t\tstd::vector dvec;\n \t\t\tstd::vector fvec;\n \n \t\t\tstd::tie(dvec, fvec) =\n-\t\t\t\tIPADataSerializer::serialize(it, cs);\n+\t\t\t\tIPADataSerializer::serialize(value, cs);\n \n \t\t\tappendPOD(dataVec, dvec.size());\n \t\t\tappendPOD(dataVec, fvec.size());\n","prefixes":["v2","3/4"]}