{"id":26104,"url":"https://patchwork.libcamera.org/api/1.1/patches/26104/?format=json","web_url":"https://patchwork.libcamera.org/patch/26104/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260208174450.416314-2-rui.wang@ideasonboard.com>","date":"2026-02-08T17:44:47","name":"[v1,1/4] libcamera: rkisp1: Define Denoise Pre-Filter (DPF) controls","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"14913279f663e947f21d557499238e3cf41db19f","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26104/mbox/","series":[{"id":5777,"url":"https://patchwork.libcamera.org/api/1.1/series/5777/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5777","date":"2026-02-08T17:44:46","name":"dpf_manual_patch_v1","version":1,"mbox":"https://patchwork.libcamera.org/series/5777/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26104/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26104/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 734A0BD78E\n\tfor ;\n\tSun, 8 Feb 2026 17:45:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B03A66209D;\n\tSun, 8 Feb 2026 18:45:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6984D61FC6\n\tfor ;\n\tSun, 8 Feb 2026 18:45:43 +0100 (CET)","from rui-Precision-7560.tail5b760b.ts.net (unknown\n\t[209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 94B3516AE;\n\tSun, 8 Feb 2026 18:44:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rZVKJSyh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770572698;\n\tbh=Tn4eHwTeLZtRNw3dLTBBXMQ5eWqhoyRAk65CZtNdcoQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rZVKJSyhDRWCjkTu0zxWXYnUhQPte54S43SF7gRLPJau275CyhtXELOFP21GNqxLR\n\t6TsTUWNm7Xq/DD1F2RRBdQRin64gdUG5BTNSEK9zXgGMwB72pzmTsUt32qZ56I3IuM\n\t5qQNMYZG6tAk/HoeQwwJ/TQQsbj/WABhOwT9lrLc=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v1 1/4] libcamera: rkisp1: Define Denoise Pre-Filter (DPF)\n\tcontrols","Date":"Sun, 8 Feb 2026 12:44:47 -0500","Message-ID":"<20260208174450.416314-2-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260208174450.416314-1-rui.wang@ideasonboard.com>","References":"<20260208174450.416314-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Introduce vendor-specific controls for the Rockchip ISP1 Denoise Pre-Filter\n(DPF) algorithm. These controls allow detailed configuration of the DPF block,\nincluding:\n\n- DpfEnable: Enable/disable DPF processing.\n- DpfChannelStrengths: Per-channel filter strength configuration.\n- DpfGreenSpatialCoefficients: Spatial kernel coefficients for the Green channel.\n- DpfRedBlueSpatialCoefficients: Spatial kernel coefficients for Red/Blue channels.\n- DpfRedBlueFilterSize: Filter size selection (9x9 or 13x9).\n- DpfNoiseLevelLookupCoefficients: Noise Level Lookup (NLL) table coefficients.\n- DpfNoiseLevelLookupScaleMode: NLL scaling mode (Linear/Logarithmic).\n\nAdd 'NoiseReductionModeManual' to the draft control definitions\nto support manual control of noise reduction parameters.\n\nThe 'rkisp1' vendor controls are registered in the build system with a dedicated\ncontrol ID range.\n\nSigned-off-by: Rui Wang \n---\n include/libcamera/meson.build | 1 +\n src/libcamera/control_ids_draft.yaml | 4 ++\n src/libcamera/control_ids_rkisp1.yaml | 93 +++++++++++++++++++++++++++\n src/libcamera/control_ranges.yaml | 4 +-\n 4 files changed, 101 insertions(+), 1 deletion(-)\n create mode 100644 src/libcamera/control_ids_rkisp1.yaml","diff":"diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 30ea76f9..3fd7ef94 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -39,6 +39,7 @@ controls_map = {\n 'draft': 'control_ids_draft.yaml',\n 'rpi/pisp': 'control_ids_rpi.yaml',\n 'rpi/vc4': 'control_ids_rpi.yaml',\n+ 'rkisp1': 'control_ids_rkisp1.yaml',\n },\n \n 'properties': {\ndiff --git a/src/libcamera/control_ids_draft.yaml b/src/libcamera/control_ids_draft.yaml\nindex 03309eea..97ccda1c 100644\n--- a/src/libcamera/control_ids_draft.yaml\n+++ b/src/libcamera/control_ids_draft.yaml\n@@ -58,6 +58,10 @@ controls:\n value: 4\n description: |\n Noise reduction is applied at different levels to different streams.\n+ - name: NoiseReductionModeManual\n+ value: 5\n+ description: |\n+ Manual control all noise reduction parameters.\n \n - ColorCorrectionAberrationMode:\n type: int32_t\ndiff --git a/src/libcamera/control_ids_rkisp1.yaml b/src/libcamera/control_ids_rkisp1.yaml\nnew file mode 100644\nindex 00000000..7ce9533a\n--- /dev/null\n+++ b/src/libcamera/control_ids_rkisp1.yaml\n@@ -0,0 +1,93 @@\n+# SPDX-License-Identifier: LGPL-2.1-or-later\n+#\n+# Copyright (C) 2026, Ideas On Board\n+#\n+# RkISP1 specific control definitions\n+---\n+vendor: rkisp1\n+controls:\n+ - DpfEnable:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Enable or disable the Denoise Pre-Filter (DPF) processing.\n+ When disabled (false) the hardware DPF is forced off regardless of\n+ denoise mode selection. When enabled (true) the algorithm may\n+ program parameters and adapt them from manual mode overrides.\n+ Reported in metadata as an int32_t.\n+ enum:\n+ - name: DpfEnableOff\n+ value: 0\n+ description: The DPF is disabled.\n+ - name: DpfEnableOn\n+ value: 1\n+ description: The DPF is enabled.\n+\n+ - DpfChannelStrengths:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the filter strength for Red, Green, and Blue channels respectively.\n+ Values map to hardware strength registers (typically 0..255).\n+ Size must be exactly 3 when set. Order: R, G, B.\n+ size: [3]\n+\n+ - DpfGreenSpatialCoefficients:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the 6 spatial kernel coefficients for the Green channel (9x9 kernel).\n+ Order must follow the hardware expectation.\n+ Each value corresponds to a coefficient (typically 0..16).\n+ All 6 values are required when provided; otherwise ignored.\n+ size: [6]\n+\n+ - DpfRedBlueSpatialCoefficients:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the spatial kernel coefficients for the Red and Blue channels.\n+ Applies to either 9x9 or 13x9 filter size.\n+ For 9x9 mode, the 6th value is ignored by the driver if 6 are provided,\n+ or pass 5 values if supported.\n+ Values correspond to coefficients (typically 0..16).\n+ size: [6]\n+\n+ - DpfRedBlueFilterSize:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the filter size for the Red and Blue channels.\n+ Values correspond to hardware filter size settings.\n+ enum:\n+ - name: DpfRedBlueFilterSize9x9\n+ value: 0\n+ description: 9x9 filter size.\n+ - name: DpfRedBlueFilterSize13x9\n+ value: 1\n+ description: 13x9 filter size.\n+\n+ - DpfNoiseLevelLookupCoefficients:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the 17 coefficients for the Noise Level Lookup (NLL) table.\n+ The table defines a piecewise-linear function characterizing sensor noise.\n+ Must supply the full set of 17 values when used.\n+ Values correspond to coefficients (typically 1..1023).\n+ size: [17]\n+\n+ - DpfNoiseLevelLookupScaleMode:\n+ type: int32_t\n+ direction: inout\n+ description: |\n+ Sets the NLL scale mode (0=linear, 1=logarithmic).\n+ Matches hardware RKISP1_CIF_ISP_NLL_SCALE_* constants.\n+ enum:\n+ - name: DpfNoiseLevelLookupScaleLinear\n+ value: 0\n+ description: Linear scale.\n+ - name: DpfNoiseLevelLookupScaleLogarithmic\n+ value: 1\n+ description: Logarithmic scale.\n+...\n\\ No newline at end of file\ndiff --git a/src/libcamera/control_ranges.yaml b/src/libcamera/control_ranges.yaml\nindex 6752eb98..4964894b 100644\n--- a/src/libcamera/control_ranges.yaml\n+++ b/src/libcamera/control_ranges.yaml\n@@ -15,6 +15,8 @@ ranges:\n rpi: 20000\n # Controls for debug metadata\n debug: 30000\n- # Next range starts at 40000\n+ # Rockchip ISP1 vendor controls\n+ rkisp1: 40000\n+ # Next range starts at 50000\n \n ...\n","prefixes":["v1","1/4"]}