{"id":26077,"url":"https://patchwork.libcamera.org/api/1.1/patches/26077/?format=json","web_url":"https://patchwork.libcamera.org/patch/26077/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260202-kbingham-fixups-v1-2-7d7dd4b2a27b@ideasonboard.com>","date":"2026-02-02T19:25:04","name":"[2/3] ipa: simple: Fix Ccm matrix multiplication","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"49a5ea5c183c95dfcbfcdddf3ed7a5ca5bb40c42","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26077/mbox/","series":[{"id":5766,"url":"https://patchwork.libcamera.org/api/1.1/series/5766/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5766","date":"2026-02-02T19:25:02","name":"ipa: awb: Fix and cleanup RKISP1 and Simple Awb","version":1,"mbox":"https://patchwork.libcamera.org/series/5766/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26077/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26077/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57DC0C328F\n\tfor ;\n\tMon, 2 Feb 2026 19:25:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C239462000;\n\tMon, 2 Feb 2026 20:25:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1E7661FF1\n\tfor ;\n\tMon, 2 Feb 2026 20:25:07 +0100 (CET)","from [192.168.0.240]\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 141AAC59;\n\tMon, 2 Feb 2026 20:24:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vpLS7BFn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770060267;\n\tbh=hwq5lbvYnZaQEFDjhjJkryxq8zCDzxrMsrzRIAxBmBY=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=vpLS7BFnohKJ3hiZylIKpTGEzh08WVQ2IvTY8T4wFJK8lp/MKyl+ZvR7X9wowfqIg\n\tiq0WlGxSY5LlOZzDpjqPfQ098kpFAhB50bkPpvTtrgo/3ltFt3vvnn+Q+/UcsnTOA6\n\tmVpUlnntPHHlziCwiUGYZjOVxEKmig40oAl7HTi4=","From":"Kieran Bingham ","Date":"Mon, 02 Feb 2026 19:25:04 +0000","Subject":"[PATCH 2/3] ipa: simple: Fix Ccm matrix multiplication","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260202-kbingham-fixups-v1-2-7d7dd4b2a27b@ideasonboard.com>","References":"<20260202-kbingham-fixups-v1-0-7d7dd4b2a27b@ideasonboard.com>","In-Reply-To":"<20260202-kbingham-fixups-v1-0-7d7dd4b2a27b@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ","X-Mailer":"b4 0.14.2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CCM should be applied to the current combined Matrix. Fix the\nmultiplication ordering.\n\nFixes: 82ed6c19c2b3 (\"libcamera: ipa: simple: Initialise the general correction matrix\")\nSigned-off-by: Kieran Bingham \n---\n src/ipa/simple/algorithms/ccm.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\nindex 911a5af2c90b55187f0d98519f3c29b8e0804567..90ea97b7f37ec78c747d355d7ba7ab517970b29d 100644\n--- a/src/ipa/simple/algorithms/ccm.cpp\n+++ b/src/ipa/simple/algorithms/ccm.cpp\n@@ -54,7 +54,7 @@ void Ccm::prepare(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \t}\n \n \tcontext.activeState.combinedMatrix =\n-\t\tcurrentCcm_.value() * context.activeState.combinedMatrix;\n+\t\tcontext.activeState.combinedMatrix * currentCcm_.value();\n \tframeContext.ccm = currentCcm_.value();\n }\n \n","prefixes":["2/3"]}