{"id":26073,"url":"https://patchwork.libcamera.org/api/1.1/patches/26073/?format=json","web_url":"https://patchwork.libcamera.org/patch/26073/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260202112511.640320-4-barnabas.pocze@ideasonboard.com>","date":"2026-02-02T11:25:11","name":"[RFC,v1,3/3] utils: checkstyle.py: Add `MesonFormatter`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5941ddca542f87d8384dfb91f15542f559d69136","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26073/mbox/","series":[{"id":5765,"url":"https://patchwork.libcamera.org/api/1.1/series/5765/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5765","date":"2026-02-02T11:25:09","name":"meson: Add `meson.format` file","version":1,"mbox":"https://patchwork.libcamera.org/series/5765/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26073/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26073/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F28E1C328F\n\tfor ;\n\tMon, 2 Feb 2026 11:25:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7793361FF5;\n\tMon, 2 Feb 2026 12:25:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8681061FE2\n\tfor ;\n\tMon, 2 Feb 2026 12:25:28 +0100 (CET)","from pb-laptop.local (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C39B01AAE\n\tfor ;\n\tMon, 2 Feb 2026 12:24:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HuUSu8A7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770031487;\n\tbh=PETqY9QSHav8oRqZUgoSWAzbKDOOp7zkBjJIBZKsHUU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=HuUSu8A7ygx48IoFGH9ND9cO2neQOQbrqagIsFa4mhknRj5RZllkPZAkHgc8awq4H\n\t3QN72EVDqXQEehnFH6toXhZxE1FsGEEWI1/+hszeEqg10jOTSr+dmGjcEzZC/ryEws\n\t8hkmrTWTGdd8hgzx1RfEi6cj4xqL6nKqAsPUH7B8=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 3/3] utils: checkstyle.py: Add `MesonFormatter`","Date":"Mon, 2 Feb 2026 12:25:11 +0100","Message-ID":"<20260202112511.640320-4-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260202112511.640320-1-barnabas.pocze@ideasonboard.com>","References":"<20260202112511.640320-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add support for diagnosing meson file style issues using `meson format`.\n\nSigned-off-by: Barnabás Pőcze \n---\nThis probably makes `MesonChecker` unnecessary.\n---\n utils/checkstyle.py | 30 ++++++++++++++++++++++++++++++\n 1 file changed, 30 insertions(+)\n\n--\n2.52.0","diff":"diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 06b9f199a..2dfff0473 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -919,6 +919,36 @@ class StripTrailingSpaceFormatter(Formatter):\n lines[i] = lines[i].rstrip() + '\\n'\n return ''.join(lines)\n\n+class MesonFormatter(Formatter):\n+ @staticmethod\n+ def _check_meson_version():\n+ # 1.5.0 for `meson format`\n+ # 1.7.0 for stdin input\n+ # 1.9.0 for `--source-file-path`\n+ VERSION_REQ = (1, 9, 0)\n+\n+ ret = subprocess.run(['meson', '--version'],\n+ stdin=subprocess.DEVNULL,\n+ stdout=subprocess.PIPE,\n+ stderr=subprocess.PIPE)\n+\n+ ver = tuple(map(int, ret.stdout.decode('utf-8').split('.')))\n+ if ver < VERSION_REQ:\n+ return [\n+ CommitIssue(f'Missing meson {\".\".join(map(str, VERSION_REQ))} to run `meson format`')\n+ ]\n+\n+\n+ dependencies = (('meson', _check_meson_version), )\n+ patterns = ('meson.build', )\n+\n+ @classmethod\n+ def format(cls, filename, data):\n+ ret = subprocess.run(['meson', 'format', '-',\n+ '--source-file-path', filename],\n+ input=data.encode('utf-8'), stdout=subprocess.PIPE)\n+ return ret.stdout.decode('utf-8')\n+\n\n # ------------------------------------------------------------------------------\n # Style checking\n","prefixes":["RFC","v1","3/3"]}