{"id":26022,"url":"https://patchwork.libcamera.org/api/1.1/patches/26022/?format=json","web_url":"https://patchwork.libcamera.org/patch/26022/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260128-sklug-lsc-resampling-v2-dev-v6-11-af7d95f03d22@ideasonboard.com>","date":"2026-01-28T16:00:28","name":"[v6,11/15] ipa: rkisp1: lsc: Pass sampling positions into samplePolynomial","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3dd4192690006676d19cbb11458c690ef29120ca","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26022/mbox/","series":[{"id":5751,"url":"https://patchwork.libcamera.org/api/1.1/series/5751/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5751","date":"2026-01-28T16:00:17","name":"Add resampling support for polynomial LSC data","version":6,"mbox":"https://patchwork.libcamera.org/series/5751/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26022/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26022/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA48DC3200\n\tfor ;\n\tWed, 28 Jan 2026 16:00:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 782CB61FDE;\n\tWed, 28 Jan 2026 17:00:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE75961FD3\n\tfor ;\n\tWed, 28 Jan 2026 17:00:56 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:1a60:e70f:ec38:13a9])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9F4F32815; \n\tWed, 28 Jan 2026 17:00:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u1pfIGDg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769616019;\n\tbh=HFW64clCVsFVVMzqyef9BqiKV0Efp7Dv7GudBjgZ3b0=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=u1pfIGDgVnM2I4SfojXMUxJ4+rLubm0qrQHnfHjRSuSMk9HdL1bMbaZoTNes8dp5v\n\tpWEoPbYWd74xeKuGH9wTx2HlXDbG4Ik1WjvvjiZ3y5rraCCfthfJDQTwkOwXzR5XG/\n\ti1QzNKV8BgTz8anD4hJR+0ymhPsqpwuGO9OpoQrw=","From":"Stefan Klug ","Date":"Wed, 28 Jan 2026 17:00:28 +0100","Subject":"[PATCH v6 11/15] ipa: rkisp1: lsc: Pass sampling positions into\n\tsamplePolynomial","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260128-sklug-lsc-resampling-v2-dev-v6-11-af7d95f03d22@ideasonboard.com>","References":"<20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com>","In-Reply-To":"<20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug , =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= , Laurent Pinchart\n\t","X-Mailer":"b4 0.14.2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no need to recalculate the sampling positions over and over.\nPass them as parameter into the sampling function. The vectors are still\nkept inside the loop as this is also a preparatory change for the\nupcoming refactoring.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Barnabás Pőcze \nReviewed-by: Laurent Pinchart \n\n---\n\nChanges in v2:\n- Small fixes from review:\n - Replaced move construction by move assignments\n - Replaced some vectors by Spans\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 37 ++++++++++++++++++-------------------\n 1 file changed, 18 insertions(+), 19 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex daf5c9a9b8fddf290a55471c4dce608f1b8ec82a..a70551ab70afec684d9c92bb9769c63d0f4f2653 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -91,7 +91,9 @@ public:\n \n private:\n \tstd::vector sizesListToPositions(const std::vector &sizes);\n-\tstd::vector samplePolynomial(const LscPolynomial &poly);\n+\tstd::vector samplePolynomial(const LscPolynomial &poly,\n+\t\t\t\t\t Span xPositions,\n+\t\t\t\t\t Span yPositions);\n \n \tSize sensorSize_;\n \tRectangle cropRectangle_;\n@@ -131,10 +133,13 @@ int LscPolynomialLoader::parseLscData(const YamlObject &yamlSets,\n \t\tpgr->setReferenceImageSize(sensorSize_);\n \t\tpgb->setReferenceImageSize(sensorSize_);\n \t\tpb->setReferenceImageSize(sensorSize_);\n-\t\tset.r = samplePolynomial(*pr);\n-\t\tset.gr = samplePolynomial(*pgr);\n-\t\tset.gb = samplePolynomial(*pgb);\n-\t\tset.b = samplePolynomial(*pb);\n+\n+\t\tstd::vector xPos = sizesListToPositions(xSizes_);\n+\t\tstd::vector yPos = sizesListToPositions(ySizes_);\n+\t\tset.r = samplePolynomial(*pr, xPos, yPos);\n+\t\tset.gr = samplePolynomial(*pgr, xPos, yPos);\n+\t\tset.gb = samplePolynomial(*pgb, xPos, yPos);\n+\t\tset.b = samplePolynomial(*pb, xPos, yPos);\n \t}\n \n \tif (lscData.empty()) {\n@@ -171,10 +176,10 @@ std::vector LscPolynomialLoader::sizesListToPositions(const std::vector<\n \treturn positions;\n }\n \n-std::vector LscPolynomialLoader::samplePolynomial(const LscPolynomial &poly)\n+std::vector LscPolynomialLoader::samplePolynomial(const LscPolynomial &poly,\n+\t\t\t\t\t\t\t Span xPositions,\n+\t\t\t\t\t\t\t Span yPositions)\n {\n-\tconstexpr int k = RKISP1_CIF_ISP_LSC_SAMPLES_MAX;\n-\n \tdouble m = poly.getM();\n \tdouble x0 = cropRectangle_.x / m;\n \tdouble y0 = cropRectangle_.y / m;\n@@ -182,18 +187,12 @@ std::vector LscPolynomialLoader::samplePolynomial(const LscPolynomial\n \tdouble h = cropRectangle_.height / m;\n \tstd::vector samples;\n \n-\tASSERT(xSizes_.size() * 2 + 1 == k);\n-\tASSERT(ySizes_.size() * 2 + 1 == k);\n-\n-\tsamples.reserve(k * k);\n-\n-\tstd::vector xPos(sizesListToPositions(xSizes_));\n-\tstd::vector yPos(sizesListToPositions(ySizes_));\n+\tsamples.reserve(xPositions.size() * yPositions.size());\n \n-\tfor (int y = 0; y < k; y++) {\n-\t\tfor (int x = 0; x < k; x++) {\n-\t\t\tdouble xp = x0 + xPos[x] * w;\n-\t\t\tdouble yp = y0 + yPos[y] * h;\n+\tfor (double y : yPositions) {\n+\t\tfor (double x : xPositions) {\n+\t\t\tdouble xp = x0 + x * w;\n+\t\t\tdouble yp = y0 + y * h;\n \t\t\t/*\n \t\t\t * The hardware uses 2.10 fixed point format and limits\n \t\t\t * the legal values to [1..3.999]. Scale and clamp the\n","prefixes":["v6","11/15"]}