{"id":26005,"url":"https://patchwork.libcamera.org/api/1.1/patches/26005/?format=json","web_url":"https://patchwork.libcamera.org/patch/26005/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260128114402.31570-13-mzamazal@redhat.com>","date":"2026-01-28T11:43:59","name":"[v5,12/15] libcamera: ipa: simple: Use symbolic constants for adjust defaults","commit_ref":"43a2ff5c2f590532a53b5ffdd19a37631c885363","pull_url":null,"state":"accepted","archived":false,"hash":"5d7f67af2b8230ab5dde623bca05088b90769383","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26005/mbox/","series":[{"id":5748,"url":"https://patchwork.libcamera.org/api/1.1/series/5748/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5748","date":"2026-01-28T11:43:47","name":"Simple pipeline IPA cleanup","version":5,"mbox":"https://patchwork.libcamera.org/series/5748/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26005/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26005/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35534C3200\n\tfor ;\n\tWed, 28 Jan 2026 11:44:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90D0261FFC;\n\tWed, 28 Jan 2026 12:44:47 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88D4261FD3\n\tfor ;\n\tWed, 28 Jan 2026 12:44:40 +0100 (CET)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-106-PRxmicG6PGi7bjIyVTo_fQ-1;\n\tWed, 28 Jan 2026 06:44:38 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 2346C19775A3; Wed, 28 Jan 2026 11:44:37 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.236])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 11AE319560B2; Wed, 28 Jan 2026 11:44:34 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ZFg8TaIt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769600679;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=qwc3MDgveHRMPpmSPMcogDqaqKS6nMiSM5Cb1HbqB1M=;\n\tb=ZFg8TaItzIOslu3GODmNb5F2PK99ypGqT6mDDophK4nD/g76mBLDVNPdKitWkPg9d/RnG+\n\tydM1vHjLXMMdNGe28GepkroWi8Y3OcD56G/dI2EZREhqTsPXBcYjn/SneMZLBC/RzRE2JS\n\tm+TSQYxQ3ECthQoGv1My+7xwABR2olo=","X-MC-Unique":"PRxmicG6PGi7bjIyVTo_fQ-1","X-Mimecast-MFC-AGG-ID":"PRxmicG6PGi7bjIyVTo_fQ_1769600677","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Robert Mader\n\t","Subject":"[PATCH v5 12/15] libcamera: ipa: simple: Use symbolic constants for\n\tadjust defaults","Date":"Wed, 28 Jan 2026 12:43:59 +0100","Message-ID":"<20260128114402.31570-13-mzamazal@redhat.com>","In-Reply-To":"<20260128114402.31570-1-mzamazal@redhat.com>","References":"<20260128114402.31570-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"sKACZM_Vam2TvpAK1q7Twqh7zygpyYL3ho7X4-Xykco_1769600677","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The adjust algorithm already uses a symbolic constant for gamma. Let's\nintroduce similar constants for contrast and saturation to prevent\ncopying the numeric defaults to multiple places.\n\nReviewed-by: Barnabás Pőcze \nReviewed-by: Robert Mader \nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/adjust.cpp | 16 +++++++++++-----\n 1 file changed, 11 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp\nindex a8b7c5ab6..23f6f6ad7 100644\n--- a/src/ipa/simple/algorithms/adjust.cpp\n+++ b/src/ipa/simple/algorithms/adjust.cpp\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n /*\n * Copyright (C) 2024, Ideas On Board\n- * Copyright (C) 2024-2025, Red Hat Inc.\n+ * Copyright (C) 2024-2026, Red Hat Inc.\n *\n * Common image adjustments\n */\n@@ -19,14 +19,20 @@ namespace libcamera {\n \n namespace ipa::soft::algorithms {\n \n+constexpr float kDefaultContrast = 1.0f;\n+constexpr float kDefaultSaturation = 1.0f;\n+\n LOG_DEFINE_CATEGORY(IPASoftAdjust)\n \n int Adjust::init(IPAContext &context, [[maybe_unused]] const YamlObject &tuningData)\n {\n-\tcontext.ctrlMap[&controls::Gamma] = ControlInfo(0.1f, 10.0f, kDefaultGamma);\n-\tcontext.ctrlMap[&controls::Contrast] = ControlInfo(0.0f, 2.0f, 1.0f);\n+\tcontext.ctrlMap[&controls::Gamma] =\n+\t\tControlInfo(0.1f, 10.0f, kDefaultGamma);\n+\tcontext.ctrlMap[&controls::Contrast] =\n+\t\tControlInfo(0.0f, 2.0f, kDefaultContrast);\n \tif (context.ccmEnabled)\n-\t\tcontext.ctrlMap[&controls::Saturation] = ControlInfo(0.0f, 2.0f, 1.0f);\n+\t\tcontext.ctrlMap[&controls::Saturation] =\n+\t\t\tControlInfo(0.0f, 2.0f, kDefaultSaturation);\n \treturn 0;\n }\n \n@@ -122,7 +128,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,\n \t\tmetadata.set(controls::Contrast, contrast.value());\n \n \tconst auto &saturation = frameContext.saturation;\n-\tmetadata.set(controls::Saturation, saturation.value_or(1.0));\n+\tmetadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));\n }\n \n REGISTER_IPA_ALGORITHM(Adjust, \"Adjust\")\n","prefixes":["v5","12/15"]}