{"id":25995,"url":"https://patchwork.libcamera.org/api/1.1/patches/25995/?format=json","web_url":"https://patchwork.libcamera.org/patch/25995/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260128114402.31570-3-mzamazal@redhat.com>","date":"2026-01-28T11:43:49","name":"[v5,02/15] libcamera: ipa: simple: Unwrap IPAFrameContext::ccm","commit_ref":"3dbe06a15fc59aaf9625cdc6f167d4196f1fc03a","pull_url":null,"state":"accepted","archived":false,"hash":"7ac9c86f8826622fd9d9726c3b5a09cd420c8bbd","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25995/mbox/","series":[{"id":5748,"url":"https://patchwork.libcamera.org/api/1.1/series/5748/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5748","date":"2026-01-28T11:43:47","name":"Simple pipeline IPA cleanup","version":5,"mbox":"https://patchwork.libcamera.org/series/5748/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25995/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25995/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF9E3C3200\n\tfor ;\n\tWed, 28 Jan 2026 11:44:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AFC061FCC;\n\tWed, 28 Jan 2026 12:44:21 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99B7F61FCC\n\tfor ;\n\tWed, 28 Jan 2026 12:44:18 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-590-mnubTlvQM4qfOxegWK84rA-1;\n\tWed, 28 Jan 2026 06:44:14 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 8A5A11944EB7; Wed, 28 Jan 2026 11:44:12 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.236])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id DC9E319560B2; Wed, 28 Jan 2026 11:44:10 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"cCTn0sSm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769600657;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ecGQpeqL+0q1o7SA6sjZ4G4MfTbDuFJ/73Hvra+WDYc=;\n\tb=cCTn0sSmTXn4ysWg130X5Aq8uMccqwxaMf/RhDrGRVOVxhoFoDKtHZ+/0lOgM0x63QQkja\n\ttk4Gkfat34vpnj42bZlFxW/O9slrMipXxSUekj/NiUrggC2b3RTpGD2a/HiRXSXgfvLOO7\n\tFU6T567kXaEIyOA8qe/Qd9X1UOUpL6w=","X-MC-Unique":"mnubTlvQM4qfOxegWK84rA-1","X-Mimecast-MFC-AGG-ID":"mnubTlvQM4qfOxegWK84rA_1769600653","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"[PATCH v5 02/15] libcamera: ipa: simple: Unwrap IPAFrameContext::ccm","Date":"Wed, 28 Jan 2026 12:43:49 +0100","Message-ID":"<20260128114402.31570-3-mzamazal@redhat.com>","In-Reply-To":"<20260128114402.31570-1-mzamazal@redhat.com>","References":"<20260128114402.31570-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"D0lMclc0-zBLclYGcEh-qUHK2Jl8PyRqXN1RrqlcGwk_1769600653","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The struct has only one member and there is no immediate need to add\nmore. Let's use the member directly, to make things a bit simpler.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Barnabás Pőcze \nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/ccm.cpp | 6 +++---\n src/ipa/simple/ipa_context.h | 4 +---\n 2 files changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\nindex 0a98406c1..d7d3dda76 100644\n--- a/src/ipa/simple/algorithms/ccm.cpp\n+++ b/src/ipa/simple/algorithms/ccm.cpp\n@@ -94,7 +94,7 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \tif (frame > 0 &&\n \t utils::abs_diff(ct, lastCt_) < kTemperatureThreshold &&\n \t saturation == lastSaturation_) {\n-\t\tframeContext.ccm.ccm = context.activeState.ccm.ccm;\n+\t\tframeContext.ccm = context.activeState.ccm.ccm;\n \t\tcontext.activeState.ccm.changed = false;\n \t\treturn;\n \t}\n@@ -106,9 +106,9 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \t\tapplySaturation(ccm, saturation.value());\n \n \tcontext.activeState.ccm.ccm = ccm;\n-\tframeContext.ccm.ccm = ccm;\n \tframeContext.saturation = saturation;\n \tcontext.activeState.ccm.changed = true;\n+\tframeContext.ccm = ccm;\n }\n \n void Ccm::process([[maybe_unused]] IPAContext &context,\n@@ -117,7 +117,7 @@ void Ccm::process([[maybe_unused]] IPAContext &context,\n \t\t [[maybe_unused]] const SwIspStats *stats,\n \t\t ControlList &metadata)\n {\n-\tmetadata.set(controls::ColourCorrectionMatrix, frameContext.ccm.ccm.data());\n+\tmetadata.set(controls::ColourCorrectionMatrix, frameContext.ccm.data());\n \n \tconst auto &saturation = frameContext.saturation;\n \tmetadata.set(controls::Saturation, saturation.value_or(1.0));\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 26db92e93..74e77c841 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -75,9 +75,7 @@ struct IPAActiveState {\n };\n \n struct IPAFrameContext : public FrameContext {\n-\tstruct {\n-\t\tMatrix ccm;\n-\t} ccm;\n+\tMatrix ccm;\n \n \tstruct {\n \t\tint32_t exposure;\n","prefixes":["v5","02/15"]}