{"id":25939,"url":"https://patchwork.libcamera.org/api/1.1/patches/25939/?format=json","web_url":"https://patchwork.libcamera.org/patch/25939/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260122161935.208562-14-mzamazal@redhat.com>","date":"2026-01-22T16:19:33","name":"[v4,13/15] libcamera: ipa: simple: Set contrast metadata unconditionally","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7ad77f9c682c7a047a6872bfc9683f7d0faa8ead","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25939/mbox/","series":[{"id":5733,"url":"https://patchwork.libcamera.org/api/1.1/series/5733/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5733","date":"2026-01-22T16:19:20","name":"Simple pipeline IPA cleanup","version":4,"mbox":"https://patchwork.libcamera.org/series/5733/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25939/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25939/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57561C32E7\n\tfor ;\n\tThu, 22 Jan 2026 16:20:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E459661FD4;\n\tThu, 22 Jan 2026 17:20:44 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9B5C61FD4\n\tfor ;\n\tThu, 22 Jan 2026 17:20:40 +0100 (CET)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-592-gznZBotmPUq7EZA1Xx_wSA-1;\n\tThu, 22 Jan 2026 11:20:38 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id B3F8118005B9; Thu, 22 Jan 2026 16:20:37 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.97])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D5CC81800577; Thu, 22 Jan 2026 16:20:35 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"OuzN7tWq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769098839;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=TUhFj8SRsM46CjnXWoH94NdCUQQqhOFuMXl9BYm8uKQ=;\n\tb=OuzN7tWqjIPXlMvTPsWdJFlqPvGE+cWSXRaYeMFLU+hXTvFDQgiYr4rWJvzccSJjhr5DX6\n\tBG2FO4koiITbitAC1cTocjAtFCg36nctmPMpLnflLQ21Rq6vcYghSTZtJdb6sf+N2dR5Ip\n\tsXx7cd1LBYzHKLVn453oDXhOas5TiEY=","X-MC-Unique":"gznZBotmPUq7EZA1Xx_wSA-1","X-Mimecast-MFC-AGG-ID":"gznZBotmPUq7EZA1Xx_wSA_1769098837","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"[PATCH v4 13/15] libcamera: ipa: simple: Set contrast metadata\n\tunconditionally","Date":"Thu, 22 Jan 2026 17:19:33 +0100","Message-ID":"<20260122161935.208562-14-mzamazal@redhat.com>","In-Reply-To":"<20260122161935.208562-1-mzamazal@redhat.com>","References":"<20260122161935.208562-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"nHANZ44jPcP5SJoIBdPrzuSRu-x3nbrXVH73bV_W-8k_1769098837","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Let's do the same with contrast as with other metadata.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/adjust.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp\nindex 23f6f6ad7..acdd3f741 100644\n--- a/src/ipa/simple/algorithms/adjust.cpp\n+++ b/src/ipa/simple/algorithms/adjust.cpp\n@@ -124,8 +124,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,\n \tmetadata.set(controls::Gamma, gamma);\n \n \tconst auto &contrast = frameContext.contrast;\n-\tif (contrast)\n-\t\tmetadata.set(controls::Contrast, contrast.value());\n+\tmetadata.set(controls::Contrast, contrast.value_or(kDefaultContrast));\n \n \tconst auto &saturation = frameContext.saturation;\n \tmetadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));\n","prefixes":["v4","13/15"]}