{"id":25923,"url":"https://patchwork.libcamera.org/api/1.1/patches/25923/?format=json","web_url":"https://patchwork.libcamera.org/patch/25923/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260121173737.376113-17-kieran.bingham@ideasonboard.com>","date":"2026-01-21T17:37:35","name":"[v6,16/16] ipa: libipa: fixedpoint: Remove unsigned workaround","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"382aaa9077871e463411ce7f41b2395c1f586340","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25923/mbox/","series":[{"id":5730,"url":"https://patchwork.libcamera.org/api/1.1/series/5730/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5730","date":"2026-01-21T17:37:19","name":"libipa: Introduce a Quantized type","version":6,"mbox":"https://patchwork.libcamera.org/series/5730/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25923/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25923/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2D06C32E7\n\tfor ;\n\tWed, 21 Jan 2026 17:38:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A688061FD0;\n\tWed, 21 Jan 2026 18:38:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CD8461FE4\n\tfor ;\n\tWed, 21 Jan 2026 18:37:46 +0100 (CET)","from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 668942965;\n\tWed, 21 Jan 2026 18:37:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jBerSPxV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769017034;\n\tbh=CKVkopKkamAgigI5a3RtF96o/5VhLIlo77pMT7BToMc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jBerSPxVhKij2qz5fnJQGIlhWuhK5GGdyRYUQ94jXv/ssdKkhwwFArlhg0ELtq0FV\n\tfx8xkRv5CNaagzcmfG0arxA2pAQpWSeDNHWD0r10ZviRhiH3gJqZMHmsu5qd6NBM3L\n\tGJaSDriQ7zyp8MN5rV5Q7yEk+mE39v48bGBftgEk=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham , =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= ","Subject":"[PATCH v6 16/16] ipa: libipa: fixedpoint: Remove unsigned workaround","Date":"Wed, 21 Jan 2026 17:37:35 +0000","Message-ID":"<20260121173737.376113-17-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","References":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that we no longer attempt or allow storing signed negative floats\nas an unsigned integer representation, remove the workaround which\nrequired an intermediate cast when converting floats to fixed point values.\n\nReviewed-by: Barnabás Pőcze \nSigned-off-by: Kieran Bingham \n---\n src/ipa/libipa/fixedpoint.h | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)","diff":"diff --git a/src/ipa/libipa/fixedpoint.h b/src/ipa/libipa/fixedpoint.h\nindex 1a871bc554ef..b7dbb00cadaa 100644\n--- a/src/ipa/libipa/fixedpoint.h\n+++ b/src/ipa/libipa/fixedpoint.h\n@@ -75,12 +75,7 @@ public:\n \t{\n \t\tv = std::clamp(v, min, max);\n \n-\t\t/*\n-\t\t * The intermediate cast to int is needed on arm platforms to\n-\t\t * properly cast negative values. See\n-\t\t * https://embeddeduse.com/2013/08/25/casting-a-negative-float-to-an-unsigned-int/\n-\t\t */\n-\t\treturn static_cast(static_cast(std::round(v * (1 << F)))) & bitMask;\n+\t\treturn static_cast(std::round(v * (1 << F))) & bitMask;\n \t}\n };\n \n","prefixes":["v6","16/16"]}