{"id":25919,"url":"https://patchwork.libcamera.org/api/1.1/patches/25919/?format=json","web_url":"https://patchwork.libcamera.org/patch/25919/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260121173737.376113-13-kieran.bingham@ideasonboard.com>","date":"2026-01-21T17:37:31","name":"[v6,12/16] ipa: mali-c55: Convert AWB to UQ<4, 8> usage","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"200c8a916713bda3ec49a8bd487b3dacb9aa086f","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25919/mbox/","series":[{"id":5730,"url":"https://patchwork.libcamera.org/api/1.1/series/5730/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5730","date":"2026-01-21T17:37:19","name":"libipa: Introduce a Quantized type","version":6,"mbox":"https://patchwork.libcamera.org/series/5730/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25919/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25919/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D247BDCBF\n\tfor ;\n\tWed, 21 Jan 2026 17:38:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17C5E61FD9;\n\tWed, 21 Jan 2026 18:38:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1648761FCE\n\tfor ;\n\tWed, 21 Jan 2026 18:37:45 +0100 (CET)","from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12950250A;\n\tWed, 21 Jan 2026 18:37:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m3gyzqQx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769017033;\n\tbh=cXsmpqFcPSIlu4xwR5TnKmghrvaU2bOqX4277Jb8v9I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=m3gyzqQxzzewZnJZ1m57GRpvxWpWktSOaBe2yRhEjsdOIP+EEMdZBrWsX/xjV1dty\n\ta1oEmAvVZzucQipVj0tG4399JnrPEjDhN0uTysEajT6KU5SSvCCl1T9nT51lnOhSy8\n\tybjvOFAWZ6FoHmETVHDVqVJelv1VjWjN1DyG5vtg=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham , Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"[PATCH v6 12/16] ipa: mali-c55: Convert AWB to UQ<4, 8> usage","Date":"Wed, 21 Jan 2026 17:37:31 +0000","Message-ID":"<20260121173737.376113-13-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","References":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Utilise the new FixedPoint type to explicitly calculate gains for AWB in Q4.8\nformat. This ensures that reporting of gains in metadata reflect the true\nAWB gains applied.\n\nReviewed-by: Isaac Scott \nReviewed-by: Barnabás Pőcze \nSigned-off-by: Kieran Bingham \n\n---\nv5:\n- Use UQ<4, 8> directly\n- Change debug prints to use operator<<\n- Now based on top of float types instead of doubles\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/mali-c55/algorithms/awb.cpp | 36 ++++++++++++++---------------\n src/ipa/mali-c55/ipa_context.h | 10 ++++----\n 2 files changed, 24 insertions(+), 22 deletions(-)","diff":"diff --git a/src/ipa/mali-c55/algorithms/awb.cpp b/src/ipa/mali-c55/algorithms/awb.cpp\nindex b179dd7f0c1c..a5150bbf3d97 100644\n--- a/src/ipa/mali-c55/algorithms/awb.cpp\n+++ b/src/ipa/mali-c55/algorithms/awb.cpp\n@@ -37,8 +37,8 @@ int Awb::configure([[maybe_unused]] IPAContext &context,\n \t * for the first frame we will make no assumptions and leave the R/B\n \t * channels unmodified.\n \t */\n-\tcontext.activeState.awb.rGain = 1.0;\n-\tcontext.activeState.awb.bGain = 1.0;\n+\tcontext.activeState.awb.rGain = 1.0f;\n+\tcontext.activeState.awb.bGain = 1.0f;\n \n \treturn 0;\n }\n@@ -46,8 +46,8 @@ int Awb::configure([[maybe_unused]] IPAContext &context,\n void Awb::fillGainsParamBlock(MaliC55Params *params, IPAContext &context,\n \t\t\t\tIPAFrameContext &frameContext)\n {\n-\tdouble rGain = context.activeState.awb.rGain;\n-\tdouble bGain = context.activeState.awb.bGain;\n+\tUQ<4, 8> rGain = context.activeState.awb.rGain;\n+\tUQ<4, 8> bGain = context.activeState.awb.bGain;\n \n \t/*\n \t * The gains here map as follows:\n@@ -61,10 +61,10 @@ void Awb::fillGainsParamBlock(MaliC55Params *params, IPAContext &context,\n \t */\n \tauto block = params->block();\n \n-\tblock->gain00 = floatingToFixedPoint<4, 8, uint16_t, double>(rGain);\n-\tblock->gain01 = floatingToFixedPoint<4, 8, uint16_t, double>(1.0);\n-\tblock->gain10 = floatingToFixedPoint<4, 8, uint16_t, double>(1.0);\n-\tblock->gain11 = floatingToFixedPoint<4, 8, uint16_t, double>(bGain);\n+\tblock->gain00 = rGain.quantized();\n+\tblock->gain01 = UQ<4, 8>(1.0f).quantized();\n+\tblock->gain10 = UQ<4, 8>(1.0f).quantized();\n+\tblock->gain11 = bGain.quantized();\n \n \tframeContext.awb.rGain = rGain;\n \tframeContext.awb.bGain = bGain;\n@@ -140,18 +140,18 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * gain figures that we can apply to approximate a grey world.\n \t */\n \tunsigned int counted_zones = 0;\n-\tdouble rgSum = 0, bgSum = 0;\n+\tfloat rgSum = 0, bgSum = 0;\n \n \tfor (unsigned int i = 0; i < 225; i++) {\n \t\tif (!awb_ratios[i].num_pixels)\n \t\t\tcontinue;\n \n \t\t/*\n-\t\t * The statistics are in Q4.8 format, so we convert to double\n+\t\t * The statistics are in Q4.8 format, so we convert to float\n \t\t * here.\n \t\t */\n-\t\trgSum += fixedToFloatingPoint<4, 8, double, uint16_t>(awb_ratios[i].avg_rg_gr);\n-\t\tbgSum += fixedToFloatingPoint<4, 8, double, uint16_t>(awb_ratios[i].avg_bg_br);\n+\t\trgSum += UQ<4, 8>(awb_ratios[i].avg_rg_gr).value();\n+\t\tbgSum += UQ<4, 8>(awb_ratios[i].avg_bg_br).value();\n \t\tcounted_zones++;\n \t}\n \n@@ -174,8 +174,8 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * figure by the gains that were applied when the statistics for this\n \t * frame were generated.\n \t */\n-\tfloat rRatio = rgAvg / frameContext.awb.rGain;\n-\tfloat bRatio = bgAvg / frameContext.awb.bGain;\n+\tfloat rRatio = rgAvg / frameContext.awb.rGain.value();\n+\tfloat bRatio = bgAvg / frameContext.awb.bGain.value();\n \n \t/*\n \t * And then we can simply invert the ratio to find the gain we should\n@@ -191,15 +191,15 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * want to fix the miscolouring as quickly as possible.\n \t */\n \tfloat speed = frame < kNumStartupFrames ? 1.0 : 0.2;\n-\trGain = speed * rGain + context.activeState.awb.rGain * (1.0 - speed);\n-\tbGain = speed * bGain + context.activeState.awb.bGain * (1.0 - speed);\n+\trGain = speed * rGain + context.activeState.awb.rGain.value() * (1.0 - speed);\n+\tbGain = speed * bGain + context.activeState.awb.bGain.value() * (1.0 - speed);\n \n \tcontext.activeState.awb.rGain = rGain;\n \tcontext.activeState.awb.bGain = bGain;\n \n \tmetadata.set(controls::ColourGains, {\n-\t\tstatic_cast(frameContext.awb.rGain),\n-\t\tstatic_cast(frameContext.awb.bGain),\n+\t\tframeContext.awb.rGain.value(),\n+\t\tframeContext.awb.bGain.value(),\n \t});\n \n \tLOG(MaliC55Awb, Debug) << \"For frame number \" << frame << \": \"\ndiff --git a/src/ipa/mali-c55/ipa_context.h b/src/ipa/mali-c55/ipa_context.h\nindex 13885eb83b5c..08f78e4f74ce 100644\n--- a/src/ipa/mali-c55/ipa_context.h\n+++ b/src/ipa/mali-c55/ipa_context.h\n@@ -14,6 +14,8 @@\n \n #include \n \n+#include \"libipa/fixedpoint.h\"\n+\n namespace libcamera {\n \n namespace ipa::mali_c55 {\n@@ -53,8 +55,8 @@ struct IPAActiveState {\n \t} agc;\n \n \tstruct {\n-\t\tdouble rGain;\n-\t\tdouble bGain;\n+\t\tUQ<4, 8> rGain;\n+\t\tUQ<4, 8> bGain;\n \t} awb;\n };\n \n@@ -66,8 +68,8 @@ struct IPAFrameContext : public FrameContext {\n \t} agc;\n \n \tstruct {\n-\t\tdouble rGain;\n-\t\tdouble bGain;\n+\t\tUQ<4, 8> rGain;\n+\t\tUQ<4, 8> bGain;\n \t} awb;\n };\n \n","prefixes":["v6","12/16"]}