{"id":25917,"url":"https://patchwork.libcamera.org/api/1.1/patches/25917/?format=json","web_url":"https://patchwork.libcamera.org/patch/25917/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260121173737.376113-11-kieran.bingham@ideasonboard.com>","date":"2026-01-21T17:37:29","name":"[v6,10/16] ipa: rkisp1: ccm: Use Q<4, 7> format directly","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bdb6b793191bcdfb1f40e7cce77a9bc2eba7b3c4","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25917/mbox/","series":[{"id":5730,"url":"https://patchwork.libcamera.org/api/1.1/series/5730/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5730","date":"2026-01-21T17:37:19","name":"libipa: Introduce a Quantized type","version":6,"mbox":"https://patchwork.libcamera.org/series/5730/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25917/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25917/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7535C327D\n\tfor ;\n\tWed, 21 Jan 2026 17:37:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 662A961FCE;\n\tWed, 21 Jan 2026 18:37:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91B6B61F9F\n\tfor ;\n\tWed, 21 Jan 2026 18:37:44 +0100 (CET)","from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8EA5021CD;\n\tWed, 21 Jan 2026 18:37:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F3L6zyq8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769017032;\n\tbh=YPE5gkcA66kXlvLXUDbn/4+TohltFJVoF0d5iMAvZuI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=F3L6zyq8p8aBCtX3FJhW0chRl7bnLOtKOvMk/YiP/BKQkmTNoeGeh0zHrym2hrAUq\n\tLBiojMtbHsXLCI7yYsM7+8uGKdDA+t5V32HGf1/eqY31bkLs/ulXlGDyHsYRqLw88d\n\tQXc5GF7psi9XWDHOCWPaaTs8igPJGOa6PP09JFbM=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham , Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"[PATCH v6 10/16] ipa: rkisp1: ccm: Use Q<4, 7> format directly","Date":"Wed, 21 Jan 2026 17:37:29 +0000","Message-ID":"<20260121173737.376113-11-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","References":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace the legacy call to floatingToFixedPoint with the new FixedPoint\nquantizer to explicitly describe the type used by the RKISP1 Colour\nCorrection Matrix.\n\nReviewed-by: Isaac Scott \nReviewed-by: Barnabás Pőcze \nSigned-off-by: Kieran Bingham \n\n---\nv5:\n - Use Q<4, 7>\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/rkisp1/algorithms/ccm.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\nindex de2b6fe775aa..466d7a116eea 100644\n--- a/src/ipa/rkisp1/algorithms/ccm.cpp\n+++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n@@ -117,8 +117,7 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n \t */\n \tfor (unsigned int i = 0; i < 3; i++) {\n \t\tfor (unsigned int j = 0; j < 3; j++)\n-\t\t\tconfig.coeff[i][j] =\n-\t\t\t\tfloatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n+\t\t\tconfig.coeff[i][j] = Q<4, 7>(matrix[i][j]).quantized();\n \t}\n \n \tfor (unsigned int i = 0; i < 3; i++)\n","prefixes":["v6","10/16"]}